public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen-Yu Tsai <wens@kernel.org>,
	Samuel Holland <samuel@sholland.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Michal Piekos <michal.piekos@mmpsystems.pl>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michal Piekos <michal.piekos@mmpsystems.pl>
Subject: Re: [PATCH 0/2] arm64: dts: allwinner: fix Orange Pi Zero 3 PMIC interrupt routing
Date: Sun, 08 Mar 2026 09:23:01 +0100	[thread overview]
Message-ID: <3404622.44csPzL39Z@jernej-laptop> (raw)
In-Reply-To: <20260308-rc2-boot-hang-v1-0-d792d1a78dfd@mmpsystems.pl>

Hi Michal,

Dne nedelja, 8. marec 2026 ob 06:16:50 Srednjeevropski standardni čas je Michal Piekos napisal(a):
> This fixes a kernel hang during boot on the Orange Pi Zero 3 caused by
> incorrect interrupt routing for the AXP313A PMIC.
> 
> The PMIC interrupt on is connected to PL bank GPIO handled by the R_PIO
> controller. However current dts routes the interrupts to PIO controller.
> This causes the kernel to select wrong pinctrl instance when configuring
> the interrupt which leads to invalid register access and a kernel hang
> during boot.

Where did you get that info? Publicly available schematic clearly shows
PMIC interrupt pin being connected to PC9. Additionally, R_PIO controller
on H616 is very basic and has only pins PL0 and PL1, which are used for
PMIC communication already. Neither of those pins is interrupt capable.

> 
> The problem existed previously but became visible after the commit
> 01e10d0272b9 (pinctrl: sunxi: Implement gpiochip::get_direction()),
> which causes gpiolib to call the gpiochip::get_direction() callback
> during interrupt setup.

I think proposed solution just bypasses the problem, not actually fixes
it. Can you share kernel crash report?

Sidenote: Tested-by: tag doesn't have any value if you're also the author
of the patch. It's already implied that you tested your solution/improvements.

Best regards,
Jernej

> 
> Patch 1 declares R_PIO node as interrupt controller so it can be used as
> interrupt parrent.
> 
> Patch 2 fixes the board device tree by routing the interrupt to R_PIO
> 
> ---
> Michal Piekos (2):
>       arm64: dts: allwinner: h616: declare r_pio as interrupt controller
>       arm64: dts: allwinner: orangepi-zero3: fix axp313 interrupt parrent
> 
>  arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi               | 2 ++
>  arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> ---
> base-commit: 4ae12d8bd9a830799db335ee661d6cbc6597f838
> change-id: 20260308-rc2-boot-hang-269e8546635b
> 
> Best regards,
> 





  parent reply	other threads:[~2026-03-08  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08  5:16 [PATCH 0/2] arm64: dts: allwinner: fix Orange Pi Zero 3 PMIC interrupt routing Michal Piekos
2026-03-08  5:16 ` [PATCH 1/2] arm64: dts: allwinner: h616: declare r_pio as interrupt controller Michal Piekos
2026-03-08  5:16 ` [PATCH 2/2] arm64: dts: allwinner: orangepi-zero3: fix axp313 interrupt parrent Michal Piekos
2026-03-08  8:23 ` Jernej Škrabec [this message]
2026-03-08  9:29   ` [PATCH 0/2] arm64: dts: allwinner: fix Orange Pi Zero 3 PMIC interrupt routing Michal Piekos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3404622.44csPzL39Z@jernej-laptop \
    --to=jernej.skrabec@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=michal.piekos@mmpsystems.pl \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox