From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51237C64E7A for ; Tue, 1 Dec 2020 11:28:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F07FF20809 for ; Tue, 1 Dec 2020 11:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730516AbgLAL2A (ORCPT ); Tue, 1 Dec 2020 06:28:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbgLAL2A (ORCPT ); Tue, 1 Dec 2020 06:28:00 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0876BC0613CF for ; Tue, 1 Dec 2020 03:27:19 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kk3oM-0006sl-FO; Tue, 01 Dec 2020 12:27:10 +0100 Message-ID: <34146e8424bf9fdf5865fc954ee9964612ab88dc.camel@pengutronix.de> Subject: Re: [PATCH 3/6] arm64: dts: imx8mq: Add interconnect for lcdif From: Lucas Stach To: Martin Kepplinger , robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com, catalin.marinas@arm.com, will@kernel.org, georgi.djakov@linaro.org, cdleonard@gmail.com Cc: devicetree@vger.kernel.org, kernel@puri.sm, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Date: Tue, 01 Dec 2020 12:27:08 +0100 In-Reply-To: <20201201100124.4676-4-martin.kepplinger@puri.sm> References: <20201201100124.4676-1-martin.kepplinger@puri.sm> <20201201100124.4676-4-martin.kepplinger@puri.sm> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, den 01.12.2020, 11:01 +0100 schrieb Martin Kepplinger: > Add interconnect ports for lcdif to set bus capabilities. > > Signed-off-by: Martin Kepplinger > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 244e28e54b35..7384a69ed36c 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -11,6 +11,7 @@ >  #include "dt-bindings/input/input.h" >  #include >  #include > +#include >  #include "imx8mq-pinfunc.h" >   > > > >  / { > @@ -522,6 +523,8 @@ >   <&clk IMX8MQ_VIDEO_PLL1>, >   <&clk IMX8MQ_VIDEO_PLL1_OUT>; >   assigned-clock-rates = <0>, <0>, <0>, <594000000>; > + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; > + interconnect-names = "lcdif-dram"; This needs to be documented in the binding. Also I would argue that you can drop the lcdif prefix in the name, as it's part of the lcdif DT node. Regards, Lucas >   status = "disabled"; >   > > > >   port@0 {