From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ChiYuan Huang <u0084500@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Sebastian Reichel" <sre@kernel.org>, 游子馨 <alina_yu@richtek.com>,
cy_huang <cy_huang@richtek.com>,
alinayu829@gmail.com, "Linux PM" <linux-pm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: Add Richtek RT9471 battery charger
Date: Tue, 16 Aug 2022 10:27:14 +0300 [thread overview]
Message-ID: <343268e1-0c11-ae5f-c99a-62617e23f396@linaro.org> (raw)
In-Reply-To: <CADiBU3-bKGhW2Yy13svNUykqW+WN3VS6LftWMU0rMeCc+fMySg@mail.gmail.com>
On 13/08/2022 17:52, ChiYuan Huang wrote:
>>> Some gauge HW needs this information to enhance the battery capacity accuracy.
>>
>> Other supply stack pieces do it via supplies (supplied to/from in
>> include/linux/power_supply.h) and reporting power_supply_changed().
>>
>> With such explanation, your device is an interrupt source, but it is not
>> an interrupt controller. If your device is interrupt controller, it
>> means someone routes the interrupt line to your device. Physical line.
>>
> Yap, sure. And so on, just use the SW power supply chain to do this
> kind of event notification.
> To remove it, it doesn't affect the internal interrupt request inside
> the driver.
> Just cannot be used for the outer driver to request the events directly.
>
> If so, I think 'interrupt-controller' and even '#interrupt-cells' need
> to be removed.
> OK?
Yes, both should be removed. Your device is not an interrupt controller...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-16 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 13:41 [PATCH 0/2] Add Richtek RT9471 3A battery charger support cy_huang
2022-08-11 13:41 ` [PATCH 1/2] dt-bindings: power: supply: Add Richtek RT9471 battery charger cy_huang
2022-08-11 14:12 ` Krzysztof Kozlowski
2022-08-12 1:32 ` ChiYuan Huang
2022-08-12 6:54 ` Krzysztof Kozlowski
2022-08-12 15:57 ` ChiYuan Huang
2022-08-12 16:05 ` ChiYuan Huang
2022-08-12 18:53 ` Krzysztof Kozlowski
2022-08-13 14:52 ` ChiYuan Huang
2022-08-16 7:27 ` Krzysztof Kozlowski [this message]
2022-08-12 15:13 ` Rob Herring
2022-08-12 16:07 ` ChiYuan Huang
2022-08-11 13:41 ` [PATCH 2/2] power: supply: rt9471: Add Richtek RT9471 charger driver cy_huang
2022-08-15 5:53 ` Matti Vaittinen
2022-08-15 6:10 ` ChiYuan Huang
2022-08-15 7:24 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=343268e1-0c11-ae5f-c99a-62617e23f396@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alina_yu@richtek.com \
--cc=alinayu829@gmail.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).