From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7BCC32772 for ; Tue, 16 Aug 2022 09:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbiHPJLK (ORCPT ); Tue, 16 Aug 2022 05:11:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233505AbiHPJKc (ORCPT ); Tue, 16 Aug 2022 05:10:32 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7212EDAEC3 for ; Tue, 16 Aug 2022 00:27:18 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id j3so9838485ljo.0 for ; Tue, 16 Aug 2022 00:27:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=jgkKAq27nalp4xFLW3mk73yjlH+iPel54g7OBjDZ1oI=; b=Mq7r6vRNCChXlYPF+zT+4Ept2VrTSrrP38C87uSqO8mXR/YVOX0bc2McxNSYlkkJTO e+yH0rOVHqI0INUR/tSCYNXQU+p5/vwbT6u6aPRBaxQ6rMZpSy5k/VWsBL9Xp6vvIR8X 0PA3lUFcXPoMfb260xJiszNnXlRH9NvLF1m2hpHFs9gT4V8lV0SsJpmw9BR4vZ1gHH1j c9kr3Vsajkbe22PtuANvdRgPeaUZ8sSt9fVW+ovyMLUS7440oFkcHs1atjIug+i2nGDx WK6smRGXOaT1y5GxG6ZvcY5C348l7BHW39G0lV6+iqdC754xonpL8n7jbkfhynuZP2bv sBig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=jgkKAq27nalp4xFLW3mk73yjlH+iPel54g7OBjDZ1oI=; b=ylLzn1Hizn152L37/9kWsFhDV4q7mmO0d7tT6BV/ycpMoFRGKpEUeQIgMLt5RU+l90 2ANhiGpAfFSnZ94N6sVNRP5gHVEnHOXWwngYzzB8s8PIW4sIzwMf207OvZcvdlCxB702 nN0NF5YrXHJTMk2z86t1g3Qn8Znu7WllWdAK3WDS+7mR0AP8XrAHfIi43EFQPML3NNR/ Hd+9Qo2DHtxweWRgTnUAXDRN9+kxLzfGFLexjbMxMRxb0JmOu/V+c7hDKiMFFIQ0DGLu eN9ThLjqclYIvcXGGZw2yRccDY19xCLc9TbpbtVKVJXRwGlJRMs/Fo17o6RbHsflga9l YmTg== X-Gm-Message-State: ACgBeo3jkOq1e2MFgsswfEx5/UxwHs4xEk6kyi05kZKJk/3XWc6y7MJW ITjTbECvK7eHnN0gV64UxEgdWA== X-Google-Smtp-Source: AA6agR4jEHWzEqPmD1v9ED+1vw84vjsvdHwzpp1nZoCUPf9WX8jWoeSl8sl+A2IWC5wW16bz/hCrFg== X-Received: by 2002:a2e:a311:0:b0:25f:d95a:9c66 with SMTP id l17-20020a2ea311000000b0025fd95a9c66mr6273478lje.208.1660634836806; Tue, 16 Aug 2022 00:27:16 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id q22-20020a056512211600b00491dda41e4bsm794337lfr.172.2022.08.16.00.27.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 00:27:16 -0700 (PDT) Message-ID: <343268e1-0c11-ae5f-c99a-62617e23f396@linaro.org> Date: Tue, 16 Aug 2022 10:27:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] dt-bindings: power: supply: Add Richtek RT9471 battery charger Content-Language: en-US To: ChiYuan Huang Cc: Rob Herring , Krzysztof Kozlowski , Sebastian Reichel , =?UTF-8?B?5ri45a2Q6aao?= , cy_huang , alinayu829@gmail.com, Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkml References: <1660225318-4063-1-git-send-email-u0084500@gmail.com> <1660225318-4063-2-git-send-email-u0084500@gmail.com> <3cae9d60-4012-1dfd-abd9-4d0b9379e6bb@linaro.org> <40261b95-637a-1304-2e06-8c8ff7fc377b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/08/2022 17:52, ChiYuan Huang wrote: >>> Some gauge HW needs this information to enhance the battery capacity accuracy. >> >> Other supply stack pieces do it via supplies (supplied to/from in >> include/linux/power_supply.h) and reporting power_supply_changed(). >> >> With such explanation, your device is an interrupt source, but it is not >> an interrupt controller. If your device is interrupt controller, it >> means someone routes the interrupt line to your device. Physical line. >> > Yap, sure. And so on, just use the SW power supply chain to do this > kind of event notification. > To remove it, it doesn't affect the internal interrupt request inside > the driver. > Just cannot be used for the outer driver to request the events directly. > > If so, I think 'interrupt-controller' and even '#interrupt-cells' need > to be removed. > OK? Yes, both should be removed. Your device is not an interrupt controller... Best regards, Krzysztof