From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Enrico Butera <ebutera@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Eduard Gavin <egavinc@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 07/10] [media] tvp5150: Add device tree binding document
Date: Wed, 06 Jan 2016 13:00:31 +0200 [thread overview]
Message-ID: <3433197.yOemOv0bmo@avalon> (raw)
In-Reply-To: <568CF08B.6080107@osg.samsung.com>
On Wednesday 06 January 2016 07:46:35 Javier Martinez Canillas wrote:
> On 01/06/2016 07:39 AM, Laurent Pinchart wrote:
> > Hi Javier,
> >
> > Thank you for the patch.
>
> Thanks a lot for your feedback.
>
> [snip]
>
> >> +
> >> +Optional Properties:
> >> +- powerdown-gpios: phandle for the GPIO connected to the PDN pin, if
> >> any.
> >
> > The signal is called PDN in the datasheet, so it might make sense to call
> > this pdn-gpios. I have no strong opinion on this, I'll let you decide
> > what you think is best.
>
> Yes, I wondered if the convention was to use a descriptive name or the one
> used in the datasheet but Documentation/devicetree/bindings/gpio/gpio.txt
> says nothing about it.
The device tree maintainers might want to comment on that :-)
> I'll change it to pdn-gpios since it could be easier to match with the doc.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-01-06 11:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 12:25 [PATCH 00/10] [media] tvp5150: add MC and DT support Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 01/10] [media] tvp5150: Restructure version detection Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 02/10] [media] tvp5150: Add tvp5151 support Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 03/10] [media] tvp5150: Add pad-level subdev operations Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 04/10] [media] tvp5150: Add pixel rate control support Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 05/10] [media] tvp5150: Add s_stream subdev operation support Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 06/10] [media] tvp5150: Add g_mbus_config " Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 07/10] [media] tvp5150: Add device tree binding document Javier Martinez Canillas
[not found] ` <1451910332-23385-8-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-01-04 14:07 ` Rob Herring
2016-01-04 16:16 ` Javier Martinez Canillas
2016-01-06 10:39 ` Laurent Pinchart
2016-01-06 10:46 ` Javier Martinez Canillas
2016-01-06 11:00 ` Laurent Pinchart [this message]
2016-01-04 12:25 ` [PATCH 08/10] [media] tvp5150: Add OF match table Javier Martinez Canillas
2016-01-06 10:40 ` Laurent Pinchart
2016-01-04 12:25 ` [PATCH 09/10] [media] tvp5150: Initialize the chip on probe Javier Martinez Canillas
[not found] ` <1451910332-23385-10-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-01-04 12:40 ` kbuild test robot
[not found] ` <201601042006.Dk9Wav4W%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-04 12:53 ` Javier Martinez Canillas
2016-01-06 10:59 ` Laurent Pinchart
2016-01-06 11:39 ` Javier Martinez Canillas
2016-01-04 12:25 ` [PATCH 10/10] [media] tvp5150: Configure data interface via pdata or DT Javier Martinez Canillas
2016-01-06 10:56 ` Laurent Pinchart
2016-01-06 11:27 ` Javier Martinez Canillas
[not found] ` <568CFA1E.6060309-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-01-06 13:48 ` Laurent Pinchart
2016-01-06 15:04 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3433197.yOemOv0bmo@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=ebutera@gmail.com \
--cc=egavinc@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).