Re: [PATCH v2 2/2] arm64: dts: imx8mm-iot-gateway: Add initial support

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/05/2024 02:05, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Add the initial support for the CompuLab i.MX8MM IoT Gateway board,
> which is based on the Compulab's UCM-iMX8M-Mini SoM.
> 
> Board URL:
> https://www.compulab.com/products/iot-gateways/iot-gate-imx8-industrial-arm-iot-gateway/
> 

> +	regulator-usdhc2_v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "usdhc2_v";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio1 4 GPIO_ACTIVE_HIGH>;
> +		regulator-always-on;
> +		enable-active-high;
> +	};
> +
> +	regulator-mpcie2_rst {

No underscores in node names.

> +		compatible = "regulator-fixed";
> +		regulator-name = "mpcie2_rst";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
> +		regulator-always-on;
> +		enable-active-high;
> +	};
> +
> +	regulator-mpcie2lora_dis {
> +		compatible = "regulator-fixed";
> +		regulator-name = "mpcie2lora_dis";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		gpio = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> +		regulator-always-on;
> +		enable-active-high;
> +	};
> +
> +	pcie0_refclk: pcie0-refclk {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <100000000>;
> +	};
> +};
> +
> +&i2c1 {
> +	clock-frequency = <100000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c1>;
> +	status = "okay";
> +
> +	eeprom@54 {
> +		compatible = "atmel,24c08";
> +		reg = <0x54>;
> +		pagesize = <16>;
> +	};
> +};
> +
> +&ecspi1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
> +	cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};
> +
> +&pcie_phy {
> +	fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> +	fsl,tx-deemph-gen1 = <0x2d>;
> +	fsl,tx-deemph-gen2 = <0xf>;
> +	fsl,clkreq-unsupported;
> +	clocks = <&pcie0_refclk>;
> +	clock-names = "ref";
> +	status = "okay";
> +};
> +
> +&pcie0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pcie0>;
> +	reset-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};
> +
> +&usbotg1 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
> +&usbotg2 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	dr_mode = "host";
> +	usb-role-switch;
> +	status = "okay";
> +
> +	usbhub@1 {
> +		compatible = "usb424,9514";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_usb9514>;
> +		reg = <1>;

reg is always the second property.


...

> +
> +	backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm2 0 3000000 0>;
> +		brightness-levels = <0 255>;
> +		num-interpolated-steps = <255>;
> +		default-brightness-level = <222>;
> +		status = "okay";
> +	};
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_gpio_led>;
> +
> +		heartbeat-led {
> +			label = "Heartbeat";

Use function and color instead

> +			gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +


Best regards,
Krzysztof