From: "Heiko Stübner" <heiko@sntech.de>
To: Addy Ke <addy.ke@rock-chips.com>
Cc: broonie@kernel.org, dianders@chromium.org,
grant.likely@linaro.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
olof@lixom.net, hj@rock-chips.com, kever.yang@rock-chips.com,
xjq@rock-chips.com, huangtao@rock-chips.com, zyw@rock-chips.com,
yzq@rock-chips.com, zhenfu.fang@rock-chips.com,
cf@rock-chips.com, zhangqing@rock-chips.com, hl@rock-chips.com,
wei.luo@rock-chips.com
Subject: Re: [PATCH] spi/rockchip: fixup incorrect dma direction setting
Date: Wed, 20 Aug 2014 10:09:56 +0200 [thread overview]
Message-ID: <3440626.YssIeyfVzZ@phil> (raw)
In-Reply-To: <1408506462-3686-1-git-send-email-addy.ke@rock-chips.com>
Hi Addy,
please always remember to add a real commit message, something similar to:
"Fix typo that caused the tx direction to be set twice and left out the rx
direction."
for example.
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
> ---
> drivers/spi/spi-rockchip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index cb8fd6f..4ef3fd3 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -679,7 +679,7 @@ static int rockchip_spi_probe(struct platform_device
> *pdev) rs->dma_tx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_TXDR);
> rs->dma_rx.addr = (dma_addr_t)(mem->start + ROCKCHIP_SPI_RXDR);
> rs->dma_tx.direction = DMA_MEM_TO_DEV;
> - rs->dma_tx.direction = DMA_DEV_TO_MEM;
> + rs->dma_rx.direction = DMA_DEV_TO_MEM;
>
> master->can_dma = rockchip_spi_can_dma;
> master->dma_tx = rs->dma_tx.ch;
next prev parent reply other threads:[~2014-08-20 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 3:47 [PATCH] spi/rockchip: fixup incorrect dma direction setting Addy Ke
2014-08-20 8:09 ` Heiko Stübner [this message]
2014-08-20 15:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3440626.YssIeyfVzZ@phil \
--to=heiko@sntech.de \
--cc=addy.ke@rock-chips.com \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=grant.likely@linaro.org \
--cc=hj@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=wei.luo@rock-chips.com \
--cc=xjq@rock-chips.com \
--cc=yzq@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zhenfu.fang@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).