Re: [PATCH 5/8] Bluetooth: btrtl: add support for the RTL8723CS

kbuild test robot
2019-01-21T14:31:34Z

[-- Attachment #1: Type: text/plain, Size: 1909 bytes --]

Hi Vasily,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on v5.0-rc2 next-20190116]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Vasily-Khoruzhick/Add-support-for-rtl8723bs-rtl8723cs-bluetooth/20190121-190321
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: x86_64-randconfig-x016-201903 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All error/warnings (new ones prefixed by >>):

In file included from drivers/bluetooth/btusb.c:39:
drivers/bluetooth/btrtl.h: In function 'btrtl_get_uart_settings':
>> drivers/bluetooth/btrtl.h:111:20: error: invalid storage class for function 'btrtl_apply_quirks'
static inline void btrtl_apply_quirks(struct hci_dev *hdev,
^~~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btrtl.h:111:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
static inline void btrtl_apply_quirks(struct hci_dev *hdev,
^~~~~~

vim +/btrtl_apply_quirks +111 drivers/bluetooth/btrtl.h

102
103 static inline int btrtl_get_uart_settings(struct hci_dev *hdev,
104 struct btrtl_device_info *btrtl_dev,
105 unsigned int *controller_baudrate,
106 u32 *device_baudrate,
107 bool *flow_control)
108 {
109 return -ENOENT;
110
> 111 static inline void btrtl_apply_quirks(struct hci_dev *hdev,
112 struct btrtl_device_info *btrtl_dev)
113 {
114 }
115 }
116

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29859 bytes --]