From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v5 2/2] PCI: Rockchip: Add Rockchip PCIe controller support Date: Tue, 05 Jul 2016 10:15:33 +0200 Message-ID: <3471444.31RlTMvDfn@wuerfel> References: <1467686561-25638-1-git-send-email-shawn.lin@rock-chips.com> <1467686561-25638-2-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467686561-25638-2-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shawn Lin Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brian Norris , Heiko Stuebner , Marc Zyngier , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wenrui Li , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Bjorn Helgaas List-Id: devicetree@vger.kernel.org On Tuesday, July 5, 2016 10:42:41 AM CEST Shawn Lin wrote: > +config PCIE_ROCKCHIP > + tristate "Rockchip PCIe controller" > + depends on ARM64 && ARCH_ROCKCHIP > + depends on OF > + select MFD_SYSCON > + select PCI_MSI_IRQ_DOMAIN if PCI_MSI Please use "depends on PCI_MSI_IRQ_DOMAIN" now, instead of "select PCI_MSI_IRQ_DOMAIN if PCI_MSI", we have reworked how this is handled for consistency. Arnd