From: Stefan Agner <stefan@agner.ch>
To: Cory Tusar <cory.tusar@pid1solutions.com>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vf610: dt: Nomenclature fixup for PTC12 pin used in RMII mode.
Date: Mon, 18 May 2015 14:47:27 +0200 [thread overview]
Message-ID: <348facdd175a944356f046708b9a1e06@agner.ch> (raw)
In-Reply-To: <1431573098-23809-1-git-send-email-cory.tusar@pid1solutions.com>
On 2015-05-14 05:11, Cory Tusar wrote:
> This commit includes a minor nomenclature fixup for boards based on the
> Freescale VF610 SoC and which make use of the alternate "RMII1_RXD1"
> functionality for pin PTC12. This brings the macro name in-line with
> both the datasheet and other similar macros.
Thanks, stumbled upon this a while ago too, never came around creating a
patch.
Acked-by: Stefan Agner <stefan@agner.ch>
>
> Signed-off-by: Cory Tusar <cory.tusar@pid1solutions.com>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 2 +-
> arch/arm/boot/dts/vf610-cosmic.dts | 2 +-
> arch/arm/boot/dts/vf610-pinfunc.h | 2 +-
> arch/arm/boot/dts/vf610-twr.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi
> b/arch/arm/boot/dts/vf-colibri.dtsi
> index fbef082..68ca125 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -140,7 +140,7 @@
> VF610_PAD_PTC9__ENET_RMII1_MDC 0x30d2
> VF610_PAD_PTC10__ENET_RMII1_MDIO 0x30d3
> VF610_PAD_PTC11__ENET_RMII1_CRS 0x30d1
> - VF610_PAD_PTC12__ENET_RMII_RXD1 0x30d1
> + VF610_PAD_PTC12__ENET_RMII1_RXD1 0x30d1
> VF610_PAD_PTC13__ENET_RMII1_RXD0 0x30d1
> VF610_PAD_PTC14__ENET_RMII1_RXER 0x30d1
> VF610_PAD_PTC15__ENET_RMII1_TXD1 0x30d2
> diff --git a/arch/arm/boot/dts/vf610-cosmic.dts
> b/arch/arm/boot/dts/vf610-cosmic.dts
> index fd8758b..5447f25 100644
> --- a/arch/arm/boot/dts/vf610-cosmic.dts
> +++ b/arch/arm/boot/dts/vf610-cosmic.dts
> @@ -68,7 +68,7 @@
> VF610_PAD_PTC9__ENET_RMII1_MDC 0x30d2
> VF610_PAD_PTC10__ENET_RMII1_MDIO 0x30d3
> VF610_PAD_PTC11__ENET_RMII1_CRS 0x30d1
> - VF610_PAD_PTC12__ENET_RMII_RXD1 0x30d1
> + VF610_PAD_PTC12__ENET_RMII1_RXD1 0x30d1
> VF610_PAD_PTC13__ENET_RMII1_RXD0 0x30d1
> VF610_PAD_PTC14__ENET_RMII1_RXER 0x30d1
> VF610_PAD_PTC15__ENET_RMII1_TXD1 0x30d2
> diff --git a/arch/arm/boot/dts/vf610-pinfunc.h
> b/arch/arm/boot/dts/vf610-pinfunc.h
> index 1ee681f..fcad713 100644
> --- a/arch/arm/boot/dts/vf610-pinfunc.h
> +++ b/arch/arm/boot/dts/vf610-pinfunc.h
> @@ -369,7 +369,7 @@
> #define VF610_PAD_PTC11__MLB_DATA 0x0E0 0x358 ALT6 0x1
> #define VF610_PAD_PTC11__DEBUG_OUT 0x0E0 0x000 ALT7 0x0
> #define VF610_PAD_PTC12__GPIO_57 0x0E4 0x000 ALT0 0x0
> -#define VF610_PAD_PTC12__ENET_RMII_RXD1 0x0E4 0x000 ALT1 0x0
> +#define VF610_PAD_PTC12__ENET_RMII1_RXD1 0x0E4 0x000 ALT1 0x0
> #define VF610_PAD_PTC12__ESAI_SDO1 0x0E4 0x318 ALT3 0x1
> #define VF610_PAD_PTC12__SAI2_TX_BCLK 0x0E4 0x370 ALT5 0x1
> #define VF610_PAD_PTC12__DEBUG_OUT3 0x0E4 0x000 ALT7 0x0
> diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts
> index f64fddc..375ab23 100644
> --- a/arch/arm/boot/dts/vf610-twr.dts
> +++ b/arch/arm/boot/dts/vf610-twr.dts
> @@ -221,7 +221,7 @@
> VF610_PAD_PTC9__ENET_RMII1_MDC 0x30d2
> VF610_PAD_PTC10__ENET_RMII1_MDIO 0x30d3
> VF610_PAD_PTC11__ENET_RMII1_CRS 0x30d1
> - VF610_PAD_PTC12__ENET_RMII_RXD1 0x30d1
> + VF610_PAD_PTC12__ENET_RMII1_RXD1 0x30d1
> VF610_PAD_PTC13__ENET_RMII1_RXD0 0x30d1
> VF610_PAD_PTC14__ENET_RMII1_RXER 0x30d1
> VF610_PAD_PTC15__ENET_RMII1_TXD1 0x30d2
next prev parent reply other threads:[~2015-05-18 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 3:11 [PATCH] vf610: dt: Nomenclature fixup for PTC12 pin used in RMII mode Cory Tusar
2015-05-18 12:47 ` Stefan Agner [this message]
[not found] ` <1431573098-23809-1-git-send-email-cory.tusar-J6Z/VSE8EyIAspv4Qr0y0gC/G2K4zDHf@public.gmane.org>
2015-05-19 4:54 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348facdd175a944356f046708b9a1e06@agner.ch \
--to=stefan@agner.ch \
--cc=cory.tusar@pid1solutions.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).