From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DECC04A94 for ; Fri, 21 Jul 2023 10:43:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbjGUKn1 (ORCPT ); Fri, 21 Jul 2023 06:43:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231738AbjGUKnO (ORCPT ); Fri, 21 Jul 2023 06:43:14 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E420B171B for ; Fri, 21 Jul 2023 03:43:12 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3110ab7110aso1506144f8f.3 for ; Fri, 21 Jul 2023 03:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689936191; x=1690540991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=10U4fK1s3xSb0xE9SC0kNza6kl90rPnqzrVj/rW25sA=; b=ylegs2eQ1FV4JkZAMkdbyfVbgKsFznHRW3MP7u/ObABBMG1slmHz5LpzO78kVwHd9L wz2d1lIYpN082F74Q8YPFHg2fx9ArEKmSDGtp21GAr2QxymgetMUc+9yJT9Ejf0rPoJD Tr5YtbxYjEFoTqqhVwn9+SgorgrUlxAeeNx1PsT0eSDKNMi0mWj0B+NA6qEryk4DYep+ Z/WKDzY+KRipQ3tpZ4g2X+3jTxW4CD2TiiOIpW3fekolkSg6vU6RYuZaUxjy5sfAOBKF 3CGMZsChEQ971aHhLt1woOScZsSuXsyl9iVZhbNsxdEa4PmqgCXBMyti4midHNQty3uB ++VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689936191; x=1690540991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=10U4fK1s3xSb0xE9SC0kNza6kl90rPnqzrVj/rW25sA=; b=OD2VzUpY5SoWaxixY2vdl77hOVoC1POZbTtwltIHFh4eh6Oz2rdzHZ6bPqRtDFsV15 /SPk5CemQWnjqclQjtY8woJorE10zmpHpvLmti+xTv68oo++oL9dmbhNdipN9C/EaOor 0QUu7rna4aVBViwiXC11Y7OThH8VoLfa4xCIG5CQ0RL7JUSM45TGKs7o4JXqO/bMYc/r 6VBYksKYyh96MfJrXpSfZp3WcgRrTfeiC7aLcbUArsIzCiGmOOd62FOsrjq3buuioPSC EINwC70v2PGyYzbJOknp/W3RYeR2/xPELyv7ohWE5aGJW4K5NaBair/l/UhJd+Bksk3W rDlw== X-Gm-Message-State: ABy/qLYb+89DzL6Nnuatft2iMJ/BHWPFB7RqJ3r+/FScxhnKiv5+fVdc FTsSU7ftoMBsHmoC6XeQTCvoGA== X-Google-Smtp-Source: APBJJlHtzj78AEfrCX5x9slxz9FuK7svnQZ70Nm2fRzgMaNUv6jWNt3kQ7ifiimBxePqGKVOpod34g== X-Received: by 2002:a5d:6086:0:b0:314:39d0:26f6 with SMTP id w6-20020a5d6086000000b0031439d026f6mr1289165wrt.18.1689936191292; Fri, 21 Jul 2023 03:43:11 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id x13-20020a5d60cd000000b0030ada01ca78sm3843492wrt.10.2023.07.21.03.43.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 03:43:10 -0700 (PDT) Message-ID: <3492152a-d668-54ba-7cb4-4db8bfec6f03@linaro.org> Date: Fri, 21 Jul 2023 12:43:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 2/3] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM support Content-Language: en-US To: James Hilliard , devicetree@vger.kernel.org Cc: Gregory CLEMENT , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marek Vasut , Frieder Schrempf , Stefan Wahren , Philippe Schenker , Andreas Kemnade , Marcel Ziswiler , Christoph Niedermaier , Li Yang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230721103350.3684483-1-james.hilliard1@gmail.com> <20230721103350.3684483-2-james.hilliard1@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230721103350.3684483-2-james.hilliard1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/07/2023 12:33, James Hilliard wrote: > This patch adds support for the Variscite VAR_SOM-MX6 SoM with : > - i.MX6 Quad or Dual Lite SoC > - 256 – 4096 MB DDR3 > - 4-64 GB eMMC > - 128 – 1024 MB SLC NAND > - Camera Interface > - HDMI+CEC interface > - LVDS / DSI / Parallel RGB interfaces > - Ethernet RGMII interface > - On-SoM Wi-Fi/Bluetooth with WiLink wl183x SDIO Module > - SD/MMC/SDIO interface > - USB Host + USB OTG interface > - I2C interfaces > - SPI interfaces > - PCI-Express 2.0 interface > - on-SoM Audio Codec with HP/Line-In interfaces + DMIC interface > - Digital Audio interface > - S/PDIF interface > > Product website : https://www.variscite.com/product/system-on-module-som/cortex-a9/var-som-mx6-cpu-freescale-imx6/ > > Support is handled with a SoM-centric dtsi exporting the default interfaces > along the default pinmuxing to be enabled by the board dts file. > > This file is based on the one provided by Variscite on their own > kernel, but adapted for mainline. > > Signed-off-by: Gregory CLEMENT > Signed-off-by: James Hilliard > --- > .../arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi | 544 ++++++++++++++++++ > 1 file changed, 544 insertions(+) > create mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi > new file mode 100644 > index 000000000000..a7d2aecd83fe > --- /dev/null > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-var-som.dtsi > @@ -0,0 +1,544 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Support for Variscite VAR-SOM-MX6 Module > + * > + * Copyright 2011 Linaro Ltd. > + * Copyright 2012 Freescale Semiconductor, Inc. > + * Copyright (C) 2014-2016 Variscite, Ltd. > + * Author: Donio Ron > + * Copyright 2022 Bootlin > + */ > + > +/dts-v1/; > + > +#include "imx6q.dtsi" > +#include > +#include > +#include > + > +/ { > + model = "Variscite VAR-SOM-MX6 module"; > + compatible = "variscite,var-som-imx6q", "fsl,imx6q"; > + > + chosen { > + stdout-path = &uart1; > + }; > + > + memory@10000000 { > + device_type = "memory"; > + reg = <0x10000000 0x40000000>; > + }; > + > + reg_3p3v: regulator-3p3v { > + compatible = "regulator-fixed"; > + regulator-name = "3P3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + reg_3v3_touch: reg-3v3-touch { The prefix is still different than all others. You used "regulator" in other places, but here it is "reg". Keep your code consistent. > + compatible = "regulator-fixed"; > + regulator-name = "touch_3v3_supply"; > + regulator-always-on; Also, missing constraints. Best regards, Krzysztof