From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81BBC433F5 for ; Thu, 10 Feb 2022 01:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233778AbiBJB7m (ORCPT ); Wed, 9 Feb 2022 20:59:42 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:60266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233780AbiBJB7F (ORCPT ); Wed, 9 Feb 2022 20:59:05 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A48D62BB1F for ; Wed, 9 Feb 2022 17:51:55 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id h6so6908530wrb.9 for ; Wed, 09 Feb 2022 17:51:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KuWfWfuWnqE3Lf1pLThOJ9cbGV0fB5/az1fd713TDVM=; b=eORsgRc5opCCy82zZDyt/YscGu57swjkPfQHflgTUMgjhFWIaTU9Avbx8cRoq0Ja+0 pPdE0URc2/SwKMYrfmpYNRCJlHk9mHA9K6htJlKYQkVrIVjWCL41AaKObtFjGuIbBb6m hafyl4vx9aXs9g6fxXOF8xxNLh56Nr+2udy3B6Uy8hagxNMDojP5oKiFOECZJ/S5n4l3 3AaeEKJbs8rAmJNha6Mj8uASFVLRJNnl0Y4A8t7V4I80A9SG/2jG5uoDSwDc+ldo8UoO Cd+Q+oxKWOFppQQz+jeUO69JYP6ixXpx/38c+iUWuwM6JoabkalmscwpEj4hQ3LIZYuw DZsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KuWfWfuWnqE3Lf1pLThOJ9cbGV0fB5/az1fd713TDVM=; b=o/30XjY3WL6pPXtw9JYXRLPYvHCFCFB2t4kKoBv+GBJoo1PbH+rl/5UGye/6JW0Rkj /dEC2cv5N/YJC9vtp4q5HjoQo07IUzmQuGzeNKY8FJes1MDE0BkXWyDXtx9RBhUPsV4c x8/QAI52eDDYLKjRK+peb7BqNLxI6sWftGfjH9XCHSpSropeIp3K30+ZssvvtSaj+4VS 2/CCb3KEW/aex/PNLX17zYF0O7XNranJq2euQPCwG9FX5Fi61hFPn5WH+Fzr6UatlyOk uDgnEH9vQG2ROYLWxMH/OepJ0E/qmPCuYy5DX8KqW9tg4hTdsS6uU3cCIWTIUgnhPt4B uQfA== X-Gm-Message-State: AOAM531ovXi8H3eRCHS6ufrZ5SynbEN2TBJHhSCGrsUXeE5q+RlCSktv Q1vLJ88brqVUbVMpgKOBh0M14TNRVBBtFg== X-Google-Smtp-Source: ABdhPJz5HdwaLCZg0YGvrdms4wZCJ7d2vvjkkE7V8xjEya3YrI6hanWQq3TZeFNN4LgM/36xxIBSKQ== X-Received: by 2002:a17:906:4781:: with SMTP id cw1mr4273977ejc.264.1644451833902; Wed, 09 Feb 2022 16:10:33 -0800 (PST) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id i6sm8992267edf.20.2022.02.09.16.10.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Feb 2022 16:10:33 -0800 (PST) Message-ID: <3492afbf-b9fc-d5f5-6f7a-2157442d8209@gmail.com> Date: Thu, 10 Feb 2022 01:10:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Content-Language: en-US To: Sascha Hauer , dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20220209095350.2104049-1-s.hauer@pengutronix.de> <20220209095350.2104049-20-s.hauer@pengutronix.de> From: Johan Jonker In-Reply-To: <20220209095350.2104049-20-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sascha, Something with port and endpoint gives notifications. Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC options were checked/covered (see rk3328 and rk3568). Allow multiple vop: port or port@0 1x vop -> endpoint 2x vop -> endpoint@0 -> endpoint@1 Also allow for connector: (not all existing DT have this yet) port@1 -> endpoint See also at graph.yaml === dtc -I dtb -O dts rk3568-evb1-v10.dtb : Warning (avoid_unnecessary_addr_size): /hdmi@fe0a0000/ports/port@1: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property : Warning (graph_child_address): /hdmi@fe0a0000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary : Warning (graph_child_address): /hdmi@fe0a0000/ports/port@1: graph node has single child node 'endpoint', #address-cells/#size-cells are not necessary === ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml DTC arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dt.yaml CHECK arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dt.yaml /arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dt.yaml: hdmi@fe0a0000: ports: 'port' is a required property From schema: /home/user/Downloads/linux-next-20220202/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml DTC arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml CHECK arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml /arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml: hdmi@fe0a0000: ports: 'port' is a required property From schema: /home/user/Downloads/linux-next-20220202/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml === On 2/9/22 10:53, Sascha Hauer wrote: > This enabled the VOP2 display controller along with hdmi and the > required port routes which is enough to get a picture out of the > hdmi port of the board. > > Signed-off-by: Sascha Hauer > --- > > Notes: > Changes since v4: > - Sort nodes alphabetically > > Changes since v3: > - Fix HDMI connector type > > .../boot/dts/rockchip/rk3568-evb1-v10.dts | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > index 184e2aa2416a..18f0f5abddcf 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts > @@ -7,6 +7,7 @@ > /dts-v1/; > #include > #include > +#include > #include "rk3568.dtsi" > > / { > @@ -33,6 +34,17 @@ dc_12v: dc-12v { > regulator-max-microvolt = <12000000>; > }; > > + hdmi-con { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&hdmi_out_con>; > + }; > + }; > + }; > + > vcc3v3_sys: vcc3v3-sys { > compatible = "regulator-fixed"; > regulator-name = "vcc3v3_sys"; > @@ -106,6 +118,25 @@ &gmac1m1_rgmii_clk > status = "okay"; > }; > > +&hdmi { > + avdd-0v9-supply = <&vdda0v9_image>; > + avdd-1v8-supply = <&vcca1v8_image>; > + status = "okay"; > +}; > + > +&hdmi_in { > + hdmi_in_vp0: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vp0_out_hdmi>; > + }; > +}; > + > +&hdmi_out { > + hdmi_out_con: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > +}; > + > &i2c0 { > status = "okay"; > > @@ -390,3 +421,20 @@ &sdmmc0 { > &uart2 { > status = "okay"; > }; > + > +&vop { > + assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>; > + assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>; > + status = "okay"; > +}; > + > +&vop_mmu { > + status = "okay"; > +}; > + > +&vp0 { > + vp0_out_hdmi: endpoint@RK3568_VOP2_EP_HDMI { > + reg = ; > + remote-endpoint = <&hdmi_in_vp0>; > + }; > +};