From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
gabriel.fernandez@st.com, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
patrice.chotard@st.com, Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
alexandre.torgue@st.com
Subject: Re: [PATCH v2 3/4] drivers: reset: Add STM32 reset driver
Date: Thu, 21 Jul 2016 21:55:01 +0200 [thread overview]
Message-ID: <34955897.5sjo821nJx@wuerfel> (raw)
In-Reply-To: <CAP=VYLq+Yp=dyMLY5zp8evNJ+jLkUgJ_s19gD1uC6KP8MmXPDQ@mail.gmail.com>
On Thursday, July 21, 2016 3:48:09 PM CEST Paul Gortmaker wrote:
> > diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> > index 5d65a93..64ebb0c 100644
> > --- a/drivers/reset/Makefile
> > +++ b/drivers/reset/Makefile
> > @@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
> > obj-$(CONFIG_ARCH_BERLIN) += reset-berlin.o
> > obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
> > obj-$(CONFIG_ARCH_MESON) += reset-meson.o
> > +obj-$(CONFIG_ARCH_STM32) += reset-stm32.o
>
> In my tree, this Kconfig ARCH_STM32 is a bool, so...
>
> > obj-$(CONFIG_ARCH_SUNXI) += reset-sunxi.o
> > obj-$(CONFIG_ARCH_STI) += sti/
> > obj-$(CONFIG_ARCH_HISI) += hisilicon/
> > diff --git a/drivers/reset/reset-stm32.c b/drivers/reset/reset-stm32.c
> > new file mode 100644
> > index 0000000..993af2a
> > --- /dev/null
> > +++ b/drivers/reset/reset-stm32.c
> > @@ -0,0 +1,113 @@
> > +/*
> > + * Copyright (C) Maxime Coquelin 2015
> > + * Author: Maxime Coquelin <mcoquelin.stm32@gmail.com>_
> > + * License terms: GNU General Public License (GPL), version 2
> > + *
> > + * Heavily based on sunxi driver from Maxime Ripard.
> > + */
> > +
> > +#include <linux/err.h>
> > +#include <linux/io.h>
> > +#include <linux/module.h>
>
> ...we probably don't need module.h here or any of the other
> MODULE_<blah> tags/macros either. Use the builtin for the
> register and all should be good.
I wonder if we should have separate symbols for each reset driver
instead. Those could be allowed to be tristate, and could also
be enabled for compile testing on other architectures.
I actually made a patch for that a while ago, to simplify the
dependencies around reset drivers.
Arnd
next prev parent reply other threads:[~2016-07-21 19:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 9:19 [PATCH v2 0/4] Add STM32 Reset Driver gabriel.fernandez-qxv4g6HH51o
2016-07-21 9:19 ` [PATCH v2 1/4] dt-bindings: mfd: Add STM32F4 RCC numeric constants into DT include file gabriel.fernandez
2016-07-21 9:19 ` [PATCH v2 2/4] dt-bindings: Document the STM32 reset bindings gabriel.fernandez
2016-07-21 22:06 ` Rob Herring
2016-07-21 9:19 ` [PATCH v2 3/4] drivers: reset: Add STM32 reset driver gabriel.fernandez
[not found] ` <1469092768-17489-4-git-send-email-gabriel.fernandez-qxv4g6HH51o@public.gmane.org>
2016-07-21 19:48 ` Paul Gortmaker
2016-07-21 19:55 ` Arnd Bergmann [this message]
2016-07-21 23:16 ` Paul Gortmaker
2016-07-22 19:25 ` Arnd Bergmann
2016-07-22 21:02 ` Paul Gortmaker
2016-07-28 14:29 ` Philipp Zabel
2016-07-22 9:24 ` Gabriel Fernandez
2016-07-21 9:19 ` [PATCH v2 4/4] ARM: dts: stm32f429: add missing #reset-cells of rcc gabriel.fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34955897.5sjo821nJx@wuerfel \
--to=arnd@arndb.de \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=patrice.chotard@st.com \
--cc=paul.gortmaker@windriver.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox