* [PATCH v2 0/3] arm64: dts: Add support for Kent SoC family
@ 2025-11-13 12:30 Yu-Chun Lin
2025-11-13 12:30 ` [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin
` (2 more replies)
0 siblings, 3 replies; 17+ messages in thread
From: Yu-Chun Lin @ 2025-11-13 12:30 UTC (permalink / raw)
To: afaerber, robh, krzk+dt, conor+dt, lee, james.tai
Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel,
cy.huang, stanley_chang, eleanor.lin
Hello,
This patch series adds initial Device Tree support for Realtek's Kent SoC
family, including the RTD1501S, RTD1861B, and RTD1920S variants with their
respective evaluation boards.
The series includes:
1. Adds compatible strings for the Kent family.
2. Add new DT bindings for the Realtek ISO system controller.
3. Add Device Tree files for the Kent SoC, TD1501S Phantom EVB (8GB),
RTD1861B Krypton EVB (8GB), and RTD1920S Smallville EVB (4GB).
The patches have been validated with 'make dtbs_check' and
'dt_binding_check' to ensure compliance with DT schema and successful
compilation.
Cheers,
Yu-Chun
Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
---
Changes in v2:
[PATCH v2 1/3]
- Fix YAML syntax: remove duplicate blank lines
- Validated with 'make dt_binding_check'
[PATCH v2 2/3]
- Rename: realtek,iso-system.yaml -> realtek,misc.yaml
- Improve description and example: show child node (UART)
[PATCH v2 3/3]
- Reorder Makefile targets to alphabetical order.
- Rename node: use generic names ('arch_timer' -> 'timer', 'reg-bus' -> 'bus')
- Fix node naming and hex format (remove leading zeros)
- Inline overlay nodes directly into .dtsi
- Reorder properties: ranges after reg
- Remove unnecessary status and custom bootargs
V1: https://lore.kernel.org/lkml/20251105104452.6336-1-eleanor.lin@realtek.com/
Yu-Chun Lin (3):
dt-bindings: arm: realtek: Add Kent Soc family compatibles
dt-bindings: mfd: Add Realtek MISC system controller
arm64: dts: realtek: Add Kent SoC and EVB device trees
.../devicetree/bindings/arm/realtek.yaml | 42 +++--
.../devicetree/bindings/mfd/realtek,misc.yaml | 72 ++++++++
arch/arm64/boot/dts/realtek/Makefile | 7 +-
arch/arm64/boot/dts/realtek/kent.dtsi | 174 ++++++++++++++++++
arch/arm64/boot/dts/realtek/rtd1501.dtsi | 13 ++
.../boot/dts/realtek/rtd1501s-phantom-8gb.dts | 25 +++
.../boot/dts/realtek/rtd1501s-phantom.dtsi | 119 ++++++++++++
arch/arm64/boot/dts/realtek/rtd1861.dtsi | 13 ++
.../boot/dts/realtek/rtd1861b-krypton-8gb.dts | 25 +++
.../boot/dts/realtek/rtd1861b-krypton.dtsi | 73 ++++++++
arch/arm64/boot/dts/realtek/rtd1920.dtsi | 13 ++
.../dts/realtek/rtd1920s-smallville-4gb.dts | 23 +++
.../boot/dts/realtek/rtd1920s-smallville.dtsi | 129 +++++++++++++
13 files changed, 712 insertions(+), 16 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/realtek,misc.yaml
create mode 100644 arch/arm64/boot/dts/realtek/kent.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd1501.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts
create mode 100644 arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd1861.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd1861b-krypton-8gb.dts
create mode 100644 arch/arm64/boot/dts/realtek/rtd1861b-krypton.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd1920.dtsi
create mode 100644 arch/arm64/boot/dts/realtek/rtd1920s-smallville-4gb.dts
create mode 100644 arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles 2025-11-13 12:30 [PATCH v2 0/3] arm64: dts: Add support for Kent SoC family Yu-Chun Lin @ 2025-11-13 12:30 ` Yu-Chun Lin 2025-11-13 19:28 ` Conor Dooley 2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin 2025-11-13 12:30 ` [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin 2 siblings, 1 reply; 17+ messages in thread From: Yu-Chun Lin @ 2025-11-13 12:30 UTC (permalink / raw) To: afaerber, robh, krzk+dt, conor+dt, lee, james.tai Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang, eleanor.lin Define compatible strings for Realtek RTD1501s, RTD1861b and RTD1920s. Additionally, convert legacy DTS-style comments to YAML description properties, following the pattern from the ARM bindings conversion series [1]. [1] https://lore.kernel.org/lkml/20200622125527.24207-2-afaerber@suse.de/ Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> --- .../devicetree/bindings/arm/realtek.yaml | 42 +++++++++++++------ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml index ddd9a85099e9..be529490640c 100644 --- a/Documentation/devicetree/bindings/arm/realtek.yaml +++ b/Documentation/devicetree/bindings/arm/realtek.yaml @@ -14,21 +14,21 @@ properties: const: '/' compatible: oneOf: - # RTD1195 SoC based boards - - items: + - description: RTD1195 SoC based boards + items: - enum: - mele,x1000 # MeLE X1000 - realtek,horseradish # Realtek Horseradish EVB - const: realtek,rtd1195 - # RTD1293 SoC based boards - - items: + - description: RTD1293 SoC based boards + items: - enum: - synology,ds418j # Synology DiskStation DS418j - const: realtek,rtd1293 - # RTD1295 SoC based boards - - items: + - description: RTD1295 SoC based boards + items: - enum: - mele,v9 # MeLE V9 - probox2,ava # ProBox2 AVA @@ -36,25 +36,43 @@ properties: - zidoo,x9s # Zidoo X9S - const: realtek,rtd1295 - # RTD1296 SoC based boards - - items: + - description: RTD1296 SoC based boards + items: - enum: - synology,ds418 # Synology DiskStation DS418 - const: realtek,rtd1296 - # RTD1395 SoC based boards - - items: + - description: RTD1395 SoC based boards + items: - enum: - bananapi,bpi-m4 # Banana Pi BPI-M4 - realtek,lion-skin # Realtek Lion Skin EVB - const: realtek,rtd1395 - # RTD1619 SoC based boards - - items: + - description: RTD1501s SoC based boards + items: + - enum: + - realtek,phantom # Realtek Phantom EVB (8GB) + - const: realtek,rtd1501s + + - description: RTD1619 SoC based boards + items: - enum: - realtek,mjolnir # Realtek Mjolnir EVB - const: realtek,rtd1619 + - description: RTD1861b SoC based boards + items: + - enum: + - realtek,krypton # Realtek Krypton EVB (8GB) + - const: realtek,rtd1861b + + - description: RTD1920s SoC based boards + items: + - enum: + - realtek,smallville # Realtek Smallville EVB (4GB) + - const: realtek,rtd1920s + additionalProperties: true ... -- 2.34.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles 2025-11-13 12:30 ` [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin @ 2025-11-13 19:28 ` Conor Dooley 2025-11-17 10:55 ` Yu-Chun Lin 0 siblings, 1 reply; 17+ messages in thread From: Conor Dooley @ 2025-11-13 19:28 UTC (permalink / raw) To: Yu-Chun Lin Cc: afaerber, robh, krzk+dt, conor+dt, lee, james.tai, linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang [-- Attachment #1: Type: text/plain, Size: 3498 bytes --] On Thu, Nov 13, 2025 at 08:30:07PM +0800, Yu-Chun Lin wrote: > Define compatible strings for Realtek RTD1501s, RTD1861b and RTD1920s. > > Additionally, convert legacy DTS-style comments to YAML description > properties, following the pattern from the ARM bindings conversion series > [1]. "Additionally" is often a sign that it should be in a different patch. Acked-by: Conor Dooley <conor.dooley@microchip.com> pw-bot: not-applicable > > [1] https://lore.kernel.org/lkml/20200622125527.24207-2-afaerber@suse.de/ > > Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> > --- > .../devicetree/bindings/arm/realtek.yaml | 42 +++++++++++++------ > 1 file changed, 30 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml > index ddd9a85099e9..be529490640c 100644 > --- a/Documentation/devicetree/bindings/arm/realtek.yaml > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml > @@ -14,21 +14,21 @@ properties: > const: '/' > compatible: > oneOf: > - # RTD1195 SoC based boards > - - items: > + - description: RTD1195 SoC based boards > + items: > - enum: > - mele,x1000 # MeLE X1000 > - realtek,horseradish # Realtek Horseradish EVB > - const: realtek,rtd1195 > > - # RTD1293 SoC based boards > - - items: > + - description: RTD1293 SoC based boards > + items: > - enum: > - synology,ds418j # Synology DiskStation DS418j > - const: realtek,rtd1293 > > - # RTD1295 SoC based boards > - - items: > + - description: RTD1295 SoC based boards > + items: > - enum: > - mele,v9 # MeLE V9 > - probox2,ava # ProBox2 AVA > @@ -36,25 +36,43 @@ properties: > - zidoo,x9s # Zidoo X9S > - const: realtek,rtd1295 > > - # RTD1296 SoC based boards > - - items: > + - description: RTD1296 SoC based boards > + items: > - enum: > - synology,ds418 # Synology DiskStation DS418 > - const: realtek,rtd1296 > > - # RTD1395 SoC based boards > - - items: > + - description: RTD1395 SoC based boards > + items: > - enum: > - bananapi,bpi-m4 # Banana Pi BPI-M4 > - realtek,lion-skin # Realtek Lion Skin EVB > - const: realtek,rtd1395 > > - # RTD1619 SoC based boards > - - items: > + - description: RTD1501s SoC based boards > + items: > + - enum: > + - realtek,phantom # Realtek Phantom EVB (8GB) > + - const: realtek,rtd1501s > + > + - description: RTD1619 SoC based boards > + items: > - enum: > - realtek,mjolnir # Realtek Mjolnir EVB > - const: realtek,rtd1619 > > + - description: RTD1861b SoC based boards > + items: > + - enum: > + - realtek,krypton # Realtek Krypton EVB (8GB) > + - const: realtek,rtd1861b > + > + - description: RTD1920s SoC based boards > + items: > + - enum: > + - realtek,smallville # Realtek Smallville EVB (4GB) > + - const: realtek,rtd1920s > + > additionalProperties: true > > ... > -- > 2.34.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles 2025-11-13 19:28 ` Conor Dooley @ 2025-11-17 10:55 ` Yu-Chun Lin 2025-11-17 14:36 ` Conor Dooley 0 siblings, 1 reply; 17+ messages in thread From: Yu-Chun Lin @ 2025-11-17 10:55 UTC (permalink / raw) To: conor Cc: afaerber, conor+dt, cy.huang, devicetree, eleanor.lin, james.tai, krzk+dt, lee, linux-arm-kernel, linux-kernel, linux-realtek-soc, robh, stanley_chang On Thu, Nov 13, 2025 at 08:30:07PM +0800, Yu-Chun Lin wrote: > > Define compatible strings for Realtek RTD1501s, RTD1861b and RTD1920s. > > > > Additionally, convert legacy DTS-style comments to YAML description > > properties, following the pattern from the ARM bindings conversion > > series [1]. > > "Additionally" is often a sign that it should be in a different patch. > Acked-by: Conor Dooley <conor.dooley@microchip.com> > pw-bot: not-applicable Hi Conor, I'm planning to split the changes into two separate patches: 1. One patch to convert realtek.yaml to match the DTS-style comments, following the pattern from the ARM bindings conversion series. 2. Another patch to define the compatible strings for Realtek RTD1501s, RTD1861b, and RTD1920s. Could you confirm if both patches should include your Acked-by tag, or is it only applicable to one of them? Best regards Yu-Chun > > > > [1] > > https://lore.kernel.org/lkml/20200622125527.24207-2-afaerber@suse.de/ > > > > Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> > > --- > > .../devicetree/bindings/arm/realtek.yaml | 42 +++++++++++++------ > > 1 file changed, 30 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml > > b/Documentation/devicetree/bindings/arm/realtek.yaml > > index ddd9a85099e9..be529490640c 100644 > > --- a/Documentation/devicetree/bindings/arm/realtek.yaml > > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml > > @@ -14,21 +14,21 @@ properties: > > const: '/' > > compatible: > > oneOf: > > - # RTD1195 SoC based boards > > - - items: > > + - description: RTD1195 SoC based boards > > + items: > > - enum: > > - mele,x1000 # MeLE X1000 > > - realtek,horseradish # Realtek Horseradish EVB > > - const: realtek,rtd1195 > > > > - # RTD1293 SoC based boards > > - - items: > > + - description: RTD1293 SoC based boards > > + items: > > - enum: > > - synology,ds418j # Synology DiskStation DS418j > > - const: realtek,rtd1293 > > > > - # RTD1295 SoC based boards > > - - items: > > + - description: RTD1295 SoC based boards > > + items: > > - enum: > > - mele,v9 # MeLE V9 > > - probox2,ava # ProBox2 AVA @@ -36,25 +36,43 @@ > > properties: > > - zidoo,x9s # Zidoo X9S > > - const: realtek,rtd1295 > > > > - # RTD1296 SoC based boards > > - - items: > > + - description: RTD1296 SoC based boards > > + items: > > - enum: > > - synology,ds418 # Synology DiskStation DS418 > > - const: realtek,rtd1296 > > > > - # RTD1395 SoC based boards > > - - items: > > + - description: RTD1395 SoC based boards > > + items: > > - enum: > > - bananapi,bpi-m4 # Banana Pi BPI-M4 > > - realtek,lion-skin # Realtek Lion Skin EVB > > - const: realtek,rtd1395 > > > > - # RTD1619 SoC based boards > > - - items: > > + - description: RTD1501s SoC based boards > > + items: > > + - enum: > > + - realtek,phantom # Realtek Phantom EVB (8GB) > > + - const: realtek,rtd1501s > > + > > + - description: RTD1619 SoC based boards > > + items: > > - enum: > > - realtek,mjolnir # Realtek Mjolnir EVB > > - const: realtek,rtd1619 > > > > + - description: RTD1861b SoC based boards > > + items: > > + - enum: > > + - realtek,krypton # Realtek Krypton EVB (8GB) > > + - const: realtek,rtd1861b > > + > > + - description: RTD1920s SoC based boards > > + items: > > + - enum: > > + - realtek,smallville # Realtek Smallville EVB (4GB) > > + - const: realtek,rtd1920s > > + > > additionalProperties: true > > > > ... > > -- > > 2.34.1 > > ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles 2025-11-17 10:55 ` Yu-Chun Lin @ 2025-11-17 14:36 ` Conor Dooley 0 siblings, 0 replies; 17+ messages in thread From: Conor Dooley @ 2025-11-17 14:36 UTC (permalink / raw) To: Yu-Chun Lin Cc: afaerber, conor+dt, cy.huang, devicetree, james.tai, krzk+dt, lee, linux-arm-kernel, linux-kernel, linux-realtek-soc, robh, stanley_chang [-- Attachment #1: Type: text/plain, Size: 1155 bytes --] On Mon, Nov 17, 2025 at 06:55:42PM +0800, Yu-Chun Lin wrote: > On Thu, Nov 13, 2025 at 08:30:07PM +0800, Yu-Chun Lin wrote: > > > Define compatible strings for Realtek RTD1501s, RTD1861b and RTD1920s. > > > > > > Additionally, convert legacy DTS-style comments to YAML description > > > properties, following the pattern from the ARM bindings conversion > > > series [1]. > > > > "Additionally" is often a sign that it should be in a different patch. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > pw-bot: not-applicable > > Hi Conor, > > I'm planning to split the changes into two separate patches: > > 1. One patch to convert realtek.yaml to match the DTS-style comments, > following the pattern from the ARM bindings conversion series. > 2. Another patch to define the compatible strings for Realtek RTD1501s, > RTD1861b, and RTD1920s. > > Could you confirm if both patches should include your Acked-by tag, or is > it only applicable to one of them? I acked it to go together, because I didn't think it was worth a resubmission for that alone. You can keep the ack I think, I'll take a look regardless. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-13 12:30 [PATCH v2 0/3] arm64: dts: Add support for Kent SoC family Yu-Chun Lin 2025-11-13 12:30 ` [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin @ 2025-11-13 12:30 ` Yu-Chun Lin 2025-11-13 19:31 ` Conor Dooley ` (2 more replies) 2025-11-13 12:30 ` [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin 2 siblings, 3 replies; 17+ messages in thread From: Yu-Chun Lin @ 2025-11-13 12:30 UTC (permalink / raw) To: afaerber, robh, krzk+dt, conor+dt, lee, james.tai Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang, eleanor.lin Add DT binding schema for Realtek system controller. Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> --- .../devicetree/bindings/mfd/realtek,misc.yaml | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/realtek,misc.yaml diff --git a/Documentation/devicetree/bindings/mfd/realtek,misc.yaml b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml new file mode 100644 index 000000000000..4f4a9ae250be --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml @@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/realtek,misc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek MISC System Controller + +description: + The Realtek MISC System Controller is a register area that contains + miscellaneous system registers for the SoC and serves as a parent node + for other functions. + +maintainers: + - James Tai <james.tai@realtek.com> + - Yu-Chun Lin <eleanor.lin@realtek.com> + +properties: + compatible: + items: + - enum: + - realtek,misc + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + ranges: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 1 + +patternProperties: + "^serial@[0-9a-f]+$": + type: object + description: UART controllers inside MISC area + +required: + - compatible + - reg + - ranges + - '#address-cells' + - '#size-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + syscon@7000 { + compatible = "realtek,misc", "syscon", "simple-mfd"; + reg = <0x7000 0x1000>; + ranges = <0x0 0x7000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + + uart0: serial@800 { + compatible = "snps,dw-apb-uart"; + reg = <0x800 0x100>; + clock-frequency = <432000000>; + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; + reg-io-width = <4>; + reg-shift = <2>; + status = "disabled"; + }; + }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin @ 2025-11-13 19:31 ` Conor Dooley 2025-11-13 19:36 ` Krzysztof Kozlowski 2025-11-17 11:03 ` Yu-Chun Lin [林祐君] 2 siblings, 0 replies; 17+ messages in thread From: Conor Dooley @ 2025-11-13 19:31 UTC (permalink / raw) To: Yu-Chun Lin Cc: afaerber, robh, krzk+dt, conor+dt, lee, james.tai, linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang [-- Attachment #1: Type: text/plain, Size: 2834 bytes --] On Thu, Nov 13, 2025 at 08:30:08PM +0800, Yu-Chun Lin wrote: > Add DT binding schema for Realtek system controller. > > Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> > --- > .../devicetree/bindings/mfd/realtek,misc.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/realtek,misc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/realtek,misc.yaml b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > new file mode 100644 > index 000000000000..4f4a9ae250be > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/realtek,misc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek MISC System Controller > + > +description: > + The Realtek MISC System Controller is a register area that contains > + miscellaneous system registers for the SoC and serves as a parent node > + for other functions. > + > +maintainers: > + - James Tai <james.tai@realtek.com> > + - Yu-Chun Lin <eleanor.lin@realtek.com> > + > +properties: > + compatible: > + items: > + - enum: > + - realtek,misc You need a soc-specific compatible. It's hard to believe that every realtek device will have the exact same miscellaneous register region ;) > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + ranges: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > +patternProperties: > + "^serial@[0-9a-f]+$": > + type: object > + description: UART controllers inside MISC area How many of these actually are there? If they're always dw uarts, please add a reference to that schema. pw-bot: changes-requested > + > +required: > + - compatible > + - reg > + - ranges > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + syscon@7000 { > + compatible = "realtek,misc", "syscon", "simple-mfd"; > + reg = <0x7000 0x1000>; > + ranges = <0x0 0x7000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + uart0: serial@800 { > + compatible = "snps,dw-apb-uart"; > + reg = <0x800 0x100>; > + clock-frequency = <432000000>; > + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; > + reg-io-width = <4>; > + reg-shift = <2>; > + status = "disabled"; > + }; > + }; > -- > 2.34.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin 2025-11-13 19:31 ` Conor Dooley @ 2025-11-13 19:36 ` Krzysztof Kozlowski 2025-11-17 11:03 ` Yu-Chun Lin [林祐君] 2 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2025-11-13 19:36 UTC (permalink / raw) To: Yu-Chun Lin, afaerber, robh, krzk+dt, conor+dt, lee, james.tai Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang On 13/11/2025 13:30, Yu-Chun Lin wrote: > Add DT binding schema for Realtek system controller. What is Realtek system controller? I already asked. I have Realtek WiFi RT8192, so it is the same, right? > > Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> > --- > .../devicetree/bindings/mfd/realtek,misc.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/realtek,misc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/realtek,misc.yaml b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > new file mode 100644 > index 000000000000..4f4a9ae250be > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/realtek,misc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek MISC System Controller > + > +description: > + The Realtek MISC System Controller is a register area that contains > + miscellaneous system registers for the SoC and serves as a parent node > + for other functions. > + > +maintainers: > + - James Tai <james.tai@realtek.com> > + - Yu-Chun Lin <eleanor.lin@realtek.com> > + > +properties: > + compatible: > + items: > + - enum: > + - realtek,misc Nothing improved, still no soc part. You received comment on that - you need soc specific compatibles. Explain properly what is the hardware. You have entire commit msg for that. Did you read writing bindings doc? > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + ranges: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > +patternProperties: > + "^serial@[0-9a-f]+$": > + type: object > + description: UART controllers inside MISC area Please read what is a syscon. Then please bring justification why you claim that SNPS block is part of miscellaneous registers, because it highly unlikely. Reach to your hardware engineers to explain that. > + > +required: > + - compatible > + - reg > + - ranges > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + syscon@7000 { > + compatible = "realtek,misc", "syscon", "simple-mfd"; > + reg = <0x7000 0x1000>; > + ranges = <0x0 0x7000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + uart0: serial@800 { > + compatible = "snps,dw-apb-uart"; > + reg = <0x800 0x100>; > + clock-frequency = <432000000>; > + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; > + reg-io-width = <4>; > + reg-shift = <2>; > + status = "disabled"; Your code is not improving, but going opposite direction. There is no such code in the bindings, drop. > + }; > + }; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin 2025-11-13 19:31 ` Conor Dooley 2025-11-13 19:36 ` Krzysztof Kozlowski @ 2025-11-17 11:03 ` Yu-Chun Lin [林祐君] 2025-11-17 11:10 ` Krzysztof Kozlowski 2 siblings, 1 reply; 17+ messages in thread From: Yu-Chun Lin [林祐君] @ 2025-11-17 11:03 UTC (permalink / raw) To: Yu-Chun Lin [林祐君], afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, James Tai [戴志峰] Cc: linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, CY_Huang[黃鉦晏], Stanley Chang[昌育德] Hi Conor and Krzysztof, > Documentation/devicetree/bindings/mfd/realtek,misc.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > new file mode 100644 > index 000000000000..4f4a9ae250be > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/realtek,misc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek MISC System Controller > + > +description: > + The Realtek MISC System Controller is a register area that contains > + miscellaneous system registers for the SoC and serves as a parent > +node > + for other functions. > + > +maintainers: > + - James Tai <james.tai@realtek.com> > + - Yu-Chun Lin <eleanor.lin@realtek.com> > + > +properties: > + compatible: > + items: > + - enum: > + - realtek,misc I apologize for the current compatible string, which was initially named by referencing existing patterns like 'brcm,misc' and thus violates the naming guidance against "wildcards" and general non-SoC specific names. Let me explain the purpose of the device node (Realtek system controller). This MISC area contains several peripheral sub-modules such as uart, watchdog, rtc or i2c ..... These blocks share a unified register region implemented as a single hardware module, which remains powered during system suspend states (e.g., S3). These blocks share the same MMIO region and appear as child nodes under the MISC syscon node. Currently, it includes uart. Regarding the current structure, the device node is defined in a kent.dtsi and is included by each SoC's DTSI. I've considered two ways to write compatible string naming. Option 1: Use a single SoC-specific compatible string Rename "realtek,misc" to "realtek,rtd1861-misc" /* kent.dtsi */ misc: syscon@... { compatible = "realtek,rtd1861-misc", "syscon", "simple-mfd"; }; Pros: Only one compatible string is needed, simplifying maintenance across the driver and DTS. Cons: Violates the "SoC-specific compatible" rule for other SoCs (RTD1501, RTD1920). Option 2: SoC-specific + fallback (Compliant but Verbose) Define the full list in the schema, and override the compatible string in each SoC DTSI. /* schema binding */ compatible: items: - enum: - realtek,rtd1501-misc - realtek,rtd1861-misc - realtek,rtd1920-misc # ... add new SoCs here - const: realtek,kent-misc - const: syscon - const: simple-mfd /* kent.dtsi */ misc: syscon@... { compatible = "realtek,kent-misc", "syscon", "simple-mfd"; }; SoC-specific override (e.g. rtd1920s-smallville.dtsi): &misc { compatible = "realtek,rtd1920-misc", "realtek,kent-misc", "syscon", "simple-mfd"; }; Pros: Fully compliant with DT rules Cons: Requires override in every SoC file; slight duplication. Is Option 2 the expected pattern? Thanks for your guidance! Best regards, Yu-Chun > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + ranges: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > +patternProperties: > + "^serial@[0-9a-f]+$": > + type: object > + description: UART controllers inside MISC area > + > +required: > + - compatible > + - reg > + - ranges > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + syscon@7000 { > + compatible = "realtek,misc", "syscon", "simple-mfd"; > + reg = <0x7000 0x1000>; > + ranges = <0x0 0x7000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + uart0: serial@800 { > + compatible = "snps,dw-apb-uart"; > + reg = <0x800 0x100>; > + clock-frequency = <432000000>; > + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; > + reg-io-width = <4>; > + reg-shift = <2>; > + status = "disabled"; > + }; > + }; > -- > 2.34.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-17 11:03 ` Yu-Chun Lin [林祐君] @ 2025-11-17 11:10 ` Krzysztof Kozlowski 2025-11-17 12:41 ` Yu-Chun Lin [林祐君] 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2025-11-17 11:10 UTC (permalink / raw) To: Yu-Chun Lin [林祐君], afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, James Tai [戴志峰] Cc: linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, CY_Huang[黃鉦晏], Stanley Chang[昌育德] On 17/11/2025 12:03, Yu-Chun Lin [林祐君] wrote: > Hi Conor and Krzysztof, > >> Documentation/devicetree/bindings/mfd/realtek,misc.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/realtek,misc.yaml >> b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml >> new file mode 100644 >> index 000000000000..4f4a9ae250be >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml >> @@ -0,0 +1,72 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/realtek,misc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Realtek MISC System Controller >> + >> +description: >> + The Realtek MISC System Controller is a register area that contains >> + miscellaneous system registers for the SoC and serves as a parent >> +node >> + for other functions. >> + >> +maintainers: >> + - James Tai <james.tai@realtek.com> >> + - Yu-Chun Lin <eleanor.lin@realtek.com> >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - realtek,misc > > I apologize for the current compatible string, which was initially named > by referencing existing patterns like 'brcm,misc' and thus violates the > naming guidance against "wildcards" and general non-SoC specific names. > > Let me explain the purpose of the device node (Realtek system controller). > > This MISC area contains several peripheral sub-modules such as uart, > watchdog, rtc or i2c ..... These blocks share a unified register region > implemented as a single hardware module, which remains powered during > system suspend states (e.g., S3). These blocks share the same MMIO region > and appear as child nodes under the MISC syscon node. Currently, it No, you are mixing hardware with DT representation. This device cannot appear as child node, because there is no such concept in hardware as child node. You cannot use argument of DT representation when you justify how this is represented in DT. It is invalid. You need to start argumentation in terms of hardware. > includes uart. > > Regarding the current structure, the device node is defined in a kent.dtsi > and is included by each SoC's DTSI. > > I've considered two ways to write compatible string naming. > > Option 1: Use a single SoC-specific compatible string > > Rename "realtek,misc" to "realtek,rtd1861-misc" > > /* kent.dtsi */ > misc: syscon@... { > compatible = "realtek,rtd1861-misc", "syscon", "simple-mfd"; > }; > > Pros: Only one compatible string is needed, simplifying maintenance across > the driver and DTS. > > Cons: Violates the "SoC-specific compatible" rule for other SoCs > (RTD1501, RTD1920). > > Option 2: SoC-specific + fallback (Compliant but Verbose) > > Define the full list in the schema, and override the compatible string in each SoC DTSI. > > /* schema binding */ > > compatible: > items: > - enum: > - realtek,rtd1501-misc > - realtek,rtd1861-misc > - realtek,rtd1920-misc > # ... add new SoCs here > - const: realtek,kent-misc > - const: syscon > - const: simple-mfd > > > /* kent.dtsi */ > > misc: syscon@... { > compatible = "realtek,kent-misc", "syscon", "simple-mfd"; > }; > > SoC-specific override (e.g. rtd1920s-smallville.dtsi): > > &misc { > compatible = "realtek,rtd1920-misc", "realtek,kent-misc", "syscon", > "simple-mfd"; > }; > > Pros: Fully compliant with DT rules > > Cons: Requires override in every SoC file; slight duplication. > > Is Option 2 the expected pattern? > Thanks for your guidance! > None of them. You need SoC specific compatibles which can be used as fallbacks for SoC specific compatibles. There is plenty of examples for this already, but anyway this does not solve the problem that you still did not properly describe the hardware but instead use your downstream as arguments. This will get you nowhere. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-17 11:10 ` Krzysztof Kozlowski @ 2025-11-17 12:41 ` Yu-Chun Lin [林祐君] 2025-11-17 13:31 ` Krzysztof Kozlowski 0 siblings, 1 reply; 17+ messages in thread From: Yu-Chun Lin [林祐君] @ 2025-11-17 12:41 UTC (permalink / raw) To: Krzysztof Kozlowski, afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, James Tai [戴志峰] Cc: linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, CY_Huang[黃鉦晏], Stanley Chang[昌育德] > > On 17/11/2025 12:03, Yu-Chun Lin [林祐君] wrote: > > Hi Conor and Krzysztof, > > > >> Documentation/devicetree/bindings/mfd/realtek,misc.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > >> b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > >> new file mode 100644 > >> index 000000000000..4f4a9ae250be > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/realtek,misc.yaml > >> @@ -0,0 +1,72 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/mfd/realtek,misc.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Realtek MISC System Controller > >> + > >> +description: > >> + The Realtek MISC System Controller is a register area that > >> +contains > >> + miscellaneous system registers for the SoC and serves as a parent > >> +node > >> + for other functions. > >> + > >> +maintainers: > >> + - James Tai <james.tai@realtek.com> > >> + - Yu-Chun Lin <eleanor.lin@realtek.com> > >> + > >> +properties: > >> + compatible: > >> + items: > >> + - enum: > >> + - realtek,misc > > > > I apologize for the current compatible string, which was initially > > named by referencing existing patterns like 'brcm,misc' and thus > > violates the naming guidance against "wildcards" and general non-SoC > specific names. > > > > Let me explain the purpose of the device node (Realtek system controller). > > > > This MISC area contains several peripheral sub-modules such as uart, > > watchdog, rtc or i2c ..... These blocks share a unified register > > region implemented as a single hardware module, which remains powered > > during system suspend states (e.g., S3). These blocks share the same > > MMIO region and appear as child nodes under the MISC syscon node. > > Currently, it > > No, you are mixing hardware with DT representation. This device cannot > appear as child node, because there is no such concept in hardware as child > node. You cannot use argument of DT representation when you justify how this > is represented in DT. It is invalid. > > You need to start argumentation in terms of hardware. > You are right that there is no hardware parent-child relationship between the MISC controller and the UART block. The MISC registers at 0x98007000 are a system control (syscon) module, while the UART controller is a separate IP mapped at 0x98007800 on the same RBUS. In v3, I will moved the UART node to be a direct child of the RBUS bus node. > > > includes uart. > > > > Regarding the current structure, the device node is defined in a > > kent.dtsi and is included by each SoC's DTSI. > > > > I've considered two ways to write compatible string naming. > > > > Option 1: Use a single SoC-specific compatible string > > > > Rename "realtek,misc" to "realtek,rtd1861-misc" > > > > /* kent.dtsi */ > > misc: syscon@... { > > compatible = "realtek,rtd1861-misc", "syscon", "simple-mfd"; }; > > > > Pros: Only one compatible string is needed, simplifying maintenance > > across the driver and DTS. > > > > Cons: Violates the "SoC-specific compatible" rule for other SoCs > > (RTD1501, RTD1920). > > > > Option 2: SoC-specific + fallback (Compliant but Verbose) > > > > Define the full list in the schema, and override the compatible string in each > SoC DTSI. > > > > /* schema binding */ > > > > compatible: > > items: > > - enum: > > - realtek,rtd1501-misc > > - realtek,rtd1861-misc > > - realtek,rtd1920-misc > > # ... add new SoCs here > > - const: realtek,kent-misc > > - const: syscon > > - const: simple-mfd > > > > > > /* kent.dtsi */ > > > > misc: syscon@... { > > compatible = "realtek,kent-misc", "syscon", "simple-mfd"; }; > > > > SoC-specific override (e.g. rtd1920s-smallville.dtsi): > > > > &misc { > > compatible = "realtek,rtd1920-misc", "realtek,kent-misc", "syscon", > > "simple-mfd"; > > }; > > > > Pros: Fully compliant with DT rules > > > > Cons: Requires override in every SoC file; slight duplication. > > > > Is Option 2 the expected pattern? > > Thanks for your guidance! > > > > None of them. You need SoC specific compatibles which can be used as > fallbacks for SoC specific compatibles. There is plenty of examples for this > already, but anyway this does not solve the problem that you still did not > properly describe the hardware but instead use your downstream as > arguments. > > This will get you nowhere. To implement this fallback structure, my understanding is that the SoC-level DTSI should override the node and prepend its SoC-specific Compatible, while the common DTSI only provides the family-level compatible. /* common DTSI */ misc: syscon@... { compatible = "realtek,kent-misc", "syscon", "simple-mfd"; }; /* SoC-specific DTSI */ &misc { compatible = "realtek,rtd1920-misc", "realtek,kent-misc", "syscon", "simple-mfd"; }; Please let me know if this is the intended usage. > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-17 12:41 ` Yu-Chun Lin [林祐君] @ 2025-11-17 13:31 ` Krzysztof Kozlowski 2025-11-19 6:46 ` Yu-Chun Lin [林祐君] 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2025-11-17 13:31 UTC (permalink / raw) To: Yu-Chun Lin [林祐君], afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, James Tai [戴志峰] Cc: linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, CY_Huang[黃鉦晏], Stanley Chang[昌育德] On 17/11/2025 13:41, Yu-Chun Lin [林祐君] wrote: >>> >> >> None of them. You need SoC specific compatibles which can be used as >> fallbacks for SoC specific compatibles. There is plenty of examples for this >> already, but anyway this does not solve the problem that you still did not >> properly describe the hardware but instead use your downstream as >> arguments. >> >> This will get you nowhere. > > To implement this fallback structure, my understanding is that the > SoC-level DTSI should override the node and prepend its SoC-specific > Compatible, while the common DTSI only provides the family-level > compatible. > > /* common DTSI */ > misc: syscon@... { > compatible = "realtek,kent-misc", "syscon", "simple-mfd"; No. You changed nothing. How does this differ from options I disagreed with? Anyway, there is no such SoC as "kent" and I was clear - you need SoC compatibles. Define what is your SoC first. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller 2025-11-17 13:31 ` Krzysztof Kozlowski @ 2025-11-19 6:46 ` Yu-Chun Lin [林祐君] 0 siblings, 0 replies; 17+ messages in thread From: Yu-Chun Lin [林祐君] @ 2025-11-19 6:46 UTC (permalink / raw) To: Krzysztof Kozlowski, afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, James Tai [戴志峰] Cc: linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, CY_Huang[黃鉦晏], Stanley Chang[昌育德] > On 17/11/2025 13:41, Yu-Chun Lin [林祐君] wrote: > >>> > >> > >> None of them. You need SoC specific compatibles which can be used as > >> fallbacks for SoC specific compatibles. There is plenty of examples > >> for this already, but anyway this does not solve the problem that you > >> still did not properly describe the hardware but instead use your > >> downstream as arguments. > >> > >> This will get you nowhere. > > > > To implement this fallback structure, my understanding is that the > > SoC-level DTSI should override the node and prepend its SoC-specific > > Compatible, while the common DTSI only provides the family-level > > compatible. > > > > /* common DTSI */ > > misc: syscon@... { > > compatible = "realtek,kent-misc", "syscon", "simple-mfd"; > > No. You changed nothing. How does this differ from options I disagreed with? > > Anyway, there is no such SoC as "kent" and I was clear - you need SoC > compatibles. > > Define what is your SoC first. > > Best regards, > Krzysztof Hi Krzysztof, Thank you for your response. The original intention was to add a basic Kent device tree, but since the 'misc' node is currently empty. I will remove both this device node and its corresponding YAML binding in v3. After further consideration within our team, we have decided to add power-domain and reboot-mode functionalities to the 'misc' node in the future. And we will adhere to the SoC-specific compatible string binding pattern, following this structure: /* schema binding */ compatible: items: - enum: - realtek,rtd1501-misc - realtek,rtd1861-misc - realtek,rtd1920-misc - const: syscon - const: simple-mfd /* SoC-specific Device Tree Source (e.g. rtd1920s.dtsi) */ &rbus { misc: syscon@7000 { compatible = "realtek,rtd1920-misc", "syscon", "simple-mfd"; reg = <0x7000 0x1000>; ranges = <0x0 0x7000 0x1000>; #address-cells = <1>; #size-cells = <1>; }; }; Best regards, Yu-Chun ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees 2025-11-13 12:30 [PATCH v2 0/3] arm64: dts: Add support for Kent SoC family Yu-Chun Lin 2025-11-13 12:30 ` [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin 2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin @ 2025-11-13 12:30 ` Yu-Chun Lin 2025-11-13 19:39 ` Krzysztof Kozlowski 2025-11-13 19:50 ` Krzysztof Kozlowski 2 siblings, 2 replies; 17+ messages in thread From: Yu-Chun Lin @ 2025-11-13 12:30 UTC (permalink / raw) To: afaerber, robh, krzk+dt, conor+dt, lee, james.tai Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang, eleanor.lin Add Device Tree hierarchy for Realtek Kent SoC family: - kent.dtsi: base SoC layer - rtd<variant>.dtsi: SoC variant layer - rtd<variant>-<board>.dtsi: board layer - rtd<variant>-<board>-<config>.dts: board configuration layer Include RTD1501s Phantom EVB (8GB), RTD1861B Krypton EVB (8GB), and RTD1920s Smallville EVB (4GB). Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com> --- arch/arm64/boot/dts/realtek/Makefile | 7 +- arch/arm64/boot/dts/realtek/kent.dtsi | 174 ++++++++++++++++++ arch/arm64/boot/dts/realtek/rtd1501.dtsi | 13 ++ .../boot/dts/realtek/rtd1501s-phantom-8gb.dts | 25 +++ .../boot/dts/realtek/rtd1501s-phantom.dtsi | 119 ++++++++++++ arch/arm64/boot/dts/realtek/rtd1861.dtsi | 13 ++ .../boot/dts/realtek/rtd1861b-krypton-8gb.dts | 25 +++ .../boot/dts/realtek/rtd1861b-krypton.dtsi | 73 ++++++++ arch/arm64/boot/dts/realtek/rtd1920.dtsi | 13 ++ .../dts/realtek/rtd1920s-smallville-4gb.dts | 23 +++ .../boot/dts/realtek/rtd1920s-smallville.dtsi | 129 +++++++++++++ 11 files changed, 610 insertions(+), 4 deletions(-) create mode 100644 arch/arm64/boot/dts/realtek/kent.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd1501.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd1861.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd1861b-krypton-8gb.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1861b-krypton.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd1920.dtsi create mode 100644 arch/arm64/boot/dts/realtek/rtd1920s-smallville-4gb.dts create mode 100644 arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi diff --git a/arch/arm64/boot/dts/realtek/Makefile b/arch/arm64/boot/dts/realtek/Makefile index ef8d8fcbaa05..8a8e143182b9 100644 --- a/arch/arm64/boot/dts/realtek/Makefile +++ b/arch/arm64/boot/dts/realtek/Makefile @@ -1,15 +1,14 @@ # SPDX-License-Identifier: GPL-2.0-only dtb-$(CONFIG_ARCH_REALTEK) += rtd1293-ds418j.dtb - dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-mele-v9.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-probox2-ava.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-xnano-x5.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1295-zidoo-x9s.dtb - dtb-$(CONFIG_ARCH_REALTEK) += rtd1296-ds418.dtb - dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-bpi-m4.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1395-lionskin.dtb - +dtb-$(CONFIG_ARCH_REALTEK) += rtd1501s-phantom-8gb.dtb dtb-$(CONFIG_ARCH_REALTEK) += rtd1619-mjolnir.dtb +dtb-$(CONFIG_ARCH_REALTEK) += rtd1861b-krypton-8gb.dtb +dtb-$(CONFIG_ARCH_REALTEK) += rtd1920s-smallville-4gb.dtb + diff --git a/arch/arm64/boot/dts/realtek/kent.dtsi b/arch/arm64/boot/dts/realtek/kent.dtsi new file mode 100644 index 000000000000..8d1b082c6ec8 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/kent.dtsi @@ -0,0 +1,174 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek Kent SoC family + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +/ { + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + aliases { + serial0 = &uart0; + }; + + timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>, + <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; + }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu0: cpu@0 { + device_type = "cpu"; + compatible = "arm,cortex-a78"; + reg = <0x0>; + enable-method = "psci"; + next-level-cache = <&l2_0>; + dynamic-power-coefficient = <454>; + #cooling-cells = <2>; + + l2_0: l2-cache { + compatible = "cache"; + cache-level = <2>; + cache-line-size = <64>; + cache-sets = <256>; + cache-size = <0x40000>; + cache-unified; + next-level-cache = <&l3>; + }; + }; + + cpu1: cpu@100 { + device_type = "cpu"; + compatible = "arm,cortex-a78"; + reg = <0x100>; + enable-method = "psci"; + next-level-cache = <&l2_1>; + dynamic-power-coefficient = <454>; + #cooling-cells = <2>; + + l2_1: l2-cache { + compatible = "cache"; + cache-level = <2>; + cache-line-size = <64>; + cache-sets = <256>; + cache-size = <0x40000>; + cache-unified; + next-level-cache = <&l3>; + }; + }; + + cpu2: cpu@200 { + device_type = "cpu"; + compatible = "arm,cortex-a78"; + reg = <0x200>; + enable-method = "psci"; + next-level-cache = <&l2_2>; + dynamic-power-coefficient = <454>; + #cooling-cells = <2>; + + l2_2: l2-cache { + compatible = "cache"; + cache-level = <2>; + cache-line-size = <64>; + cache-sets = <256>; + cache-size = <0x40000>; + cache-unified; + next-level-cache = <&l3>; + }; + }; + + cpu3: cpu@300 { + device_type = "cpu"; + compatible = "arm,cortex-a78"; + reg = <0x300>; + enable-method = "psci"; + next-level-cache = <&l2_3>; + dynamic-power-coefficient = <454>; + #cooling-cells = <2>; + + l2_3: l2-cache { + compatible = "cache"; + cache-level = <2>; + cache-line-size = <64>; + cache-sets = <256>; + cache-size = <0x40000>; + cache-unified; + next-level-cache = <&l3>; + }; + }; + + l3: l3-cache { + compatible = "cache"; + cache-level = <3>; + cache-line-size = <64>; + cache-sets = <512>; + cache-size = <0x200000>; + cache-unified; + }; + }; + + psci: psci { + compatible = "arm,psci-1.0"; + method = "smc"; + }; + + soc@0 { + compatible = "simple-bus"; + ranges = <0x0 0x0 0x0 0x40000>, /* boot code */ + <0x98000000 0x0 0x98000000 0xef0000>, /* rbus */ + <0xa0000000 0x0 0xa0000000 0x10000000>, /* PCIE */ + <0xff000000 0x0 0xff000000 0x200000>; /* GIC */ + #address-cells = <1>; + #size-cells = <1>; + + rbus: bus@98000000 { + compatible = "simple-bus"; + ranges = <0x0 0x98000000 0xef0000>, + <0xa0000000 0xa0000000 0x10000000>; /* PCIE */ + #address-cells = <1>; + #size-cells = <1>; + + iso: syscon@7000 { + compatible = "realtek,misc", "syscon", "simple-mfd"; + reg = <0x7000 0x1000>; + ranges = <0x0 0x7000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + + uart0: serial@800 { + compatible = "snps,dw-apb-uart"; + reg = <0x800 0x100>; + clock-frequency = <432000000>; + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; + reg-io-width = <4>; + reg-shift = <2>; + status = "disabled"; + }; + }; + }; + + gic: interrupt-controller@ff100000 { + compatible = "arm,gic-v3"; + reg = <0xff100000 0x10000>, + <0xff140000 0x80000>; + interrupt-controller; + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; + #address-cells = <1>; + #interrupt-cells = <3>; + #size-cells = <1>; + }; + }; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1501.dtsi b/arch/arm64/boot/dts/realtek/rtd1501.dtsi new file mode 100644 index 000000000000..1df5d9843505 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1501.dtsi @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1501 SoC + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +#include "kent.dtsi" + +&uart0 { + status = "okay"; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts b/arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts new file mode 100644 index 000000000000..c708a713fc4d --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1501s-phantom-8gb.dts @@ -0,0 +1,25 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1501S Phantom EVB + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include "rtd1501s-phantom.dtsi" + +/ { + compatible = "realtek,phantom", "realtek,rtd1501s"; + model = "Realtek Phantom EVB Chromium (8GB)"; + + memory@40000 { + device_type = "memory"; + reg = <0x0 0x50000 0x0 0x7ffb0000>, + <0x0 0x8a100000 0x0 0xdef0000>, + <0x0 0x98700000 0x0 0x7900000>, + <0x0 0xa0600000 0x0 0x5ea00000>, + <0x1 0x0 0x0 0xa0000000>, + <0x1 0xa0600000 0x0 0x5fa00000>; + }; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi b/arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi new file mode 100644 index 000000000000..a3639bd6a75b --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1501s-phantom.dtsi @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1501S Phantom EVB + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include <dt-bindings/thermal/thermal.h> +#include "rtd1501.dtsi" + +/ { + chosen { + bootargs = "earlycon=uart8250,mmio32,0x98007800"; + stdout-path = "serial0:460800n8"; + }; + + reserved_memory: reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + linux,cma { + compatible = "shared-dma-pool"; + alignment = <0x0 0x400000>; + alloc-ranges = <0x0 0x0 0x0 0x20000000>; + size = <0x0 0x2000000>; + reusable; + linux,cma-default; + }; + }; + + cpu_opps: opp-table-cpu { + compatible = "operating-points-v2"; + opp-shared; + + opp800: opp-800000000 { + opp-hz = /bits/ 64 <800000000>; + opp-microvolt = <830000 830000 1100000>; + }; + + opp900: opp-900000000 { + opp-hz = /bits/ 64 <900000000>; + opp-microvolt = <850000 850000 1100000>; + }; + + opp1000: opp-1000000000 { + opp-hz = /bits/ 64 <1000000000>; + opp-microvolt = <870000 870000 1100000>; + }; + + opp1100: opp-1100000000 { + opp-hz = /bits/ 64 <1100000000>; + opp-microvolt = <890000 890000 1100000>; + }; + + opp1200: opp-1200000000 { + opp-hz = /bits/ 64 <1200000000>; + opp-microvolt = <910000 910000 1100000>; + }; + + opp1300: opp-1300000000 { + opp-hz = /bits/ 64 <1300000000>; + opp-microvolt = <930000 930000 1100000>; + }; + + opp1400: opp-1400000000 { + opp-hz = /bits/ 64 <1400000000>; + opp-microvolt = <950000 950000 1100000>; + }; + + opp1500: opp-1500000000 { + opp-hz = /bits/ 64 <1500000000>; + opp-microvolt = <970000 970000 1100000>; + }; + + opp1600: opp-1600000000 { + opp-hz = /bits/ 64 <1600000000>; + opp-microvolt = <990000 990000 1100000>; + opp-suspend; + }; + + opp1700: opp-1700000000 { + opp-hz = /bits/ 64 <1700000000>; + opp-microvolt = <1010000 1010000 1100000>; + }; + + opp1800: opp-1800000000 { + opp-hz = /bits/ 64 <1800000000>; + opp-microvolt = <1030000 1030000 1100000>; + }; + + opp1900: opp-1900000000 { + opp-hz = /bits/ 64 <1900000000>; + opp-microvolt = <1050000 1050000 1100000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu1 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu2 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu3 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1861.dtsi b/arch/arm64/boot/dts/realtek/rtd1861.dtsi new file mode 100644 index 000000000000..e9b1b85c7a63 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1861.dtsi @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1861 SoC + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +#include "kent.dtsi" + +&uart0 { + status = "okay"; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1861b-krypton-8gb.dts b/arch/arm64/boot/dts/realtek/rtd1861b-krypton-8gb.dts new file mode 100644 index 000000000000..38feec66d4e9 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1861b-krypton-8gb.dts @@ -0,0 +1,25 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1861B Krypton EVB + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include "rtd1861b-krypton.dtsi" + +/ { + compatible = "realtek,krypton", "realtek,rtd1861b"; + model = "Realtek Krypton EVB (8GB)"; + + memory@40000 { + device_type = "memory"; + reg = <0x0 0x50000 0x0 0x7ffb0000>, + <0x0 0x8a100000 0x0 0xdef0000>, + <0x0 0x98700000 0x0 0x7900000>, + <0x0 0xa0600000 0x0 0x5ea00000>, + <0x1 0x0 0x0 0xa0000000>, + <0x1 0xa0600000 0x0 0x5fa00000>; + }; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1861b-krypton.dtsi b/arch/arm64/boot/dts/realtek/rtd1861b-krypton.dtsi new file mode 100644 index 000000000000..3773284ce95b --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1861b-krypton.dtsi @@ -0,0 +1,73 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1861B Krypton EVB + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include "rtd1861.dtsi" + +/ { + chosen { + bootargs = "earlycon=uart8250,mmio32,0x98007800"; + stdout-path = "serial0:460800n8"; + }; + + reserved_memory: reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + linux,cma { + compatible = "shared-dma-pool"; + alignment = <0x0 0x400000>; + alloc-ranges = <0x0 0x0 0x0 0x20000000>; + size = <0x0 0x2000000>; + reusable; + linux,cma-default; + }; + }; + + cpu_opps: opp-table-cpu { + compatible = "operating-points-v2"; + opp-shared; + + opp1200: opp-1200000000 { + opp-hz = /bits/ 64 <1200000000>; + opp-microvolt = <900000>; + }; + + opp1600: opp-1600000000 { + opp-hz = /bits/ 64 <1600000000>; + opp-microvolt = <1000000>; + opp-suspend; + }; + + opp1800: opp-1800000000 { + opp-hz = /bits/ 64 <1800000000>; + opp-microvolt = <1050000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu1 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu2 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu3 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1920.dtsi b/arch/arm64/boot/dts/realtek/rtd1920.dtsi new file mode 100644 index 000000000000..ffefde9749a1 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1920.dtsi @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1920 SoC + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +#include "kent.dtsi" + +&uart0 { + status = "okay"; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1920s-smallville-4gb.dts b/arch/arm64/boot/dts/realtek/rtd1920s-smallville-4gb.dts new file mode 100644 index 000000000000..b6900b11f34d --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1920s-smallville-4gb.dts @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1920S Smallville EVB + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include "rtd1920s-smallville.dtsi" + +/ { + compatible = "realtek,smallville", "realtek,rtd1920s"; + model = "Realtek Smallville EVB (4GB)"; + + memory@40000 { + device_type = "memory"; + reg = <0x0 0x50000 0x0 0x7ffb0000>, + <0x0 0x8a100000 0x0 0xdef0000>, + <0x0 0x98700000 0x0 0x7900000>, + <0x0 0xa1000000 0x0 0x5e000000>; + }; +}; + diff --git a/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi b/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi new file mode 100644 index 000000000000..0989afcbde67 --- /dev/null +++ b/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi @@ -0,0 +1,129 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * Realtek RTD1920S Smallville EVB + * + * Copyright (c) 2024 Realtek Semiconductor Corp. + */ + +/dts-v1/; + +#include <dt-bindings/thermal/thermal.h> +#include "rtd1920.dtsi" + +/ { + chosen { + bootargs = "earlycon=uart8250,mmio32,0x98007800"; + stdout-path = "serial0:460800n8"; + }; + + reserved_memory: reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + protected_mem: protected-mem@50000 { + reg = <0x0 0x50000 0x0 0xbf0000>; + no-map; + }; + + metadata: metadata@c40000 { + reg = <0x0 0xc40000 0x0 0x3c4000>; + no-map; + }; + + linux,cma { + compatible = "shared-dma-pool"; + alignment = <0x0 0x400000>; + alloc-ranges = <0x0 0x0 0x0 0x20000000>; + size = <0x0 0x2000000>; + reusable; + linux,cma-default; + }; + }; + + cpu_opps: opp-table-cpu { + compatible = "operating-points-v2"; + opp-shared; + + opp800: opp-800000000 { + opp-hz = /bits/ 64 <800000000>; + opp-microvolt = <830000 830000 1100000>; + }; + + opp900: opp-900000000 { + opp-hz = /bits/ 64 <900000000>; + opp-microvolt = <850000 850000 1100000>; + }; + + opp1000: opp-1000000000 { + opp-hz = /bits/ 64 <1000000000>; + opp-microvolt = <870000 870000 1100000>; + }; + + opp1100: opp-1100000000 { + opp-hz = /bits/ 64 <1100000000>; + opp-microvolt = <890000 890000 1100000>; + }; + + opp1200: opp-1200000000 { + opp-hz = /bits/ 64 <1200000000>; + opp-microvolt = <910000 910000 1100000>; + }; + + opp1300: opp-1300000000 { + opp-hz = /bits/ 64 <1300000000>; + opp-microvolt = <930000 930000 1100000>; + }; + + opp1400: opp-1400000000 { + opp-hz = /bits/ 64 <1400000000>; + opp-microvolt = <950000 950000 1100000>; + }; + + opp1500: opp-1500000000 { + opp-hz = /bits/ 64 <1500000000>; + opp-microvolt = <970000 970000 1100000>; + }; + + opp1600: opp-1600000000 { + opp-hz = /bits/ 64 <1600000000>; + opp-microvolt = <990000 990000 1100000>; + opp-suspend; + }; + + opp1700: opp-1700000000 { + opp-hz = /bits/ 64 <1700000000>; + opp-microvolt = <1010000 1010000 1100000>; + }; + + opp1800: opp-1800000000 { + opp-hz = /bits/ 64 <1800000000>; + opp-microvolt = <1030000 1030000 1100000>; + }; + + opp1900: opp-1900000000 { + opp-hz = /bits/ 64 <1900000000>; + opp-microvolt = <1050000 1050000 1100000>; + }; + }; +}; + +&cpu0 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu1 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu2 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + +&cpu3 { + operating-points-v2 = <&cpu_opps>; + #cooling-cells = <2>; +}; + -- 2.34.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees 2025-11-13 12:30 ` [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin @ 2025-11-13 19:39 ` Krzysztof Kozlowski 2025-11-13 19:50 ` Krzysztof Kozlowski 1 sibling, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2025-11-13 19:39 UTC (permalink / raw) To: Yu-Chun Lin, afaerber, robh, krzk+dt, conor+dt, lee, james.tai Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang On 13/11/2025 13:30, Yu-Chun Lin wrote: > + > + soc@0 { > + compatible = "simple-bus"; > + ranges = <0x0 0x0 0x0 0x40000>, /* boot code */ > + <0x98000000 0x0 0x98000000 0xef0000>, /* rbus */ > + <0xa0000000 0x0 0xa0000000 0x10000000>, /* PCIE */ > + <0xff000000 0x0 0xff000000 0x200000>; /* GIC */ > + #address-cells = <1>; > + #size-cells = <1>; > + > + rbus: bus@98000000 { > + compatible = "simple-bus"; > + ranges = <0x0 0x98000000 0xef0000>, > + <0xa0000000 0xa0000000 0x10000000>; /* PCIE */ > + #address-cells = <1>; > + #size-cells = <1>; > + > + iso: syscon@7000 { > + compatible = "realtek,misc", "syscon", "simple-mfd"; No, you just said "misc" is not part of the soc, right? I asked last time and since you now send the same, so clearly you intentionally claim this is not part of a SoC... Please just read writing bindings first. > + reg = <0x7000 0x1000>; > + ranges = <0x0 0x7000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + uart0: serial@800 { > + compatible = "snps,dw-apb-uart"; > + reg = <0x800 0x100>; > + clock-frequency = <432000000>; > + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>; > + reg-io-width = <4>; > + reg-shift = <2>; > + status = "disabled"; > + }; > + }; > + }; > + Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees 2025-11-13 12:30 ` [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin 2025-11-13 19:39 ` Krzysztof Kozlowski @ 2025-11-13 19:50 ` Krzysztof Kozlowski 2025-11-17 12:43 ` Yu-Chun Lin [林祐君] 1 sibling, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2025-11-13 19:50 UTC (permalink / raw) To: Yu-Chun Lin, afaerber, robh, krzk+dt, conor+dt, lee, james.tai Cc: linux-arm-kernel, linux-realtek-soc, devicetree, linux-kernel, cy.huang, stanley_chang On 13/11/2025 13:30, Yu-Chun Lin wrote: > diff --git a/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi b/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi > new file mode 100644 > index 000000000000..0989afcbde67 > --- /dev/null > +++ b/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi > @@ -0,0 +1,129 @@ > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) Odd, why do you want GPLv3 or GPLv4? GPLv3 has quite strict requirements, so I hope you know what you are doing and your legal understand this. > +/* > + * Realtek RTD1920S Smallville EVB > + * > + * Copyright (c) 2024 Realtek Semiconductor Corp. > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/thermal/thermal.h> > +#include "rtd1920.dtsi" > + > +/ { > + chosen { > + bootargs = "earlycon=uart8250,mmio32,0x98007800"; Drop bootargs, I asked for this last time. That's debugging. > + stdout-path = "serial0:460800n8"; > + }; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees 2025-11-13 19:50 ` Krzysztof Kozlowski @ 2025-11-17 12:43 ` Yu-Chun Lin [林祐君] 0 siblings, 0 replies; 17+ messages in thread From: Yu-Chun Lin [林祐君] @ 2025-11-17 12:43 UTC (permalink / raw) To: Krzysztof Kozlowski, afaerber@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, James Tai [戴志峰] Cc: linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, CY_Huang[黃鉦晏], Stanley Chang[昌育德] > On 13/11/2025 13:30, Yu-Chun Lin wrote: >> diff --git a/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi b/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi >> new file mode 100644 >> index 000000000000..0989afcbde67 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/realtek/rtd1920s-smallville.dtsi >> @@ -0,0 +1,129 @@ >> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > > Odd, why do you want GPLv3 or GPLv4? GPLv3 has quite strict > requirements, so I hope you know what you are doing and your legal > understand this. Thank you for the kind reminder. I simply copied the header from an existing Realtek upstream dtsi file. I will change it to 'SPDX-License-Identifier: GPL-2.0' >> +/* >> + * Realtek RTD1920S Smallville EVB >> + * >> + * Copyright (c) 2024 Realtek Semiconductor Corp. >> + */ >> + >> +/dts-v1/; >> + >> +#include <dt-bindings/thermal/thermal.h> >> +#include "rtd1920.dtsi" >> + >> +/ { >> + chosen { >> + bootargs = "earlycon=uart8250,mmio32,0x98007800"; > > Drop bootargs, I asked for this last time. That's debugging. > Sorry. I will drop it. Set boot args in bootloader. >> + stdout-path = "serial0:460800n8"; >> + }; > > > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2025-11-19 6:49 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-11-13 12:30 [PATCH v2 0/3] arm64: dts: Add support for Kent SoC family Yu-Chun Lin 2025-11-13 12:30 ` [PATCH v2 1/3] dt-bindings: arm: realtek: Add Kent Soc family compatibles Yu-Chun Lin 2025-11-13 19:28 ` Conor Dooley 2025-11-17 10:55 ` Yu-Chun Lin 2025-11-17 14:36 ` Conor Dooley 2025-11-13 12:30 ` [PATCH v2 2/3] dt-bindings: mfd: Add Realtek MISC system controller Yu-Chun Lin 2025-11-13 19:31 ` Conor Dooley 2025-11-13 19:36 ` Krzysztof Kozlowski 2025-11-17 11:03 ` Yu-Chun Lin [林祐君] 2025-11-17 11:10 ` Krzysztof Kozlowski 2025-11-17 12:41 ` Yu-Chun Lin [林祐君] 2025-11-17 13:31 ` Krzysztof Kozlowski 2025-11-19 6:46 ` Yu-Chun Lin [林祐君] 2025-11-13 12:30 ` [PATCH v2 3/3] arm64: dts: realtek: Add Kent SoC and EVB device trees Yu-Chun Lin 2025-11-13 19:39 ` Krzysztof Kozlowski 2025-11-13 19:50 ` Krzysztof Kozlowski 2025-11-17 12:43 ` Yu-Chun Lin [林祐君]
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).