From: Krzysztof Kozlowski <krzk@kernel.org>
To: Julien Massot <julien.massot@collabora.com>,
devicetree@vger.kernel.org, linux-media@vger.kernel.org
Cc: kernel@collabora.com
Subject: Re: [PATCH v2 2/4] dt-bindings: media: add Maxim MAX96717F GMSL2 Serializer
Date: Fri, 8 Dec 2023 18:17:03 +0100 [thread overview]
Message-ID: <34b498ad-0b2c-464e-9805-b5907df665ea@kernel.org> (raw)
In-Reply-To: <20231208143359.469049-3-julien.massot@collabora.com>
On 08/12/2023 15:33, Julien Massot wrote:
> Add DT bindings for Maxim MAX96717F GMSL2 Serializer.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> .../bindings/media/i2c/maxim,max96717f.yaml | 144 ++++++++++++++++++
> 1 file changed, 144 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max96717f.yaml
>
...
> +
> + reg:
> + description: I2C device address
drop description
> + maxItems: 1
> +
...
> +
> + i2c-gate {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + vd5661@10 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-08 17:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 14:33 [PATCH v2 0/4] Add support for MAX96714F and MAX96717F GMSL2 ser/des Julien Massot
2023-12-08 14:33 ` [PATCH v2 1/4] dt-bindings: media: add Maxim MAX96714F GMSL2 Deserializer Julien Massot
2023-12-08 15:29 ` Rob Herring
2023-12-08 17:16 ` Krzysztof Kozlowski
2024-01-08 13:17 ` Julien Massot
2023-12-08 14:33 ` [PATCH v2 2/4] dt-bindings: media: add Maxim MAX96717F GMSL2 Serializer Julien Massot
2023-12-08 15:29 ` Rob Herring
2023-12-08 17:17 ` Krzysztof Kozlowski [this message]
2023-12-08 14:33 ` [PATCH v2 3/4] media: i2c: add MAX96714 driver Julien Massot
2023-12-08 17:18 ` Krzysztof Kozlowski
2024-01-08 13:20 ` Julien Massot
2024-01-08 18:58 ` Krzysztof Kozlowski
2023-12-09 15:54 ` kernel test robot
2023-12-10 2:13 ` kernel test robot
2023-12-08 14:33 ` [PATCH v2 4/4] media: i2c: add MAX96717 driver Julien Massot
2023-12-09 4:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34b498ad-0b2c-464e-9805-b5907df665ea@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=julien.massot@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).