From: Marek Vasut <marex@nabladev.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-usb@vger.kernel.org
Cc: fabrice.gasnier@foss.st.com, "Pankaj Dev" <pankaj.dev@st.com>,
"Rahul Kumar" <rahul.kumar05@st.com>,
"Clément Le Goffic" <clement.legoffic@foss.st.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Christian Bruel" <christian.bruel@foss.st.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Rob Herring" <robh@kernel.org>, "Rosen Penev" <rosenp@gmail.com>,
"Thinh Nguyen" <Thinh.Nguyen@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>,
devicetree@vger.kernel.org, kernel@dh-electronics.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY
Date: Thu, 27 Aug 2026 16:53:36 +0200 [thread overview]
Message-ID: <34c48ff1-524f-4d24-b53f-99e7171d08db@nabladev.com> (raw)
In-Reply-To: <7a16614a-bd1b-462a-be13-4a9c22aa588e@kernel.org>
On 8/27/26 2:54 PM, Krzysztof Kozlowski wrote:
> On 22/08/2026 09:46, Marek Vasut wrote:
>> +description:
>> + USB2 PHY block in STM32 is attached to USB 2.0 Host controller and
>> + USB 2.0 side of DWC3 DRD controller, and provides the USB LS/FS/HS
>> + connectivity. Both PHYs are the FEMTO-PHY, but their configuration
>> + bits in the system control register are different for each variant.
>> +
>> +maintainers:
>> + - Fabrice Gasnier <fabrice.gasnier@foss.st.com>
>> + - Marek Vasut <marex@nabladev.com>
>> + - Pankaj Dev <pankaj.dev@st.com>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - st,stm32mp25-usb2phy1
>> + - st,stm32mp25-usb2phy2
>> +
>> + "#clock-cells":
>> + const: 1
>> +
>
> As pointed out by different patchset built on top of it, this is wrong.
What is wrong in this (V3) of the patchset ? I think the ST patches were
fixing up V2 and what they were fixing up is already fixed here in V3.
> I do not understand why Fabrice Gasnier cannot reply HERE that this is
> wrong and instead another patch is sent for in-flight code. That's not
> your Marek problem, but lack of responsible review from ST...
ACK
next prev parent reply other threads:[~2026-08-27 17:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-22 7:46 [PATCH v3 0/9] arm64: dts: phy: st: usb: Add STM32MP2 USB support Marek Vasut
2026-08-22 7:46 ` [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY Marek Vasut
2026-08-22 7:55 ` sashiko-bot
2026-08-27 12:54 ` Krzysztof Kozlowski
2026-08-27 14:53 ` Marek Vasut [this message]
2026-08-27 21:33 ` Krzysztof Kozlowski
2026-08-27 23:14 ` Marek Vasut
2026-08-22 7:46 ` [PATCH v3 2/9] phy: stm32: Add support for " Marek Vasut
2026-08-22 7:58 ` sashiko-bot
2026-08-24 13:17 ` Fabrice Gasnier
2026-08-24 14:53 ` Marek Vasut
2026-08-27 16:00 ` Vinod Koul
2026-08-27 16:52 ` Marek Vasut
2026-08-22 7:46 ` [PATCH v3 3/9] dt-bindings: usb: generic-ehci: Document access-controllers property Marek Vasut
2026-08-22 7:46 ` [PATCH v3 4/9] dt-bindings: usb: generic-ohci: " Marek Vasut
2026-08-22 7:46 ` [PATCH v3 5/9] dt-bindings: usb: dwc3: Document ST STM32MP2 DWC3 xHCI USB controller Marek Vasut
2026-08-27 12:59 ` Krzysztof Kozlowski
2026-08-27 14:56 ` Marek Vasut
2026-08-22 7:46 ` [PATCH v3 6/9] usb: dwc3: dwc3-generic-plat: Add ST STM32MP2 DWC3 xHCI USB controller glue Marek Vasut
2026-08-22 7:56 ` sashiko-bot
2026-08-22 7:46 ` [PATCH v3 7/9] dt-bindings: arm: stm32: Switch st,stm32mp23/25-syscfg into simple-mfd Marek Vasut
2026-08-22 8:01 ` sashiko-bot
2026-08-27 13:07 ` Krzysztof Kozlowski
2026-08-27 15:04 ` Marek Vasut
2026-08-27 21:35 ` Krzysztof Kozlowski
2026-08-22 7:46 ` [PATCH v3 8/9] arm64: dts: st: Add USB nodes on stm32mp231 Marek Vasut
2026-08-22 8:07 ` sashiko-bot
2026-08-24 13:18 ` Fabrice Gasnier
2026-08-24 14:39 ` Marek Vasut
2026-08-22 7:46 ` [PATCH v3 9/9] arm64: dts: st: Add USB nodes on stm32mp251 Marek Vasut
2026-08-24 13:19 ` Fabrice Gasnier
2026-08-24 14:39 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c48ff1-524f-4d24-b53f-99e7171d08db@nabladev.com \
--to=marex@nabladev.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=christian.bruel@foss.st.com \
--cc=clement.legoffic@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=pankaj.dev@st.com \
--cc=rahul.kumar05@st.com \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox