From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BD0C433F5 for ; Sat, 23 Apr 2022 17:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236710AbiDWRwq (ORCPT ); Sat, 23 Apr 2022 13:52:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236685AbiDWRwb (ORCPT ); Sat, 23 Apr 2022 13:52:31 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DA9F34B8F for ; Sat, 23 Apr 2022 10:49:33 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id z19so729883edx.9 for ; Sat, 23 Apr 2022 10:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zzTlr5i1vBH3eZkwgYdNgfi9JX5fLc8qr1ql93tJV/Y=; b=K+1SaZwztaHUvVqD4eNlYpZBN76mjtx6X5TywZ3y38vEWUlCs3d3C8MG++H7IoHYDC obAlZ/MFE+RmLzK9BST6KuGjJgj2nvuxyf+EArxIFmALpq7dutV6VEVcrWnef1iZqfqu gsvljKL8WC0w2kuY/LP5FZJr0Cljwtb0q6RJYd5mHPwTHiHZQMBsMsbMIkawn+YRaPV5 xR6zfWn6NS16/H+5Phh3JIRq6JLCN3166AGSz5ZSR/j3UDt27gwBrNEW3Jjy3UFAYwl/ O5ehOaVT1XdJYZaveHMdsVPQP/+X762VrAFvmtHYQHPLhYENkSK48IKmGKBAYGwuZ0vC ol5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zzTlr5i1vBH3eZkwgYdNgfi9JX5fLc8qr1ql93tJV/Y=; b=j0oiS9urW29v20wC42JfXgtEpb3m2WkfEz9wyJpKQZ6D+p2IaRjm0Uv3y9PY8JO6ei FIdjcc4P1Z2HPZkVdtEtTXwDime7DTOj2rCKZudhGH5xmBF8rtGgCZE0KdMpNYYlmHKY U4bQn3HyeSfDrj1umnX+RQZHP+GPoeFEa6H2lFhV7aqS7VnRRLeg4lzgAuO1QJ+YPi6k r0kT5SfIx2oj6wVJ6ljwr1+JQEq1U8LuqqXSd4CeRKsNcrzHRE1LgupcoaoL+ps3ZgB9 8UKk87m6qfVAfe1bz6tC+tqu3N+7pCK5jGg38qWs6+5zioSrSZsIvLh/PmPz+s6chX3U 5isA== X-Gm-Message-State: AOAM531ynGYXdCvN27oHvNX+KNYuEM5rdZ4SWPAb7jfiit250kZ5v4tF 81Gb5+brWcFAutkvxrVPR+80XA== X-Google-Smtp-Source: ABdhPJw/vOnH+HBxj1ggcvptoHPHf/x94iLfOJcPMwCd4J+FV95mNVywr9SyxLVrLvWEXCzt9EK7aA== X-Received: by 2002:a05:6402:4493:b0:41d:83ca:35d6 with SMTP id er19-20020a056402449300b0041d83ca35d6mr10731655edb.89.1650736172007; Sat, 23 Apr 2022 10:49:32 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id r22-20020a17090638d600b006d584aaa9c9sm1871730ejd.133.2022.04.23.10.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Apr 2022 10:49:31 -0700 (PDT) Message-ID: <34d3bfdc-cf8c-bf63-4f67-57c8d6c9b780@linaro.org> Date: Sat, 23 Apr 2022 19:49:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH net-next 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Content-Language: en-US To: Maxime Chevallier , davem@davemloft.net, Rob Herring Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko References: <20220422180305.301882-1-maxime.chevallier@bootlin.com> <20220422180305.301882-5-maxime.chevallier@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20220422180305.301882-5-maxime.chevallier@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/04/2022 20:03, Maxime Chevallier wrote: > Add the DT binding for the IPQESS Ethernet Controller. This is a simple > controller, only requiring the phy-mode, interrupts, clocks, and > possibly a MAC address setting. > > Signed-off-by: Maxime Chevallier > --- > .../devicetree/bindings/net/qcom,ipqess.yaml | 94 +++++++++++++++++++ > 1 file changed, 94 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipqess.yaml > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipqess.yaml b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > new file mode 100644 > index 000000000000..8fec5633692f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ipqess.yaml > @@ -0,0 +1,94 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ipqess.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ ESS EDMA Ethernet Controller Device Tree Bindings s/Device Tree Bindings// > + > +allOf: > + - $ref: "ethernet-controller.yaml#" allOf goes after maintainers. > + > +maintainers: > + - Maxime Chevallier > + > +properties: > + compatible: > + const: qcom,ipq4019e-ess-edma > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 2 > + maxItems: 32 > + description: One interrupt per tx and rx queue, with up to 16 queues. > + > + clocks: > + maxItems: 1 > + > + phy-mode: true > + > + fixed-link: true > + > + mac-address: true You don't need all these three. They come from ethernet-controller and you use unevaluatedProperties. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - phy-mode > + > +unevaluatedProperties: false > + > +examples: > + - | > + gmac: ethernet@c080000 { > + compatible = "qcom,ipq4019-ess-edma"; > + reg = <0xc080000 0x8000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + status = "okay"; No status in the example. > + > + phy-mode = "internal"; > + fixed-link { > + speed = <1000>; > + full-duplex; > + pause; > + asym-pause; > + }; > + }; > + > +... Best regards, Krzysztof