From: Florian Fainelli <f.fainelli@gmail.com>
To: madalin.bucur@oss.nxp.com, davem@davemloft.net, netdev@vger.kernel.org
Cc: robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [PATCH net 0/3] net: fsl/fman: address erratum A011043
Date: Thu, 23 Jan 2020 13:09:22 -0800 [thread overview]
Message-ID: <34f22df7-409a-43d1-3c59-52e6a32fbf17@gmail.com> (raw)
In-Reply-To: <1579699229-5948-1-git-send-email-madalin.bucur@oss.nxp.com>
On 1/22/20 5:20 AM, Madalin Bucur wrote:
> This addresses a HW erratum on some QorIQ DPAA devices.
>
> MDIO reads to internal PCS registers may result in having
> the MDIO_CFG[MDIO_RD_ER] bit set, even when there is no
> error and read data (MDIO_DATA[MDIO_DATA]) is correct.
> Software may get false read error when reading internal
> PCS registers through MDIO. As a workaround, all internal
> MDIO accesses should ignore the MDIO_CFG[MDIO_RD_ER] bit.
> When the issue was present, one could see such errors
> during boot:
>
> mdio_bus ffe4e5000: Error while reading PHY0 reg at 3.3
Did you consider using the standard broken-turn-around property/support
and set your mii_bus::phy_ignore_ta_mask to all relevant bits?
>
> Madalin Bucur (3):
> dt-bindings: net: add fsl,erratum-a011043
> powerpc/fsl/dts: add fsl,erratum-a011043
> net/fsl: treat fsl,erratum-a011043
>
> Documentation/devicetree/bindings/net/fsl-fman.txt | 13 +++++++++++++
> .../boot/dts/fsl/qoriq-fman3-0-10g-0-best-effort.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-10g-0.dtsi | 1 +
> .../boot/dts/fsl/qoriq-fman3-0-10g-1-best-effort.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-10g-1.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-0.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-1.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-2.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-3.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-4.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-5.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-10g-0.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-10g-1.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-0.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-1.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-2.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-3.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-4.dtsi | 1 +
> arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-5.dtsi | 1 +
> drivers/net/ethernet/freescale/xgmac_mdio.c | 7 ++++++-
> 20 files changed, 37 insertions(+), 1 deletion(-)
>
--
Florian
prev parent reply other threads:[~2020-01-23 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 13:20 [PATCH net 0/3] net: fsl/fman: address erratum A011043 Madalin Bucur
2020-01-22 13:20 ` [PATCH net 1/3] dt-bindings: net: add fsl,erratum-a011043 Madalin Bucur
2020-01-22 13:20 ` [PATCH net 2/3] powerpc/fsl/dts: " Madalin Bucur
2020-01-22 13:20 ` [PATCH net 3/3] net/fsl: treat fsl,erratum-a011043 Madalin Bucur
2020-01-23 20:17 ` [PATCH net 0/3] net: fsl/fman: address erratum A011043 David Miller
2020-01-23 21:09 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34f22df7-409a-43d1-3c59-52e6a32fbf17@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=madalin.bucur@oss.nxp.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).