From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 2/2] media: adv7604: automatic "default-input" selection Date: Mon, 26 Sep 2016 11:31:04 +0300 Message-ID: <35118931.XClsGmnAtQ@avalon> References: <1474550340-31455-1-git-send-email-ulrich.hecht+renesas@gmail.com> <1474550340-31455-3-git-send-email-ulrich.hecht+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1474550340-31455-3-git-send-email-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Ulrich Hecht Cc: hans.verkuil@cisco.com, niklas.soderlund@ragnatech.se, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com, william.towle@codethink.co.uk, devicetree@vger.kernel.org, radhey.shyam.pandey@xilinx.com List-Id: devicetree@vger.kernel.org Hi Ulrich, Thank you for the patch. On Thursday 22 Sep 2016 15:19:00 Ulrich Hecht wrote: > Documentation states that the "default-input" property should reside > directly in the node of the device. This adjusts the parsing to make the > implementation consistent with the documentation. > > Based on patch by William Towle . > > Signed-off-by: Ulrich Hecht > Signed-off-by: Hans Verkuil Acked-by: Laurent Pinchart > --- > drivers/media/i2c/adv7604.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c > index 4003831..fa7046e 100644 > --- a/drivers/media/i2c/adv7604.c > +++ b/drivers/media/i2c/adv7604.c > @@ -3074,13 +3074,13 @@ static int adv76xx_parse_dt(struct adv76xx_state > *state) return ret; > } > > - if (!of_property_read_u32(endpoint, "default-input", &v)) > + of_node_put(endpoint); > + > + if (!of_property_read_u32(np, "default-input", &v)) > state->pdata.default_input = v; > else > state->pdata.default_input = -1; > > - of_node_put(endpoint); > - > flags = bus_cfg.bus.parallel.flags; > > if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH) -- Regards, Laurent Pinchart