From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andre Przywara <andre.przywara@arm.com>,
Icenowy Zheng <uwu@icenowy.me>
Cc: soc@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH v2 05/10] musb: sunxi: add support for the F1C100s MUSB controller
Date: Wed, 12 Oct 2022 23:24:04 +0200 [thread overview]
Message-ID: <3515217.R56niFO833@kista> (raw)
In-Reply-To: <20221012055602.1544944-6-uwu@icenowy.me>
Hi Icenowy,
Dne sreda, 12. oktober 2022 ob 07:55:57 CEST je Icenowy Zheng napisal(a):
> The suniv SoC has a MUSB controller like the one in A33, but with a SRAM
> region to be claimed.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> ---
> No changes since v1.
>
> drivers/usb/musb/sunxi.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 7f9a999cd5ff..4b368d16a73a 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -722,14 +722,17 @@ static int sunxi_musb_probe(struct platform_device
> *pdev) INIT_WORK(&glue->work, sunxi_musb_work);
> glue->host_nb.notifier_call = sunxi_musb_host_notifier;
>
> - if (of_device_is_compatible(np, "allwinner,sun4i-a10-musb"))
> + if (of_device_is_compatible(np, "allwinner,sun4i-a10-musb") ||
> + of_device_is_compatible(np, "allwinner,suniv-f1c100s-musb")) {
> set_bit(SUNXI_MUSB_FL_HAS_SRAM, &glue->flags);
> + }
>
> if (of_device_is_compatible(np, "allwinner,sun6i-a31-musb"))
> set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
>
> if (of_device_is_compatible(np, "allwinner,sun8i-a33-musb") ||
> - of_device_is_compatible(np, "allwinner,sun8i-h3-musb")) {
> + of_device_is_compatible(np, "allwinner,sun8i-h3-musb") ||
> + of_device_is_compatible(np, "allwinner,suniv-f1c100s-musb")) {
All that should be eventually converted to quirks. But for now:
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
> set_bit(SUNXI_MUSB_FL_NO_CONFIGDATA, &glue->flags);
> }
> @@ -815,6 +818,7 @@ static const struct of_device_id sunxi_musb_match[] = {
> { .compatible = "allwinner,sun6i-a31-musb", },
> { .compatible = "allwinner,sun8i-a33-musb", },
> { .compatible = "allwinner,sun8i-h3-musb", },
> + { .compatible = "allwinner,suniv-f1c100s-musb", },
> {}
> };
> MODULE_DEVICE_TABLE(of, sunxi_musb_match);
> --
> 2.37.1
next prev parent reply other threads:[~2022-10-12 21:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 5:55 [PATCH v2 00/10] SUNIV USB and PopStick support (and updating mailmap) Icenowy Zheng
2022-10-12 5:55 ` [PATCH v2 01/10] mailmap: update Icenowy Zheng's mail address Icenowy Zheng
2022-10-12 8:31 ` Arnd Bergmann
2022-10-12 8:35 ` Icenowy Zheng
2022-10-12 8:44 ` Arnd Bergmann
2022-10-12 5:55 ` [PATCH v2 02/10] dt-bindings: phy: add binding document for Allwinner F1C100s USB PHY Icenowy Zheng
2022-10-24 14:17 ` Andre Przywara
2022-10-12 5:55 ` [PATCH v2 03/10] dt-bindings: usb: sunxi-musb: add F1C100s MUSB compatible string Icenowy Zheng
2022-10-12 13:08 ` Krzysztof Kozlowski
2022-10-12 5:55 ` [PATCH v2 04/10] phy: sun4i-usb: add support for the USB PHY on F1C100s SoC Icenowy Zheng
2022-10-12 21:21 ` Jernej Škrabec
2022-10-13 8:49 ` Icenowy Zheng
2022-10-13 18:25 ` Jernej Škrabec
2022-10-14 2:56 ` Icenowy Zheng
2022-10-12 5:55 ` [PATCH v2 05/10] musb: sunxi: add support for the F1C100s MUSB controller Icenowy Zheng
2022-10-12 21:24 ` Jernej Škrabec [this message]
2022-10-12 5:55 ` [PATCH v2 06/10] ARM: suniv: add USB-related device nodes Icenowy Zheng
2022-10-24 14:16 ` Andre Przywara
2022-10-24 14:56 ` Icenowy Zheng
2022-10-12 5:55 ` [PATCH v2 07/10] ARM: suniv: f1c100s: enable USB on Lichee Pi Nano Icenowy Zheng
2022-10-12 13:11 ` Krzysztof Kozlowski
2022-10-12 5:56 ` [PATCH v2 08/10] dt-bindings: vendor-prefixes: add Source Parts Icenowy Zheng
2022-10-12 13:08 ` Krzysztof Kozlowski
2022-10-12 5:56 ` [PATCH v2 09/10] dt-binding: arm: sunxi: add compatible strings for PopStick v1.1 Icenowy Zheng
2022-10-12 13:09 ` Krzysztof Kozlowski
2022-10-24 14:17 ` Andre Przywara
2022-10-24 14:54 ` Icenowy Zheng
2022-10-12 5:56 ` [PATCH v2 10/10] ARM: dts: suniv: add device tree " Icenowy Zheng
2022-10-12 9:34 ` Clément Péron
2022-10-12 13:11 ` Krzysztof Kozlowski
2022-10-24 14:56 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3515217.R56niFO833@kista \
--to=jernej.skrabec@gmail.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=soc@kernel.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).