From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Matyas <daniel.matyas@analog.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Describe changes to the device tree
Date: Tue, 12 Sep 2023 12:16:43 +0200 [thread overview]
Message-ID: <351927e6-2ddf-186c-78ae-1b0d639b9ea7@kernel.org> (raw)
In-Reply-To: <20230911083735.11795-1-daniel.matyas@analog.com>
On 11/09/2023 10:37, Daniel Matyas wrote:
> Added new attributes to the device tree:
Subject: it's meaningless. You said there absolutely nothing. Instead
saying "Describe changes to the device tree" please describe the changes
you are making.
> - adi,comp-int
> - adi,alrm-pol
> - adi,flt-q
>
> These modify the corresponding bits in the configuration register.
>
> Signed-off-by: Daniel Matyas <daniel.matyas@analog.com>
> ---
> .../bindings/hwmon/adi,max31827.yaml | 21 +++++++++++++++++++
Please work on latest upstream, not some old vendor code. This means
that you should checkout latest mainline tree (or linux-next or
maintainer's tree) and make your edits there. Once you do it, you use
get_maintainers.pl on that tree, not on that ancient vendor's stuff.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-12 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 8:37 [PATCH 1/2] dt-bindings: hwmon: Describe changes to the device tree Daniel Matyas
2023-09-11 8:37 ` [PATCH 2/2] hwmon: max31827: Functional enhancement of the driver Daniel Matyas
2023-09-11 13:45 ` Guenter Roeck
2023-09-12 7:58 ` Matyas, Daniel
2023-09-12 18:43 ` Guenter Roeck
2023-09-11 13:38 ` [PATCH 1/2] dt-bindings: hwmon: Describe changes to the device tree Guenter Roeck
2023-09-11 21:12 ` Rob Herring
2023-09-12 10:16 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=351927e6-2ddf-186c-78ae-1b0d639b9ea7@kernel.org \
--to=krzk@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.matyas@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).