From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vinod <vkoul@kernel.org>, "sudheer.v" <open.sudheer@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Russell King <linux@armlinux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Jiri Slaby <jslaby@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Michael Moese <mmoese@suse.de>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-aspee
Subject: Re: [[PATCH] 8/9] DMA-UART-Driver-for-AST2500
Date: Wed, 17 Oct 2018 19:56:25 +1100 [thread overview]
Message-ID: <351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org> (raw)
In-Reply-To: <20181017060531.GU2400@vkoul-mobl>
On Wed, 2018-10-17 at 11:35 +0530, Vinod wrote:
> On 17-10-18, 09:41, sudheer.v wrote:
>
> Please add the change log describing the driver and its features
>
> > Signed-off-by: sudheer.v <open.sudheer@gmail.com>
>
>
> > ---
> > drivers/tty/serial/8250/8250_aspeed_uart_dma.c | 1594 ++++++++++++++++++++++++
> > 1 file changed, 1594 insertions(+)
> > create mode 100644 drivers/tty/serial/8250/8250_aspeed_uart_dma.c
> >
> > diff --git a/drivers/tty/serial/8250/8250_aspeed_uart_dma.c b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c
> > new file mode 100644
> > index 0000000..e1019a8
> > --- /dev/null
> > +++ b/drivers/tty/serial/8250/8250_aspeed_uart_dma.c
>
> why is this in serial. It is dmaengine driver so belongs to drivers/dma/
> like other controllers. Please move it out and resubmit.
It's not a dmaengine driver. It's a serial UART driver that happens to
use a dedicated DMA engine.
It's unclear whether it should be split into two drivers, or just have
the serial driver directly use the dma engine since that engine is
dedicated in HW to only work on those UARTs and nothing else...
Cheers,
Ben.
> While doing resubmission please take some time to understand subsystem
> tags to use. (hint git log <subsystem> will tell you)
>
> Also series has [[PATCH] 8/9] whereas it should be [PATCH 8/9] please
> let git generate that for you (hint git format-patch start..end does a
> good job)
>
> > @@ -0,0 +1,1594 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * drivers/tty/serial/8250/8250_aspeed_uart_dma.c
> > + * 1. 2018/07/01 Shivah Shankar created
> > + * 2. 2018/08/25 sudheer.veliseti<open.sudheer@gmail.com> modified
>
> we dont use this log in kernel. I do not see s-o-b by Shivah, that
> should be added. I think he should be author and you need to list
> changes you did..
>
next prev parent reply other threads:[~2018-10-17 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 4:10 [[PATCH] 0/9] *** DMA support for UART in ASPEED's AST2500 *** sudheer.v
2018-10-17 4:10 ` [[PATCH] 1/9] DT-changes-for-DMA-UART-of-AST2500 sudheer.v
2018-10-17 4:10 ` [[PATCH] 2/9] Defconfig-changes-for-DMA-UART-of-AST2500 sudheer.v
2018-10-17 4:11 ` [[PATCH] 4/9] Documentation-DTbindings-DMA-controller-of-AST2500 sudheer.v
2018-10-17 4:11 ` [[PATCH] 8/9] DMA-UART-Driver-for-AST2500 sudheer.v
2018-10-17 6:05 ` Vinod
2018-10-17 8:56 ` Benjamin Herrenschmidt [this message]
2018-10-18 9:55 ` Vinod
2018-10-18 23:32 ` Benjamin Herrenschmidt
2018-10-19 7:11 ` sudheer.v
2018-10-20 16:26 ` Vinod
2018-10-26 7:07 ` sudheer.v
2018-10-25 14:48 ` [[PATCH] 0/9] *** DMA support for UART in ASPEED's AST2500 *** Rob Herring
2018-10-26 7:23 ` sudheer.v
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=351eecd5b1b21893e94f76b34c058c6257b7f837.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=andrew@aj.id.au \
--cc=borntraeger@de.ibm.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=jslaby@suse.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mmoese@suse.de \
--cc=open.sudheer@gmail.com \
--cc=pombredanne@nexb.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).