Re: [PATCH v4 3/9] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

Andi Shyti
2024-09-03T16:47:20Z

Hi,

On Tue, Sep 03, 2024 at 11:59:34AM GMT, Detlev Casanova wrote:
> On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote:
> > Hi,
> >
> > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote:
> > > Just like RK356x and RK3588, RK3576 is compatible to the existing
> > > rk3399 binding.
> > >
> > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > > Acked-by: Heiko Stuebner <heiko@sntech.de>
> >
> > I will apply this after 1 and 2 have been merged.
>
> Sure, although it is not really dependent on 1 and 2.

yes, but I want to be sure that everything is coming in.

> > BTW, who is maintaining rockchip.yaml?
>
> Heiko Stuebner is the maintainer of Rockchip SoC support.

I would guess so, but I think we should also add the entry to
the maintainer's file :-)

Thanks,
Andi

> > Thanks,
> > Andi
> >
> > > ---
> > >
> > > Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> > > b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml index
> > > 82b9d6682297..a9dae5b52f28 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> > >
> > > @@ -38,6 +38,7 @@ properties:
> > > - rockchip,rk3308-i2c
> > > - rockchip,rk3328-i2c
> > > - rockchip,rk3568-i2c
> > >
> > > + - rockchip,rk3576-i2c
> > >
> > > - rockchip,rk3588-i2c
> > > - rockchip,rv1126-i2c
> > >
> > > - const: rockchip,rk3399-i2c
>
>
>
>