From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53661C4332F for ; Thu, 3 Nov 2022 12:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231673AbiKCMeE (ORCPT ); Thu, 3 Nov 2022 08:34:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbiKCMeB (ORCPT ); Thu, 3 Nov 2022 08:34:01 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AB85D2C2 for ; Thu, 3 Nov 2022 05:34:01 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id hh9so1045643qtb.13 for ; Thu, 03 Nov 2022 05:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9I5y8XG5Lzzo9JNEAsXYJPQ1gGgL0X0jO8Cdwi3LOzw=; b=v8MwxfmIzWn1eH+KFIoW3InBFOtvk8fX28/1rriqq1bjbWlMFSu+ykh5oBXtruv52u nabmU3A+pjy25qRm93hX9QnIK2VtbhpMKCfpK+dz6wLLYY1tC1EvcNnphNF8xUURm6FE jjd2OFM3F7fpBj5tC979eQE34I73e+KG2dkg3oUsiyeSkcc/VNU815O/zmEyzkHRoiLI WfS7YUYKJBw0CwhPJrWFqnDBNSiWY7BQfaByEh0ygCInNHbwV9llZO6yYLZ/osutUNYn EOrfn0QdP9se4DFA6sx6xD0SGGhUAD75oN7AEwQJ3amZJzHuUOHD+l61wRirsupPKAW6 oBww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9I5y8XG5Lzzo9JNEAsXYJPQ1gGgL0X0jO8Cdwi3LOzw=; b=cK7/z2BTkdp5stL7EujBVpDGhsTUeg+P47yJ0xjzarW1UZ8r/ID+Fb+fOP55pImUVb s1ZpWXsp9//TWzbD4aDZCVMJiuo5J0OKDL7rMGjSwWVkJ9u/WncVMYjz8buFZ47WSVTM knddTbJDnwU7JKimyM7VL5RYyvDXiXXPp2gw53EqQLZeJTFOAfrCDA2gUp83OHMmg3BF ANLKxvDox9B/VH68vLPeGle8VG/YZferolM3zPGNnJgLQAEiqBvvUrtgz/rNS/Iqd83S 0NrRZdBbKp/PBEarVHvxhWtZ8C0KLNbwtmrfyPau19IEYS6yU+qCzezYwd/P+SaTxAMp WEQQ== X-Gm-Message-State: ACrzQf3I0m3U89o/5VNoKdfIUZUj2AillfkQy0OkSI4yN0gz9prf3LSG YrPy4VTp+Sjfg3aMAUO2Z5chxA== X-Google-Smtp-Source: AMsMyM6L7ER32z+7Wwl3dzVJlPbwHGiRjuDj4pSa8q9v0F9hXqUeeu8liI/Ok+ZlIdD3Dn/SMMHc1Q== X-Received: by 2002:ac8:6a12:0:b0:3a5:27f2:4586 with SMTP id t18-20020ac86a12000000b003a527f24586mr16470769qtr.244.1667478840200; Thu, 03 Nov 2022 05:34:00 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id c5-20020a05620a268500b006fa4b111c76sm684680qkp.36.2022.11.03.05.33.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 05:33:59 -0700 (PDT) Message-ID: <352e31de-cb79-f08e-b817-2712d97b84f1@linaro.org> Date: Thu, 3 Nov 2022 08:33:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 3/3] arm64: dts: exynos: Rename compatible string property from version to SOC specific Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221102130602.48969-1-aakarsh.jain@samsung.com> <20221102130602.48969-3-aakarsh.jain@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221102130602.48969-3-aakarsh.jain@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/11/2022 09:06, Aakarsh Jain wrote: > commit "752d3a23d1f68de87e3c" which adds MFC codec device node > for exynos3250 SOC. Since exynos3250.dtsi and exynos5420.dtsi are > using same compatible string as "samsung,mfc-v7" but their > node properties are different.As both SoCs have MFC v7 hardware > module but with different clock hierarchy and complexity. > So renaming compatible string from version specific to SOC based. > > Suggested-by: Alim Akhtar > Fixes: 752d3a23d1f6 ("ARM: dts: add MFC codec device node for exynos3250") There is no bug to fix and backporting is forbidden as it breaks the usage of DTS in older kernel. > Signed-off-by: Aakarsh Jain > --- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 326b9e0ed8d3..98105c64f7d9 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -485,7 +485,7 @@ > }; > > mfc: codec@13400000 { > - compatible = "samsung,mfc-v7"; > + compatible = "samsung,exynos3250-mfc"; The change is non-bisectable and breaks using DTS in older kernel. Best regards, Krzysztof