From: Heiko Stuebner <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alex Bee <knaerzche@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, Alex Bee <knaerzche@gmail.com>
Subject: Re: [PATCH v3 1/5] phy: rockchip-inno-usb2: Split ID interrupt phy registers
Date: Mon, 20 Nov 2023 15:46:36 +0100 [thread overview]
Message-ID: <3530941.iIbC2pHGDl@phil> (raw)
In-Reply-To: <20231119121340.109025-2-knaerzche@gmail.com>
Am Sonntag, 19. November 2023, 13:13:36 CET schrieb Alex Bee:
> Commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ") added ID
> detection interrupt registers. However the current implementation assumes
> that falling and rising edge interrupt are always enabled in registers
> spanning over subsequent bits.
> That is not the case for RK3128's version of the phy and this
> implementation can't be used as-is, since there are bits with different
> purpose in between.
>
> This splits up the register definitions for id_det_en, id_det_en and
> id_det_clr registers in rising and falling edge variants.
> It's required as preparation to support RK3128's Innosilicon usb2 phy as
> well in this driver and matches pretty much to what the vendor does, so I'm
> not expecting issues for other SoCs with that change.
>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2023-11-20 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 12:13 [PATCH v3 0/5] Add USB support for RK3128 Alex Bee
2023-11-19 12:13 ` [PATCH v3 1/5] phy: rockchip-inno-usb2: Split ID interrupt phy registers Alex Bee
2023-11-20 14:46 ` Heiko Stuebner [this message]
2023-11-19 12:13 ` [PATCH v3 2/5] phy: phy-rockchip-inno-usb2: Add RK3128 support Alex Bee
2023-11-20 14:51 ` Heiko Stuebner
2023-11-19 12:13 ` [PATCH v3 3/5] ARM: dts: rockchip: Add USB host clocks for RK3128 Alex Bee
2023-11-19 12:13 ` [PATCH v3 4/5] ARM: dts: rockchip: Add dwc2 otg fifo siztes " Alex Bee
2023-11-19 12:13 ` [PATCH v3 5/5] ARM: dts: rockchip: Make usbphy the parent of SCLK_USB480M " Alex Bee
2023-11-20 15:31 ` (subset) [PATCH v3 0/5] Add USB support " Heiko Stuebner
2023-11-27 13:22 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3530941.iIbC2pHGDl@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=knaerzche@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).