Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Cheng Jiang <cheng.jiang@oss.qualcomm.com>,
	andersson@kernel.org, konradybcio@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: shikra: Add RF_CLK2 clock to wcn3988-pmu nodes
Date: Wed, 21 Oct 2026 11:15:09 +0200	[thread overview]
Message-ID: <3530adcb-a7ce-46c9-95b7-28aa544e8fef@oss.qualcomm.com> (raw)
In-Reply-To: <CAOK0kb90wYEQU8e9wfQ8g_KfkfqwiQ9_ideg2=mSrU8OuTLxRQ@mail.gmail.com>

On 10/21/26 11:05 AM, Cheng Jiang wrote:
> Hi Bjorn, Abel, Konrad,
> 
> Please drop this patch.
> 
> I re-tested on Shikra EVK with and without the RF_CLK2 clock described on
> the wcn3988-pmu nodes, and Bluetooth comes up in both cases. The
> commit message claim that Bluetooth fails to come up without the clock
> does not hold, so the patch is not needed for Bluetooth. Thanks to
> Abel and Konrad for the reviews.

It may be that you're lucky on the timing (or that clk-smd-rpm keeps
all clocks online). Please verify the schematic / clock map. If that
clock signal is connected to WCN, please go ahead with this patch.

Konrad

      reply	other threads:[~2026-10-21  9:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 13:08 [PATCH] arm64: dts: qcom: shikra: Add RF_CLK2 clock to wcn3988-pmu nodes Cheng Jiang
2026-10-20 13:12 ` Abel Vesa
2026-10-20 13:40 ` Konrad Dybcio
2026-10-21  9:05   ` Cheng Jiang
2026-10-21  9:15     ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3530adcb-a7ce-46c9-95b7-28aa544e8fef@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox