From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
"Rob Herring (Arm)" <robh@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@kernel.org>,
devicetree@vger.kernel.org, Lukasz Luba <lukasz.luba@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2] dt-bindings: thermal: idle: Complete the example code
Date: Tue, 21 Apr 2026 08:40:33 +0200 [thread overview]
Message-ID: <3539dd7d-9f02-4a98-acee-7bcf45a837ba@oss.qualcomm.com> (raw)
In-Reply-To: <67d47859-6481-40ab-b2c6-6d2eaa000ba5@oss.qualcomm.com>
On 20/04/2026 20:06, Daniel Lezcano wrote:
> On 4/7/26 21:29, Rob Herring (Arm) wrote:
>>
>> On Tue, 07 Apr 2026 07:39:58 +0200, Krzysztof Kozlowski wrote:
>>> Thermal bindings expect the node name with all the zones to be named
>>> 'thermal-zones' (hyphen instead of underscore) and thermal zones to end
>>> with '-thermal'. Also DTS coding style is not to use underscores for
>>> node names. After using correct names, bindings point warnings for
>>> missing properties, so add also thermal-sensors. Drop fake top
>>> compatible as it is not useful in this context.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> 1. Drop top level compatible and other properties
>>> 2. Add thermal-sensors
>>> 3. Rename also trips and cpu-thermal
>>> ---
>>> .../bindings/thermal/thermal-idle.yaml | 18 +++++++-----------
>>> 1 file changed, 7 insertions(+), 11 deletions(-)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>
> Hi Krzysztof,
>
> what about this error ?
It's real and it answers why fake model and compatible properties were
there in the first place. Please drop the patch from your queue, I will
prepare v3 at some point but needs a bit more time.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-04-21 6:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 5:39 [PATCH v2] dt-bindings: thermal: idle: Complete the example code Krzysztof Kozlowski
2026-04-07 16:24 ` Conor Dooley
2026-04-07 19:29 ` Rob Herring (Arm)
2026-04-20 18:06 ` Daniel Lezcano
2026-04-21 6:40 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3539dd7d-9f02-4a98-acee-7bcf45a837ba@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox