From: <Tudor.Ambarus@microchip.com>
To: vigneshr@ti.com, bbrezillon@kernel.org
Cc: marek.vasut@gmail.com, robh+dt@kernel.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller
Date: Sun, 20 Jan 2019 15:28:41 +0000 [thread overview]
Message-ID: <353a011e-920a-ddb3-4eef-e3256555ac93@microchip.com> (raw)
In-Reply-To: <6e6f7c3a-4772-1a17-0f5f-547ea9809283@microchip.com>
Vignesh,
On 01/20/2019 04:56 PM, Tudor.Ambarus@microchip.com wrote:
> Looks good.
one more thing: in cqspi_read_setup() I see that the dummy cycles are adjusted
if (f_pdata->inst_width != CQSPI_INST_TYPE_QUAD).
Should you adjust the dummy cycles for octo too? I tried to find a datasheet for
the controller, without success though ...
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-01-20 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 10:30 [PATCH v3 0/2] cadence-quadspi: Add Octal mode support Vignesh R
2019-01-16 10:30 ` [PATCH v3 1/2] dt-bindings: cadence-quadspi: Add new compatible for AM654 SoC Vignesh R
2019-01-16 10:30 ` [PATCH v3 2/2] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Vignesh R
2019-01-20 14:56 ` Tudor.Ambarus
2019-01-20 15:28 ` Tudor.Ambarus [this message]
2019-01-21 6:00 ` Vignesh R
2019-01-21 5:58 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353a011e-920a-ddb3-4eef-e3256555ac93@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).