From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm6375-pdx225: Add USBPHY regulators
Date: Wed, 27 Sep 2023 13:05:56 +0200 [thread overview]
Message-ID: <354e5b45-468e-4fe6-9646-6b4d9596393a@linaro.org> (raw)
In-Reply-To: <8bbdf132-a007-4cb7-b842-a81de7c1629a@linaro.org>
On 27.09.2023 13:01, Bryan O'Donoghue wrote:
> On 27/09/2023 10:21, Konrad Dybcio wrote:
>> To make dtbs_check happy and the software more aware of what's going
>> on, describe the HSUSB PHY's regulators and tighten up VDDA_PLL to match.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
>> index bbec7aee60be..0ce4fa8de8b0 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts
>> @@ -243,8 +243,8 @@ pm6125_l6: l6 {
>> };
>> pm6125_l7: l7 {
>> - regulator-min-microvolt = <720000>;
>> - regulator-max-microvolt = <1050000>;
>> + regulator-min-microvolt = <880000>;
>> + regulator-max-microvolt = <880000>;
>
> Where did the old values come from and why are the new values better ?
>
> Consider enumerating that in the commit log.
That's the pretty standard situation where:
- downstream defines very loose ranges
- developer uses these very loose ranges as a guideline
- some hardware (often the exclusive user of that regulator)
has a hidden-ish request of a tighter range
- the developer realizes that and has to fix up the ranges
Konrad
next prev parent reply other threads:[~2023-09-27 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 9:21 [PATCH 0/4] SM6375 features Konrad Dybcio
2023-09-27 9:21 ` [PATCH 1/4] arm64: dts: qcom: sm6375: Add UART1 Konrad Dybcio
2023-09-27 10:59 ` Bryan O'Donoghue
2023-09-27 9:21 ` [PATCH 2/4] arm64: dts: qcom: sm6375-pdx225: Enable MSS Konrad Dybcio
2023-09-27 9:21 ` [PATCH 3/4] arm64: dts: qcom: sm6375-pdx225: Enable ATH10K WiFi Konrad Dybcio
2023-09-27 9:21 ` [PATCH 4/4] arm64: dts: qcom: sm6375-pdx225: Add USBPHY regulators Konrad Dybcio
2023-09-27 11:01 ` Bryan O'Donoghue
2023-09-27 11:05 ` Konrad Dybcio [this message]
2023-09-27 11:16 ` Bryan O'Donoghue
2023-09-27 11:20 ` Konrad Dybcio
2023-10-16 18:25 ` [PATCH 0/4] SM6375 features Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=354e5b45-468e-4fe6-9646-6b4d9596393a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).