From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0880A4695 for ; Wed, 27 Sep 2023 11:06:01 +0000 (UTC) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF10A193 for ; Wed, 27 Sep 2023 04:05:59 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-9b281a2aa94so785177966b.2 for ; Wed, 27 Sep 2023 04:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695812758; x=1696417558; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X4MNJypFjWhOXg+vjR8/6N1m0XwqdwpdrXf8qtp+Kfc=; b=vnrBHK8OmUxcdByFT+xxVfqd1hvUD0uDHkLefXQ/ow9eygvUHT16ACmSmr9cwgFSiO ABM4JKbGpr/XsM2q84d/3nivrkNKGmKAi4t/WVxoBe0tKOfxC12ePLmU6HafkaVhx3II GK7Eri5QMzrTecIcHFV4/cvK4+mNFEhkBOafU/ZCxgEQneF4Sbz2fwTjh5HJs6X1fYcy MLkP3dE0jDiCHcyhtrFSAuHSaPMn/mVN+rZ9fuXJPwFHOhBZg8zdkQKC87wuGJ9mAXG6 NWcGqxCbPAx2GBXn4g43kRQkVjBN0ubhlsH9xbJBUP6XwYO30wKHltIsw5fFshHYb5EU RW+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695812758; x=1696417558; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X4MNJypFjWhOXg+vjR8/6N1m0XwqdwpdrXf8qtp+Kfc=; b=AyvWaTSDIgWOqjg67sa0xN1QRyZaiejvZ8/DrS0pIw66lAzoD6kvNmltkuNo4WTtw0 AxQLDYb2wS1w599nOpHSmn7WsDINOSiK1CdOnfoVDd30MvCqWzFnRipjDh0mfYaZixO8 FUScBhj3wQTvywvq7Dny/mYNfUkou7SYp9Nj7FD+UnXid1uxU4EMXW6jnnCCSykefySj STwZTHRbYvopxRURLUUBds+PzlxAitHFA/MNh3+SakcQgfH8p0nCLYFil5uGMQ4yNBZE zxPOMM4Fbhpo7CoCGKOicalYD/YPM5e928K1mWhgX/oTpF1L8r1ry4VBLlM5/UeaERNt 5Cxg== X-Gm-Message-State: AOJu0YxGg9OYfT6f7d8au0ru4Dnsnbp+w7y3MTe6x8YId2IOIDAzG0o/ P+hjJmg1zsNkw4NeLJ2SaX/QNw== X-Google-Smtp-Source: AGHT+IGe5XHS5ZU+n0G4YE9QX62/Daz5mEmdvc2HFNeTQgta0/VGL8VhH3AUp4VGsIwvB6VyUJJ6Ow== X-Received: by 2002:a17:907:78d8:b0:9a1:c447:3c62 with SMTP id kv24-20020a17090778d800b009a1c4473c62mr1427055ejc.49.1695812758428; Wed, 27 Sep 2023 04:05:58 -0700 (PDT) Received: from [192.168.33.189] (178235177023.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.23]) by smtp.gmail.com with ESMTPSA id ey6-20020a1709070b8600b009b2b7333c8bsm421980ejc.81.2023.09.27.04.05.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Sep 2023 04:05:58 -0700 (PDT) Message-ID: <354e5b45-468e-4fe6-9646-6b4d9596393a@linaro.org> Date: Wed, 27 Sep 2023 13:05:56 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm6375-pdx225: Add USBPHY regulators Content-Language: en-US To: Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230927-topic-6375_stuff-v1-0-12243e36b45c@linaro.org> <20230927-topic-6375_stuff-v1-4-12243e36b45c@linaro.org> <8bbdf132-a007-4cb7-b842-a81de7c1629a@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <8bbdf132-a007-4cb7-b842-a81de7c1629a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 27.09.2023 13:01, Bryan O'Donoghue wrote: > On 27/09/2023 10:21, Konrad Dybcio wrote: >> To make dtbs_check happy and the software more aware of what's going >> on, describe the HSUSB PHY's regulators and tighten up VDDA_PLL to match. >> >> Signed-off-by: Konrad Dybcio >> --- >>   arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts | 7 +++++-- >>   1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >> index bbec7aee60be..0ce4fa8de8b0 100644 >> --- a/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >> +++ b/arch/arm64/boot/dts/qcom/sm6375-sony-xperia-murray-pdx225.dts >> @@ -243,8 +243,8 @@ pm6125_l6: l6 { >>           }; >>             pm6125_l7: l7 { >> -            regulator-min-microvolt = <720000>; >> -            regulator-max-microvolt = <1050000>; >> +            regulator-min-microvolt = <880000>; >> +            regulator-max-microvolt = <880000>; > > Where did the old values come from and why are the new values better ? > > Consider enumerating that in the commit log. That's the pretty standard situation where: - downstream defines very loose ranges - developer uses these very loose ranges as a guideline - some hardware (often the exclusive user of that regulator) has a hidden-ish request of a tighter range - the developer realizes that and has to fix up the ranges Konrad