From: Arnd Bergmann <arnd@arndb.de>
To: Imran Khan <kimran@codeaurora.org>
Cc: andy.gross@linaro.org, David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: Add SoC info driver
Date: Tue, 25 Oct 2016 22:49:07 +0200 [thread overview]
Message-ID: <3567809.JctLPjIDdk@wuerfel> (raw)
In-Reply-To: <550ace3c-f2d3-6f3a-9566-cc1f83432484@codeaurora.org>
On Tuesday, October 25, 2016 3:23:34 PM CEST Imran Khan wrote:
> On 10/21/2016 4:03 PM, Arnd Bergmann wrote:
> >> +/* socinfo: sysfs functions */
> >
> > This seems overly verbose, having both raw and human-readable
> > IDs is generally not necessary, pick one of the two. If you
> > need any fields that we don't already support in soc_device,
> > let's talk about adding them to the generic structure.
> >
> >
>
> Okay. I will go for human readable IDs. Can we add 2 more fields
> in the generic structure.
> These 2 fields would be:
>
> vendor: A string for vendor name
> serial_number: A string containing serial number for the platform
serial_number seems straightforward, adding this seems like a good
idea. I don't understand yet what would go into the vendor field
though. For this particular driver, is it always "Qualcomm", or
would it be a third-party that makes a device based on that chip?
Arnd
next prev parent reply other threads:[~2016-10-25 20:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 14:06 [PATCH] soc: qcom: Add SoC info driver Imran Khan
[not found] ` <1476972386-28655-1-git-send-email-kimran-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-20 14:09 ` Mark Rutland
2016-10-20 15:20 ` Andy Gross
2016-10-25 9:38 ` Imran Khan
2016-10-21 10:33 ` Arnd Bergmann
2016-10-25 9:53 ` Imran Khan
2016-10-25 20:49 ` Arnd Bergmann [this message]
2016-10-26 13:50 ` Imran Khan
2016-10-26 14:05 ` Arnd Bergmann
2016-10-26 14:12 ` Imran Khan
2016-10-26 14:46 ` Arnd Bergmann
2016-10-27 13:10 ` Imran Khan
2016-10-27 13:41 ` Arnd Bergmann
2016-11-02 7:49 ` Imran Khan
2016-11-02 13:11 ` Arnd Bergmann
2016-11-02 16:28 ` Bjorn Andersson
2016-11-09 14:44 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3567809.JctLPjIDdk@wuerfel \
--to=arnd@arndb.de \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kimran@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).