Re: [PATCH v3 2/8] dt-bindings: extcon: qcom,pm8941-misc: Add PM8921 compatible

["MINETTE Alexandre" <contact@alex-min.fr>]

Sorry I initially replied to the wrong thread by mistake.

Thanks for the feedback, Krzysztof.

Do you mean that the PM8921 USB ID handling should be exposed by the
PM8921 parent node itself, so USB consumers would reference the PMIC
directly, e.g.:

  extcon = <&muic>, <&pm8921>;

I am fine with that model, but it would require more driver changes: the
current extcon driver binds to a separate platform device, while the
PM8921 parent node is already handled by the PM8xxx MFD driver.

Is that the direction you would prefer for v4?

-- 
  MINETTE Alexandre
  contact@alex-min.fr

Mer 20 mai 2026, à 09:22, Krzysztof Kozlowski a écrit :
> On 19/05/2026 09:16, Alexandre MINETTE via B4 Relay wrote:
>> From: Alexandre MINETTE <contact@alex-min.fr>
>> 
>> PM8921/PM8821 provide USB ID detection through the PMIC USB block. The
>> USB_ID_IN interrupt is exposed by the PM8921 interrupt controller and is
>> used by APQ8064 platforms for OTG role detection.
>> 
>> The device is modeled as a child of the SSBI-connected PM8921 PMIC.
>> Unlike PM8941, the downstream PM8xxx misc device is not instantiated with
>> a register resource for this path, and the mainline extcon driver only
>
> I could have guessed that at v2, but this suggests that device is not a
> separate block. If it does not have separate addressing, then it is not
> a dedicated/separate sub device in the PMIC and your node plus binding
> should be squashed into the parent.
>
>> needs the named USB ID interrupt. Allow qcom,pm8921-misc without requiring
>> reg.
>> 
>> Signed-off-by: Alexandre MINETTE <contact@alex-min.fr>
>> ---
>>  .../devicetree/bindings/extcon/qcom,pm8941-misc.yaml    | 17 +++++++++++++----
>>  1 file changed, 13 insertions(+), 4 deletions(-)
>
>
> Best regards,
> Krzysztof