From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F7CC61DA4 for ; Mon, 13 Mar 2023 20:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230128AbjCMUhX (ORCPT ); Mon, 13 Mar 2023 16:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbjCMUhV (ORCPT ); Mon, 13 Mar 2023 16:37:21 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05C988EF3 for ; Mon, 13 Mar 2023 13:37:19 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id x11so14320102pln.12 for ; Mon, 13 Mar 2023 13:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678739839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6Eym63TM4KgsTNGStmMuI60e+3KvWu4UM9TlUWPbCao=; b=QZvHaXSUo12vTSeH7fF926ddWsF5PfwbeseQItsRUBTSaFrWwEgpIRIMM6GOXYXFzt 4ls1tjt/awzhfxBZDU+bgcG7jlrLIYW/DJs4DL4vZgHXsnujINej8fpkoShEhZJ7K61m tt0Qpfmef/MONRhvFUkSOfz+djSt12LTGOlVf3w9WIF6GNvVvj2ed/PIUjHSxhxtZxvW 0c/7vu4lcuZ1Km2Qx46zfahw1OcBcQtZsvaa4oEiirheUjtr0JA4YN2Pv6CivEG63xEe 4fx3BUY04YA7AD1uQSki6E10bKM62QqoMwbWoVAvfS3bRYHJd/DuAjikX8jghURcnmhD 6gZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678739839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6Eym63TM4KgsTNGStmMuI60e+3KvWu4UM9TlUWPbCao=; b=nylDAKXosg7mOmK0X4b4WPQwFTE1UcmAEdJNZhVibaBKuBbwhvjRmZEmUleTFzNsUL lzqvw3ugPqKWL4RvCPedk1aLlIk8h/txkZYAquBEAMVopjCyi4Fix0UQ8BZ8mjQJycvG T9iQcxodPyz0YdP9nhloBxCbOkyvWn/tcUHMBb+xet+loDy81ahP9UKa3syXa2wi+pnC 3ylW4abRMf2j/0skFuoNPNbeBPURgSGmoo569NhdC4S+uI5Wqfeg89dEjhRaFlXrKrL/ XRT/cud7tYjwmHUU4Z2b+tQ1dNHYFuMqAIaFOfseciRp7crqHkkxIa+Gl1YybWmGdzOj W/CA== X-Gm-Message-State: AO0yUKXSP2Wq190HVJjA8dtWmywkRIIpbsWk9kF+AP6G0iXfiprkEVSR MI4KrPQeTHaV7csoS5uJXNQBaw== X-Google-Smtp-Source: AK7set8fianLoP6cpm7Osru5bWjvxpTuuwNW+QjuIDJqhS4wSr4TVYgQrs4DWnq8TCBKinOc1lbJUA== X-Received: by 2002:a17:902:f54d:b0:1a0:4fda:54a with SMTP id h13-20020a170902f54d00b001a04fda054amr3816849plf.56.1678739839161; Mon, 13 Mar 2023 13:37:19 -0700 (PDT) Received: from ?IPV6:2401:4900:1c5e:4a3e:15d0:d540:3861:ef0e? ([2401:4900:1c5e:4a3e:15d0:d540:3861:ef0e]) by smtp.gmail.com with ESMTPSA id x9-20020a170902820900b001a0448731c2sm285150pln.47.2023.03.13.13.37.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Mar 2023 13:37:18 -0700 (PDT) Message-ID: <35700295-8f30-08a7-2f83-edd3d92482fd@linaro.org> Date: Tue, 14 Mar 2023 02:07:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] arm64: dts: qcom: sm6115: Add CPU idle-states Content-Language: en-US To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, agross@kernel.org, andersson@kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230118203428.910992-1-bhupesh.sharma@linaro.org> <77fbf01f-58fc-55a2-415b-c39d991e7c96@linaro.org> From: Bhupesh Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3/3/23 6:33 AM, Konrad Dybcio wrote: > > > On 18.01.2023 21:48, Bhupesh Sharma wrote: >> On Thu, 19 Jan 2023 at 02:10, Konrad Dybcio wrote: >>> >>> >>> >>> On 18.01.2023 21:34, Bhupesh Sharma wrote: >>>> Add CPU idle-state nodes and power-domains in Qualcomm sm6115 SoC dtsi. >>>> >>>> Signed-off-by: Bhupesh Sharma >>>> --- > [...] > >>>> + >>>> + domain-idle-states { >>>> + CLUSTER_SLEEP_0: cluster-sleep-0 { >>>> + compatible = "domain-idle-state"; >>>> + idle-state-name = "cluster-power-collapse"; >>>> + arm,psci-suspend-param = <0x41000043>; >>>> + entry-latency-us = <800>; >>>> + exit-latency-us = <2118>; >>>> + min-residency-us = <7376>; >>> These values vary per cluster, see qcom,pm-cluster-level@2 in the >>> file linked above.. We should either split that, or at least take >>> max() of each value between the two nodes to make sure the sleep >>> state is exited properly on both types of cores. >> >> Ack to both the above observations. Will send a fixed v2 shortly. > In doing so, please also add support for D3G cluster sleep states > as well, it sounds beneficial to have a middleground between a total > power collapse and a simple wfi. > Right. I am adding D3G in v2. I will share the same shortly. Regards, Bhupesh