devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: m.brock@vanmierlo.com
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, hvilleneuve@dimonoff.com,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property
Date: Thu, 21 Sep 2023 12:29:13 +0200	[thread overview]
Message-ID: <35710516d0c7f41eebceb16ee51d9d4d@vanmierlo.com> (raw)
In-Reply-To: <20230920152015.1376838-4-hugo@hugovil.com>

Hugo Villeneuve wrote on 2023-09-20 17:20:
> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> @@ -21,8 +21,8 @@ Optional properties:
>    the second cell is used to specify the GPIO polarity:
>      0 = active high,
>      1 = active low.
> -- irda-mode-ports: An array that lists the indices of the port that
> -		   should operate in IrDA mode.
> +- nxp,irda-mode-ports: An array that lists the indices of the port 
> that
> +		       should operate in IrDA mode.
>  - nxp,modem-control-line-ports: An array that lists the indices of
> the port that

Are you sure you want this line removed?

>  				should have shared GPIO lines configured as
>  				modem control lines.
> @@ -80,8 +80,8 @@ Optional properties:
>    the second cell is used to specify the GPIO polarity:
>      0 = active high,
>      1 = active low.
> -- irda-mode-ports: An array that lists the indices of the port that
> -		   should operate in IrDA mode.
> +- nxp,irda-mode-ports: An array that lists the indices of the port 
> that
> +		       should operate in IrDA mode.
>  - nxp,modem-control-line-ports: An array that lists the indices of
> the port that

Same here.

>  				should have shared GPIO lines configured as
>  				modem control lines.

Greets,
Maarten


  reply	other threads:[~2023-09-21 18:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 15:20 [PATCH 0/4] serial: sc16is7xx: device tree improvements Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 1/4] serial: sc16is7xx: use device_property APIs when configuring irda mode Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 2/4] serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property Hugo Villeneuve
2023-09-21 10:29   ` m.brock [this message]
2023-09-21 13:37     ` Hugo Villeneuve
2023-09-21 13:47   ` Conor Dooley
2023-09-21 16:24   ` Rob Herring
2023-09-21 16:32     ` Hugo Villeneuve
2023-09-22 19:52       ` Rob Herring
2023-09-27 14:28         ` Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 4/4] dt-bindings: sc16is7xx: convert to YAML Hugo Villeneuve
2023-09-20 23:13   ` Rob Herring
2023-09-21 16:22     ` Hugo Villeneuve
2023-09-21 13:45   ` Conor Dooley
2023-09-21 15:30     ` Hugo Villeneuve
2023-09-22 11:35       ` Conor Dooley
2023-09-22 13:08         ` Hugo Villeneuve
2023-09-21 15:33   ` Rob Herring
2023-09-21 16:27     ` Hugo Villeneuve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35710516d0c7f41eebceb16ee51d9d4d@vanmierlo.com \
    --to=m.brock@vanmierlo.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).