public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: "xianwei.zhao" <xianwei.zhao@amlogic.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Vyacheslav Bocharov <adeep@lexina.in>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings
Date: Thu, 9 Dec 2021 14:58:15 +0100	[thread overview]
Message-ID: <357b657c-161e-9977-976f-387165aa4883@baylibre.com> (raw)
In-Reply-To: <bd981d0c-af5c-2b29-0ae3-df6bf01ea485@baylibre.com>

On 09/12/2021 14:55, Neil Armstrong wrote:
> +cc linux-amlogic@lists.infradead.org linux-arm-kernel@lists.infradead.org
> 
> On 08/12/2021 10:33, xianwei.zhao wrote:
>> Add bindings for the new Amlogic S4 SoC family,
>> and the compatible for the Amlogic S4 Based AQ222 board.

What's the SoC commercial name ? s805x2 ? and the board model ? AQ222 and the family ? S4 ?

>>
>> S4 is an application processor designed for hybrid OTT/IP Set To
>> Box(STB) and high-end media box applications, with quad core Cortex-A35.
>>
>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>> ---
>>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index 36081734f720..63037ebdd7bf 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -183,6 +183,12 @@ properties:
>>                - amlogic,ad401
>>            - const: amlogic,a1
>>  
>> +      - description: Boards with the Amlogic Meson S4 AQ222 SoC

So it should be:
      - description: Boards with the Amlogic Meson S4 S805X2 SoC

>> +        items:
>> +          - enum:
>> +              - amlogic,aq222
>> +          - const: amlogic,s4
>> +
>>  additionalProperties: true
>>  
>>  ...
>>
>> base-commit: a3ebdcc8fb3d94de390e58ad3da6161826a58a87
>>
> 

Neil

      reply	other threads:[~2021-12-09 13:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211208093347.4837-1-xianwei.zhao@amlogic.com>
2021-12-09 13:55 ` [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings Neil Armstrong
2021-12-09 13:58   ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=357b657c-161e-9977-976f-387165aa4883@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=adeep@lexina.in \
    --cc=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=robh+dt@kernel.org \
    --cc=xianwei.zhao@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox