devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: devicetree@vger.kernel.org,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	sergei.shtylyov@cogentembedded.com, magnus.damm@gmail.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org, horms@verge.net.au,
	geert@linux-m68k.org, niklas.soderlund@ragnatech.se
Subject: Re: [PATCH 4/7] arm64: dts: renesas: r8a77970: add the LVDS instance
Date: Fri, 06 Apr 2018 16:38:17 +0300	[thread overview]
Message-ID: <3587638.6pi5kZKTO5@avalon> (raw)
In-Reply-To: <1523020092-25540-5-git-send-email-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thank you for the patch.

On Friday, 6 April 2018 16:08:09 EEST Jacopo Mondi wrote:
> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> the it to the LVDS output of the DU. While at it align the endpoint name
> of the du to du_out_lvds0 which is used in other Renesas DTS files to
> describe this link.

The endpoint could be renamed in patch 3/7, but it's not a big deal.

> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 29 +++++++++++++++++++++++++++-
>  1 file changed, 28 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77970.dtsi index e649e86..b48d62c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -658,7 +658,34 @@
> 
>  				port@1 {
>  					reg = <1>;
> -					du_out_lvds: endpoint {
> +					du_out_lvds0: endpoint {
> +						remote-endpoint = <&lvds0_in>;
> +					};
> +				};
> +			};
> +		};
> +
> +		lvds0: lvds@feb90000 {
> +			compatible = "renesas,r8a77970-lvds";
> +			reg = <0 0xfeb90000 0 0x14>;
> +			clocks = <&cpg CPG_MOD 727>;
> +			power-domains = <&sysc R8A77970_PD_ALWAYS_ON>;
> +			resets = <&cpg 727>;
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					lvds0_in: endpoint {
> +						remote-endpoint = <&du_out_lvds0>;
> +					};
> +				};
> +				port@1 {
> +					reg = <1>;
> +					lvds0_out: endpoint {
>  					};
>  				};
>  			};

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-04-06 13:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 13:08 [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge Jacopo Mondi
2018-04-06 13:08 ` [PATCH 1/7] arm64: dts: renesas: r8a77970: add FCPVD support Jacopo Mondi
2018-04-06 13:28   ` Laurent Pinchart
2018-04-09 12:19     ` Simon Horman
2018-04-06 13:08 ` [PATCH 2/7] arm64: dts: renesas: r8a77970: add VSPD support Jacopo Mondi
2018-04-06 13:33   ` Laurent Pinchart
2018-04-09 12:21     ` Simon Horman
2018-04-06 13:08 ` [PATCH 3/7] arm64: dts: renesas: r8a77970: add DU support Jacopo Mondi
2018-04-06 13:36   ` Laurent Pinchart
2018-04-06 13:08 ` [PATCH 4/7] arm64: dts: renesas: r8a77970: add the LVDS instance Jacopo Mondi
2018-04-06 13:38   ` Laurent Pinchart [this message]
2018-04-06 13:08 ` [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU Jacopo Mondi
2018-04-06 13:45   ` Laurent Pinchart
2018-04-06 13:47     ` Laurent Pinchart
2018-04-06 13:08 ` [PATCH 6/7] arm64: dts: renesas: eagle: Add LVDS decoder Jacopo Mondi
2018-04-06 13:49   ` Laurent Pinchart
2018-04-06 13:08 ` [PATCH 7/7] arm64: dts: renesas: eagle: Add ADV7511W and HDMI output Jacopo Mondi
2018-04-06 13:51   ` Laurent Pinchart
2018-04-06 14:16     ` jacopo mondi
2018-04-06 13:17 ` [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge jacopo mondi
2018-04-06 13:53 ` Laurent Pinchart
2018-04-06 14:13   ` jacopo mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3587638.6pi5kZKTO5@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).