From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 043CE45107D for ; Wed, 15 Jul 2026 12:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784117777; cv=none; b=REs7Zgsrui8LDJORC/S3tQ2NnljuEmSgCGzZSrsfsxs3VkNHbM+RUvxFWbffXgMKWUiEt1V7yoQZAb2XsylKmr4RS/LsfHQkElA0kXDzqiaf6+e5mDLDS6a6cDWoIM/iEtvdR9EIXPVdzqMwKekc8kBb3sOpfWgae1XVmUSEJlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784117777; c=relaxed/simple; bh=lT/7WO1wjfB3oak0cuKJt8DGXn0vntMapQEjDanB03g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MQS20JDEF4CgJbZ+XBgNGOAMU8kHg9B+TvLf/kERkdTW+MA3UDXEc3YmwTdFrhZSVy6fi0c5A9jNOI+HvwX5gclmfPX95a1uPJHkQCp5X9uGSOhjzLDRgivgf803ZbXwYu2uxPZ84kPbxT7dGV+W17edBQdEA1lzY9Z+bXYqsXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=NQGNb5C5; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="NQGNb5C5" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8f0d6853360so39255606d6.0 for ; Wed, 15 Jul 2026 05:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1784117773; x=1784722573; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XYn30NuQBlpDBaqikH9GRFE2pdu5APUaoZom7kBIJ94=; b=NQGNb5C5jnfBAQINK7wvlbn8IPZv3rcr2zxxsCoqDbuoSM09Y4mGJEh9XDLG/iAL/3 qAchGiyBkZN8PDlWyFGef/7O6UzbVIqJrBbe1/Agg1mNf773w698sQOrUuzL2Apb9PVq Z5bR2xMkCXmoe2JR/W1paOmNEnbAiDRvckrWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784117773; x=1784722573; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XYn30NuQBlpDBaqikH9GRFE2pdu5APUaoZom7kBIJ94=; b=GxIA+HcNN7X7wAIuFcYu05s7pHLrhBq2c17XqnnyAmPUcI2WbUCY/QDrJpiL3g9RGE HDaH5lvl95vtUCqITVkRyg9YPrPpnaZ/PFWa0M4roi15HczYgM8Wn9z6FOlB102MNmQG cjOu6tY5E4hudUfZOBzV6ztvum0OZb7ExO8OwSLIJjSpMnjLbmpRAw949dveHK/X3+eL yP7khrG71MXKz+Z3gKQrAhO5KVnuog/N34lgI0TLldtDfBoK89pWW5fXb8VzO8JMQSwx 89s4zY0pYj28T0H+7alCUJb20cj4SoT/1P6Ayv+TxBQb6iheG2A3zW7h7hQf9bWoFhRe +WnQ== X-Forwarded-Encrypted: i=1; AHgh+RpFQwn8cCT60Ixw5m5qYBn1o8QR6uCXxEwK5tdrz/qiiCW3cgZJWPZmHSMtjDnIu3zPgpF2QVoNVjP2@vger.kernel.org X-Gm-Message-State: AOJu0Yy0BDkiVUm7fModwok+r9ypq59KXGtDrKoxB+qOrAucO1GBIFip dm4BW+2fuAsOxTQvb3zWXd6iEJ6j+dpJWeVWYSJDCmtXEIyVFk0GNRUSwre/v0tpHg== X-Gm-Gg: AfdE7ckAH8yDlzOqbRsGW7ntzgN2Y+2CU7cRT+xdh7p/M/DqIZ47hZpMkRzbis69GOs gN03dR3wvyC4EcxJV6eiVFiXNdryXvonHrN/aoCw6lqT7zwrvHQmK5g67ditoom2xFRCCkeJ/2g cPfj4M+aONnRTj76HJs2S08ctrRKsbnwhzCfZ0776B5XzEh9tEwyjArBafwOmx0rRZAtL8hwKmk 8NAhPTTO8tiWQVDrz25ANXOjX0wk9p+tf/BUuKvI1H42Y+o99Kqe5Uop8IqtJ3XDkrHVpdeyqXZ pc0odGQvXRcPkwyK7jikvVKIXzcOlNOAGTN4aZva5Z0xyxg+MkYuZlbFDQiQJIDKqfnZMcKY0p7 rqRBUGpGzYlUisJDHAqyWSRISYoVADz943AeQuo6IkgGIFdOr5z7U/dHIB543Ay9L/tWmilwDQX bZC3wh9fTYUJW3uza01b40 X-Received: by 2002:a05:6214:500e:b0:8ef:5b18:65ec with SMTP id 6a1803df08f44-9074c70b5cemr66890686d6.15.1784117772692; Wed, 15 Jul 2026 05:16:12 -0700 (PDT) Received: from [10.211.55.5] ([73.62.185.64]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-8ffd7c1fd2bsm193918296d6.27.2026.07.15.05.16.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 05:16:11 -0700 (PDT) Message-ID: <358b1215-df7a-427f-89cc-55a6f2cf357c@ieee.org> Date: Wed, 15 Jul 2026 07:16:08 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 11/14] net: ipa: Switch to generic PAS TZ APIs To: Bjorn Andersson , Sumit Garg Cc: konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jenswi@kernel.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg , Alex Elder , Konrad Dybcio References: <20260702115835.167602-1-sumit.garg@kernel.org> <20260702115835.167602-12-sumit.garg@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/11/26 11:06 AM, Bjorn Andersson wrote: > On Thu, Jul 02, 2026 at 05:28:27PM +0530, Sumit Garg wrote: >> From: Sumit Garg >> >> Switch ipa client driver over to generic PAS TZ APIs. Generic PAS TZ >> service allows to support multiple TZ implementation backends like QTEE >> based SCM PAS service, OP-TEE based PAS service and any further future TZ >> backend service. >> > > Please find an immutable branch with the dependencies for this patch at: > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git 20260702115835.167602-2-sumit.garg@kernel.org > > Alternatively, if you think there will be no conflicting patches in the > time leading up to next merge window provide an Ack and I can pick this > through the qcom tree. I don't see any reason there would be any conflicts (certainly no difficult conflicts) with this commit, so I think you can safely take it with the others through the Qualcomm tree. So if my ack is what you're looking for: Acked-by: Alex Elder Thank you Sumit and Bjorn. > > Thanks, > Bjorn > >> Reviewed-by: Alex Elder >> Reviewed-by: Konrad Dybcio >> Signed-off-by: Sumit Garg >> --- >> drivers/net/ipa/Kconfig | 2 +- >> drivers/net/ipa/ipa_main.c | 13 ++++++++----- >> 2 files changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig >> index 01d219d3760c..a9aff1b7977d 100644 >> --- a/drivers/net/ipa/Kconfig >> +++ b/drivers/net/ipa/Kconfig >> @@ -6,7 +6,7 @@ config QCOM_IPA >> depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) >> depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n >> select QCOM_MDT_LOADER >> - select QCOM_SCM >> + select QCOM_PAS >> select QCOM_QMI_HELPERS >> help >> Choose Y or M here to include support for the Qualcomm >> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c >> index 788dd99af2a4..3cd9e44680e9 100644 >> --- a/drivers/net/ipa/ipa_main.c >> +++ b/drivers/net/ipa/ipa_main.c >> @@ -14,7 +14,7 @@ >> #include >> #include >> >> -#include >> +#include >> #include >> >> #include "ipa.h" >> @@ -624,10 +624,13 @@ static int ipa_firmware_load(struct device *dev) >> } >> >> ret = qcom_mdt_load(dev, fw, path, IPA_PAS_ID, virt, phys, size, NULL); >> - if (ret) >> + if (ret) { >> dev_err(dev, "error %d loading \"%s\"\n", ret, path); >> - else if ((ret = qcom_scm_pas_auth_and_reset(IPA_PAS_ID))) >> - dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); >> + } else { >> + ret = qcom_pas_auth_and_reset(IPA_PAS_ID); >> + if (ret) >> + dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); >> + } >> >> memunmap(virt); >> out_release_firmware: >> @@ -758,7 +761,7 @@ static enum ipa_firmware_loader ipa_firmware_loader(struct device *dev) >> return IPA_LOADER_INVALID; >> out_self: >> /* We need Trust Zone to load firmware; make sure it's available */ >> - if (qcom_scm_is_available()) >> + if (qcom_pas_is_available()) >> return IPA_LOADER_SELF; >> >> return IPA_LOADER_DEFER; >> -- >> 2.53.0 >>