From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jinlong Mao <quic_jinlmao@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>
Subject: Re: [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property
Date: Thu, 30 Nov 2023 13:06:10 +0100 [thread overview]
Message-ID: <35916812-af55-4b2a-99e5-8566e945cb6e@linaro.org> (raw)
In-Reply-To: <591e1aca-20ca-4d42-809d-12cd12ddadb3@quicinc.com>
On 30/11/2023 12:15, Jinlong Mao wrote:
>
>
> On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
>> On 29/11/2023 15:38, Mao Jinlong wrote:
>>> The inport of funnel@3023000 connects to a source which is not supported
>>> in current linux kernel. Remove the device tree node of funnel@3023000
>>> to fix the warning. It will be added once the driver support to the
>>> source is added to linux kernel.
>>
>> Thanks for the changes, but that's not correct reason to remove DTS
>> code. What kernel supports or not, should be irrelevant for the DTS. DTS
>> for example is used in other projects - did you check if they have the
>> same issues? Anyway, DTS describes the hardware, so how current kernel
>> support defines what is and what is not in the hardware?
>>
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> The funnel dt node must have in-ports node. It is to describe the input
> connection of funnel HW. But there is no dt_binding doc to describe the
> DT node of the HW connected to funnel@3023000. So remove the funnel to
> solve the warning as of now. The funnel will be added back once driver
> and dt_binding are added for the HW.
>
> Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
Why we cannot add now the binding for the connected hardware? It's not
really related to the driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-30 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:38 [PATCH v1 0/3] arm64: dts: qcom: Fix the warnings from coresight bindings Mao Jinlong
2023-11-29 14:38 ` [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a required property Mao Jinlong
2023-11-30 8:55 ` Krzysztof Kozlowski
2023-11-30 11:15 ` Jinlong Mao
2023-11-30 12:06 ` Krzysztof Kozlowski [this message]
2023-11-30 13:12 ` Jinlong Mao
2023-11-30 13:35 ` Krzysztof Kozlowski
2023-11-30 13:37 ` Jinlong Mao
2023-11-29 14:38 ` [PATCH v1 2/3] arm64: dts: qcom: msm8998: Fix 'out-ports' " Mao Jinlong
2023-11-30 9:03 ` Krzysztof Kozlowski
2023-11-29 14:38 ` [PATCH v1 3/3] arm64: dts: qcom: Fix coresight warnings in in-ports and out-ports Mao Jinlong
2023-11-30 9:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35916812-af55-4b2a-99e5-8566e945cb6e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).