From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF765C2D0EF for ; Sat, 18 Apr 2020 09:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AECA5214D8 for ; Sat, 18 Apr 2020 09:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725857AbgDRJtq (ORCPT ); Sat, 18 Apr 2020 05:49:46 -0400 Received: from gloria.sntech.de ([185.11.138.130]:48048 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725856AbgDRJtq (ORCPT ); Sat, 18 Apr 2020 05:49:46 -0400 Received: from p57b77241.dip0.t-ipconnect.de ([87.183.114.65] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPk6X-0000lO-Su; Sat, 18 Apr 2020 11:49:41 +0200 From: Heiko Stuebner To: Johan Jonker Cc: justin.swartz@risingedge.co.za, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mark.rutland@arm.com, robh+dt@kernel.org Subject: Re: [PATCH v4 2/3] ARM: dts: rockchip: add rga node for rk322x Date: Sat, 18 Apr 2020 11:49:41 +0200 Message-ID: <3593382.iQIKm1rSL1@phil> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Samstag, 18. April 2020, 11:15:27 CEST schrieb Johan Jonker: > Hi Justin, Heiko, > > In the discussion about "rockchip,px30-rga" it was mentioned that: > "no status for soc internal components without any board-specifics". > The binding is in mainline, but the dts node is missing I think. > Should this also be changed? yep, drop the status disabled from the dtsi and that then results in not needing the board-level enablement (background: rga is a simple mem2mem device without any board-specific hooks) > > Johan > > +&rga { > + status = "okay"; > +}; > + > > > Add a node to define the presence of RGA, a 2D raster > > graphic acceleration unit. > > > > Signed-off-by: Justin Swartz > > --- > > arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi > > index 340ed6ccb..29d50bebc 100644 > > --- a/arch/arm/boot/dts/rk322x.dtsi > > +++ b/arch/arm/boot/dts/rk322x.dtsi > > @@ -621,6 +621,17 @@ > > status = "disabled"; > > }; > > > > + rga: rga@20060000 { > > + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga"; > > + reg = <0x20060000 0x1000>; > > + interrupts = ; > > + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>; > > + clock-names = "aclk", "hclk", "sclk"; > > + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; > > + reset-names = "core", "axi", "ahb"; > > > + status = "disabled"; > > remove? > > > + }; > > + > > iep_mmu: iommu@20070800 { > > compatible = "rockchip,iommu"; > > reg = <0x20070800 0x100>; > >