From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device tree Date: Sat, 27 Feb 2016 00:16:35 +0100 Message-ID: <3593471.QAyZdAuTcW@wuerfel> References: <1448529671-48216-1-git-send-email-hongtao.jia@freescale.com> <2396230.MApG9VTrxr@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org To: Li Yang Cc: linuxppc-dev , devicetree@vger.kernel.org, "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Jia Hongtao , Eduardo Valentin , Viresh Kumar , Scott Wood List-Id: devicetree@vger.kernel.org On Friday 26 February 2016 17:07:09 Li Yang wrote: > > I don't have a perfect solution either. But I think this is still > better than making cpufreq not usable. The cpufreq driver will print > out an error message if thermal is not reachable. Maybe this can > relief the confusion a little bit? With my patch, the configuration will just force the cpufreq driver to be a loadable module as well if thermal is a module, so the dependency can be resolved by loading the thermal module first. I think that is really the best way around the problem, and it matches what other platforms do for the same problem. Arnd