Re: [PATCH v4 net-next 1/5] net: phy: Add PHY_RST_AFTER_PROBE flag

[Florian Fainelli <f.fainelli@gmail.com>]

On 1/18/2021 8:58 AM, Badel, Laurent wrote:
> Add new flag PHY_RST_AFTER_PROBE for LAN8710/20/40. This flag is intended
> for phy_probe() to assert hardware reset after probing the PHY.
> 
> Signed-off-by: Laurent Badel <laurentbadel@eaton.com>
> ---
>  drivers/net/phy/smsc.c | 4 ++--
>  include/linux/phy.h    | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> index ddb78fb4d6dc..5ee45c48efbb 100644
> --- a/drivers/net/phy/smsc.c
> +++ b/drivers/net/phy/smsc.c
> @@ -433,7 +433,7 @@ static struct phy_driver smsc_phy_driver[] = {
>  	.name		= "SMSC LAN8710/LAN8720",
>  
>  	/* PHY_BASIC_FEATURES */
> -
> +	.flags		= PHY_RST_AFTER_PROBE,
>  	.probe		= smsc_phy_probe,
>  	.remove		= smsc_phy_remove,
>  
> @@ -460,7 +460,7 @@ static struct phy_driver smsc_phy_driver[] = {
>  	.name		= "SMSC LAN8740",
>  
>  	/* PHY_BASIC_FEATURES */
> -	.flags		= PHY_RST_AFTER_CLK_EN,
> +	.flags		= PHY_RST_AFTER_CLK_EN & PHY_RST_AFTER_PROBE,


Not PHY_RST_AFTER_CLK_EN | PHY_RST_AFTER_PROBE?
-- 
Florian