From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80B10C04A95 for ; Fri, 23 Sep 2022 18:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232819AbiIWSJa (ORCPT ); Fri, 23 Sep 2022 14:09:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233111AbiIWSJF (ORCPT ); Fri, 23 Sep 2022 14:09:05 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DD023C8F0 for ; Fri, 23 Sep 2022 11:08:57 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id w8so1449832lft.12 for ; Fri, 23 Sep 2022 11:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=KZ+EFd4Uequ+4Kg8YiyMpa28NY8WAdiksQzAfDThIwA=; b=XHNoV3mJT1N0BANJ7QLqKDqvKZ+yDnRdBgqW5km0/zQejO1TlWy0CRFWye53Tx3PMM Pj+UMphOMsZSyzZmYNuHUO2ZNSAFHSLpLrSfHjzPKXbslBv0fUtvIArX51B9659GJwAR rj+lMrX751a+bbFM8mLCVP7v5Ok9G61A7oTwstyZgj2333Kr/X8qgDpFoPCAtBIHM7ay +VOEOmnNknVgce/O4hFLfwKa2f31JElWwt2u6NrSyaMu847AT7T3QPbgmYi6znfmANHF SCOxQlLZUJ618UA2j0H3euIkkXRRL1UoPucSrVamad6r+mEuS0Ge8QsEajSMZ4Y7EbIt Jw2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=KZ+EFd4Uequ+4Kg8YiyMpa28NY8WAdiksQzAfDThIwA=; b=wspmLki1tW9qRcqMI6qjyMoafDkrAVeS1sJh8YBrVY1XOgSMVNGTXt2uRGuqkycSgn JW9O8P46gDlsjk/Irb3l+ZwWKu5Khro1+zC/v6ZPtBPteIbHwA9r8w9Hab52I5uzbURK 52a2ctypFFVf25gNi1UNFPRawncOIhEuzCdXUVjCW6i0AlgFWlLmWuKSRgTqgpC/UzQA pvf92ABjkzXf6netBLTjZozlkt/649PUjQSIsVetiG+2nr8HIPCHP0EvFPGFPmYwgGAT sMEAx9lnTBKPFVqnMe9C77mGmb3FNkV61d4mMdiRrlNLpk/LA3ACTKnFg+vo5wDsSctg EZ+g== X-Gm-Message-State: ACrzQf0pZ4W+2a7TDx68U1IY6cTMl9aHpbhPUGg0JeQj03aadh+p3siA 0CQuuVOXU2eAXxnCjyHiNQotbY3Kt5Werg== X-Google-Smtp-Source: AMsMyM6XnQCLZn79Ex6u3TeQ/biX1F1DQcco9bSC+KZdAFtPUu3j54k0CR5KzT17qZ6tRg7dYO3lLg== X-Received: by 2002:a05:6512:1590:b0:49a:9db4:5a31 with SMTP id bp16-20020a056512159000b0049a9db45a31mr3586377lfb.667.1663956535429; Fri, 23 Sep 2022 11:08:55 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id g15-20020a19e04f000000b0048b0099f40fsm1545218lfj.216.2022.09.23.11.08.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Sep 2022 11:08:55 -0700 (PDT) Message-ID: <35ba126d-be10-2566-63df-3c474cdc8887@linaro.org> Date: Fri, 23 Sep 2022 20:08:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 net-next 12/14] dt-bindings: net: dsa: ocelot: add ocelot-ext documentation Content-Language: en-US To: Colin Foster , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Russell King , Linus Walleij , UNGLinuxDriver@microchip.com, Alexandre Belloni , Claudiu Manoil , Lee Jones , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Vivien Didelot , Andrew Lunn References: <20220922040102.1554459-1-colin.foster@in-advantage.com> <20220922040102.1554459-13-colin.foster@in-advantage.com> From: Krzysztof Kozlowski In-Reply-To: <20220922040102.1554459-13-colin.foster@in-advantage.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/09/2022 06:01, Colin Foster wrote: > The ocelot-ext driver is another sub-device of the Ocelot / Felix driver > system, which currently supports the four internal copper phys. > > Signed-off-by: Colin Foster > --- > > v2 > * New patch > > --- > .../bindings/net/dsa/mscc,ocelot.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > index 8d93ed9c172c..bed575236261 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > @@ -54,9 +54,21 @@ description: | > - phy-mode = "1000base-x": on ports 0, 1, 2, 3 > - phy-mode = "2500base-x": on ports 0, 1, 2, 3 > > + VSC7412 (Ocelot-Ext): > + > + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513, > + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS > + processor that natively support Linux. Additionally, all four devices > + support control over external interfaces, SPI and PCIe. The Ocelot-Ext > + driver is for the external control portion. > + > + The following PHY interface type are currently supported: > + - phy-mode = "internal": on ports 0, 1, 2, 3 "Currently supported" by hardware or by some specific, chosen implementation? If the latter, drop it. If the former, maybe this should be constrained in allOf:if:then. Best regards, Krzysztof