From: Junhao Xie <bigfoot@classfun.cn>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Jonas Karlman <jonas@kwiboo.se>,
Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>,
Dragan Simic <dsimic@manjaro.org>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Junhao Xie <bigfoot@classfun.cn>
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Date: Fri, 6 Sep 2024 12:13:27 +0800 [thread overview]
Message-ID: <35c25812-7ca9-46b4-bd8d-52d14e82a1fe@classfun.cn> (raw)
In-Reply-To: <20240906035018.33211-1-amadeus@jmu.edu.cn>
On 2024/9/6 11:50, Chukun Pan wrote:
> Hi Junhao,
>
>> I have tried rgmii-id with tx_delay/rx_delay 0x38/0x15, or 0x0/0x0,
>> or directly removed tx_delay/rx_delay, they all didn't transmit data.
>>
>> I saw in dwmac-rk.c that when using rgmii-id, the tx_delay/rx_delay
>> properties in dt are ignored?
>
> When using rgmii-id mode, tx_delay and rx_delay can be removed directly.
> But you need to test whether the rx/tx-internal-delay-ps is appropriate.
>
When tx_delay and rx_delay are removed, the driver prints some errors in kmsg.
Maybe we need to modify the driver?
Lines 1657 and 1668 of drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:
rk_gmac-dwmac fe010000.ethernet: Can not read property: tx_delay.
rk_gmac-dwmac fe010000.ethernet: set tx_delay to 0x30
rk_gmac-dwmac fe010000.ethernet: Can not read property: rx_delay.
rk_gmac-dwmac fe010000.ethernet: set rx_delay to 0x10
After testing, rx/tx-internal-delay-ps 1500 seems stable:
$ ping 192.168.0.224
64 bytes from 192.168.0.224: icmp_seq=0 ttl=64 time=1.256 ms
64 bytes from 192.168.0.224: icmp_seq=1 ttl=64 time=1.146 ms
...
$ iperf3 -t 60 -c 192.168.0.224
Connecting to host 192.168.0.224, port 5201
[ 4] local 192.168.0.101 port 59565 connected to 192.168.0.224 port 5201
[ ID] Interval Transfer Bandwidth
[ 4] 0.00-1.00 sec 114 MBytes 956 Mbits/sec
...
[ 4] 59.00-60.00 sec 112 MBytes 942 Mbits/sec
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval Transfer Bandwidth
[ 4] 0.00-60.00 sec 6.58 GBytes 942 Mbits/sec sender
[ 4] 0.00-60.00 sec 6.58 GBytes 942 Mbits/sec receiver
Best regards,
Junhao
next prev parent reply other threads:[~2024-09-06 4:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:14 [PATCH 0/3] Add support for Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:14 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard Junhao Xie
2024-09-04 11:35 ` Krzysztof Kozlowski
2024-09-04 12:14 ` Junhao Xie
2024-09-04 13:29 ` Krzysztof Kozlowski
2024-09-05 5:22 ` Junhao Xie
2024-09-04 11:14 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:36 ` Krzysztof Kozlowski
2024-09-04 11:14 ` [PATCH 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-09-04 17:25 ` Andrew Lunn
2024-09-05 5:47 ` Junhao Xie
2024-09-05 11:17 ` Junhao Xie
2024-09-05 12:53 ` Andrew Lunn
2024-09-05 18:01 ` Junhao Xie
2024-09-05 18:20 ` Andrew Lunn
2024-09-06 3:50 ` Chukun Pan
2024-09-06 4:13 ` Junhao Xie [this message]
2024-09-05 3:40 ` Chukun Pan
2024-09-05 9:17 ` Junhao Xie
2024-09-05 10:01 ` Chukun Pan
2024-09-05 11:06 ` Junhao Xie
2024-09-04 13:36 ` [PATCH 0/3] Add support " Rob Herring (Arm)
2024-09-05 5:37 ` Junhao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c25812-7ca9-46b4-bd8d-52d14e82a1fe@classfun.cn \
--to=bigfoot@classfun.cn \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox