From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Viken Dadhaniya <quic_vdadhani@quicinc.com>,
andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-sm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: vnivarth@quicinc.com, msavaliy@quicinc.com, vtanuku@quicinc.com,
cchiluve@quicinc.com, dkammath@quicinc.com
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7280: add slimbus DT node
Date: Wed, 22 Nov 2023 21:13:28 +0100 [thread overview]
Message-ID: <35ca2ef2-7613-4ddb-b863-2e429337fee3@linaro.org> (raw)
In-Reply-To: <20231116183909.32179-1-quic_vdadhani@quicinc.com>
On 11/16/23 19:39, Viken Dadhaniya wrote:
> Add slimbus DT node to enable slimbus usecase on Bluetooth
> for audio streaming and playback.
How can I test this?
>
> Based on requirement, client team can enable slimbus node
> on target specific dt file.
You can even enable it if you're not part of the client team!
This paragraph is a bit obvious for what it describes
>
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 04bf85b0399a..fba352504f3f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2528,6 +2528,31 @@
> status = "disabled";
> };
>
> + slimbam: dma-controller@3a84000 {
> + compatible = "qcom,bam-v1.7.0";
> + reg = <0x0 0x03a84000 0x0 0x20000>;
0x0 -> 0 to be consistent with other nodes
> + #dma-cells = <1>;
> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
interrupts should come after reg
> + qcom,controlled-remotely;
> + num-channels = <31>;
> + qcom,ee = <1>;
> + qcom,num-ees = <2>;
> + iommus = <&apps_smmu 0x1826 0x0>;
> + status = "disabled";
> + };
> +
> + slim_msm: slim-ngd@3ac0000 {
slim_msm -> slim
> + compatible = "qcom,slim-ngd-v1.5.0";
> + reg = <0x0 0x03ac0000 0x0 0x2c000>;
ditto
> + #address-cells = <1>;
> + #size-cells = <0>;
these two properties should go before the status property
> + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&slimbam 3>, <&slimbam 4>;
> + dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x1826 0x0>;
> + status = "disabled";
> + };
Konrad
next prev parent reply other threads:[~2023-11-22 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 18:39 [PATCH 1/1] arm64: dts: qcom: sc7280: add slimbus DT node Viken Dadhaniya
2023-11-22 20:13 ` Konrad Dybcio [this message]
2023-11-27 12:41 ` Viken Dadhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ca2ef2-7613-4ddb-b863-2e429337fee3@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=cchiluve@quicinc.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkammath@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-sm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vnivarth@quicinc.com \
--cc=vtanuku@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).