From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2085F219CA1 for ; Tue, 12 Nov 2024 20:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731442349; cv=none; b=tmIELSDe78U0Hm+ry0TE6i+5sQ+mijXlBxZs0n2O9OyJQ7UJd2e8PNKEpRi/DfR1frHs172b9EhMg5XtjR4SHO6qGvCI1B/HAqowdbKZsjDTH/8KS4ABj+o5E9x+UGQf3HxO6wA5fSffbx+2YCkP35g+nACZVf8Yol5bd7l8xC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731442349; c=relaxed/simple; bh=bPv/feaj5Glj0pCE0a7gtustT0zmFafSOmethJidReU=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=qkGh0L6aWXPSZjDi6B9nVomW29OB8p7p22pXeS0xxHkmt90/yyh0ABiYMJCt5Zz6yGOVMpIbxdJw20gOp5XzisB+RZhvkEejq4ERywhlhr8v71surjeiLakzo/aWaIncxN3IakGuPldO1904zJBjiSw9v9knUGUU7qQOLgbPVeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=PimX1dvG; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="PimX1dvG" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3e5ffbc6acbso3621658b6e.3 for ; Tue, 12 Nov 2024 12:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1731442345; x=1732047145; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Dl6oW+royBVKzJh6c3nIJ5U6CjfR2o5cVhOS2LXCTeg=; b=PimX1dvG4+SY+HOhJqrNDzieDq007r98POZ9V4XmKYNGB3Eh9R1XmfKUXb5dgxfPaP w2i5UK7WMfg046ERjmeILTQOTTCQi7jmID5T3FnUOEs0Euk7bel3HThScgpHi7Mpxu+A 3AirrmeEmB9fG5KKGfahPXtyqmMU0kUBcPVpZu7NZOxJIQt+GA+FYRd8y/tgALk1bfKH 3ZmzK0NJ2xi1J1IFxxd3DtmwZ1ImrC2zIDJft38iPoC9YlmHp39+JhGpC5kF25ij/4l5 fUeXmHUKHlr+YkTu4VXCgCdpDlCfBvu6K6sPq/fMxZVgAhVXzDgPOi8fkg99+w0y0He0 xt+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731442345; x=1732047145; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dl6oW+royBVKzJh6c3nIJ5U6CjfR2o5cVhOS2LXCTeg=; b=vuuElWS64AYDnkEXQzl0SIj0WkTxIybL/E1sXP8ZxEo81/uGHdTFsgJ5qjYN27BAcN VDBeWeLSRmHIDvkqT+qkmJhjRyNgcMg4AHqN/HYxa5VnhzwRmdg4cRGK0rkKLdoiaWvz c84C/TGv4DFfssAy7z+3MpU3NJ3cR0ufTPA4IsikfivurywSNwvxErq6P+W5ZD0ANTWZ X7MwGwzhcyV8xjHpMtEUDEgXT8RSxkvf5c3pAFWqhHiZHheBnNM2qb3loRzT2XG9LWFN uQKZmgCUOWBiO/IaryXaTJocicIJkp4Xb+8+3c3zsl+rcCDvP85VUqcfUCtMV1o3yNB2 QciA== X-Forwarded-Encrypted: i=1; AJvYcCXtUsrks6ySdukKdry8QjwHz1cbBwqZR9rvxBXPdAyXKCwpoM2IEiZf6S8X3rc3bUTeo7uhpn0jIedS@vger.kernel.org X-Gm-Message-State: AOJu0Yx85osWTPHrkGDAqoZ0YLsfX9NIA2BmUi3x7lnugNt7mmUFOPbV OeQNVsxJIEMsgYGYtZW3wMzyRd6gVQaivqwmczDpxLiwZ+psfnZIIrBswibZsEE= X-Google-Smtp-Source: AGHT+IEUK1lwL53dpSjHoatFyNXNN93/2KKOkopUDAWIapQKMOXvlEOPLtpAZYQbhUpekTLpeop8UA== X-Received: by 2002:a05:6808:11c7:b0:3e5:d591:c9a9 with SMTP id 5614622812f47-3e7947031famr17094130b6e.26.1731442345040; Tue, 12 Nov 2024 12:12:25 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e7b096b5dcsm47591b6e.20.2024.11.12.12.12.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 12:12:24 -0800 (PST) Message-ID: <35d88f91-b4bd-426e-aa75-40741b8c3bd0@baylibre.com> Date: Tue, 12 Nov 2024 14:12:22 -0600 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/8] iio: adc: adi-axi-adc: add oversampling To: Antoniu Miclaus , jic23@kernel.org, robh@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org References: <20241111121203.3699-1-antoniu.miclaus@analog.com> <20241111121203.3699-7-antoniu.miclaus@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20241111121203.3699-7-antoniu.miclaus@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/11/24 6:12 AM, Antoniu Miclaus wrote: > Add support for enabling/disabling oversampling. > > Signed-off-by: Antoniu Miclaus > --- > changes in v6: > - add support for oversampling enable/disable. > drivers/iio/adc/adi-axi-adc.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > index 9bf967d5b730..8ec668f59c88 100644 > --- a/drivers/iio/adc/adi-axi-adc.c > +++ b/drivers/iio/adc/adi-axi-adc.c > @@ -46,6 +46,7 @@ > #define ADI_AXI_ADC_CTRL_DDR_EDGESEL_MASK BIT(1) > > #define ADI_AXI_ADC_REG_CNTRL_3 0x004c > +#define AD485X_CNTRL_3_CUSTOM_CTRL_OS_EN_MSK BIT(2) > #define AD485X_CNTRL_3_CUSTOM_CTRL_PACKET_FORMAT_MSK GENMASK(1, 0) > #define AD485X_PACKET_FORMAT_20BIT 0x0 > #define AD485X_PACKET_FORMAT_24BIT 0x1 > @@ -341,6 +342,14 @@ static int axi_adc_data_size_set(struct iio_backend *back, unsigned int size) > AD485X_CNTRL_3_CUSTOM_CTRL_PACKET_FORMAT_MSK, val); > } > > +static int axi_adc_oversampling_en(struct iio_backend *back, bool en) > +{ > + struct adi_axi_adc_state *st = iio_backend_get_priv(back); > + > + return regmap_update_bits(st->regmap, ADI_AXI_ADC_REG_CNTRL_3, > + AD485X_CNTRL_3_CUSTOM_CTRL_OS_EN_MSK, en); This needs FIELD_PREP() to apply the correct shift to en. > +} > + > static struct iio_buffer *axi_adc_request_buffer(struct iio_backend *back, > struct iio_dev *indio_dev) > { > @@ -390,6 +399,7 @@ static const struct iio_backend_ops adi_axi_adc_ops = { > .chan_status = axi_adc_chan_status, > .interface_type_get = axi_adc_interface_type_get, > .data_size_set = axi_adc_data_size_set, > + .oversampling_en = axi_adc_oversampling_en, > .debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access), > .debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status), > };