From: Caleb Connolly <caleb.connolly@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexey Klimov <alexey.klimov@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: qrb4210-rb2: set role-switch-default-mode
Date: Thu, 20 Jun 2024 18:49:46 +0200 [thread overview]
Message-ID: <35d9f16d-c009-4383-a616-9b21f0819b46@linaro.org> (raw)
In-Reply-To: <v3dgoeybewgegi2xuixhaq5c7jwju6wojrmzcq3rtb5f5r5nfu@6gj4tfz5blx7>
On 20/06/2024 17:07, Dmitry Baryshkov wrote:
> On Thu, Jun 20, 2024 at 03:30:29PM GMT, Caleb Connolly wrote:
>>
>>
>> On 20/06/2024 15:15, Dmitry Baryshkov wrote:
>>> On Wed, 19 Jun 2024 at 23:33, Caleb Connolly <caleb.connolly@linaro.org> wrote:
>>>>
>>>> Give a hint to the OS which role we prefer. Host mode generally makes
>>>> the most sense.
>>>
>>> Why?
>>
>> I guess this is subjective, but on these boards the more common usecase is
>> host mode (before we had role switching we forced them to host mode...).
>>>
>>>>
>>>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>
>>> Would it make sense to set this for all the RB and HDK boards?
>>
>> The rb1/2 are the only boards which lack multiple USB controllers. For
>> others it's fine to leave the default (peripheral mode).
>
> SM8450-HDK and SM8650-HDK also have just a single USB-C port. My logic
> was slightly different. We consider these devices to be SBCs, so I'd
> expect that they act as hosts _by_default_. If somebody plugs RB board
> into a laptop, then it's logical that it should work as a device, but
> between the phone and the RB board the RB is a host.
Ahh I see, then yes perhaps it makes sense. I can send v2 with patches
for other boards too.
* qrb2210-rb1
* qrb4210-rb2
* sm8450-hdk
* sm8650-hdk
Any others?
>
--
// Caleb (they/them)
next prev parent reply other threads:[~2024-06-20 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 20:33 [PATCH 0/2] qcom: dts: qrb4210-rb2 usb/emmc fixes Caleb Connolly
2024-06-19 20:33 ` [PATCH 1/2] arm64: dts: qcom: sm6115: add iommu for sdhc_1 Caleb Connolly
2024-06-20 13:11 ` Dmitry Baryshkov
2024-06-19 20:33 ` [PATCH 2/2] arm64: dts: qcom: qrb4210-rb2: set role-switch-default-mode Caleb Connolly
2024-06-20 13:15 ` Dmitry Baryshkov
2024-06-20 13:30 ` Caleb Connolly
2024-06-20 15:07 ` Dmitry Baryshkov
2024-06-20 16:49 ` Caleb Connolly [this message]
2024-06-20 18:22 ` Dmitry Baryshkov
2024-06-21 5:32 ` Bjorn Andersson
2024-06-21 15:26 ` Dmitry Baryshkov
2024-06-21 6:11 ` (subset) [PATCH 0/2] qcom: dts: qrb4210-rb2 usb/emmc fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d9f16d-c009-4383-a616-9b21f0819b46@linaro.org \
--to=caleb.connolly@linaro.org \
--cc=alexey.klimov@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).