From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E41B1B29AC for ; Thu, 20 Jun 2024 16:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718902192; cv=none; b=hmMwRk1G5+5xf13rm5CZOUmTpbWrv6NtCb80WeXzx09hNos2Z5drw/G8hFXMpj/3DzvQXjXmPLJVuY6fMmJGYA0qj0X/BrnvrISxJ7SoHIVtcMOm67aD+pnTKQj9nOI+bMRnBZGc9pVSGEQB3QHfUogXFTkxAy4rW6lrpmYDv4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718902192; c=relaxed/simple; bh=K/cfNSTDSkBQxZsTkqMrHOm6LPQ4yATi/xG2niJvV5M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Cus55o0pznHIRjK51k5zNbBtFgYU651OEt4hC08a4A/dQE/a+ARf9zJXVsJAY7YwFj/8HSswUT2PihLrgF4WycezAUSjXkQKHxi5mCKTaRp6C82tZUK9AR4htxrs5LUKfVtJgMK9svMzK1OVVPNEhkBFJ/XhF1U7fikLB3sno8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pCtwnP2J; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pCtwnP2J" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a6ef8bf500dso112223266b.0 for ; Thu, 20 Jun 2024 09:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718902189; x=1719506989; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GqQopnvWVUJ77bCPyUL9r68U4uxLIHub62go1lzROFU=; b=pCtwnP2J21ZnD9BczwYhqtGHXePBF3JUCj1Cu7jTT0cEpaajtbdsrT4PodvM9JDi/V 8Jr1h7TymEmi1yjWbseFz/+d8jsgZXbrwAy6RBrfwXH5zZQk2oxJEZdwKF/Qzwdp+Dwq 2JsZ/P5YspRDpCCzWNo4RNzkWlsKmcTFWk7itP4R1pRDJskkKPa67tMlilB3qmfVjw6c Wzh9XpsTxryA3iK6iSOj1bX5BiQJ/Aq7TD06bzLT6+1GYOVauFYRlV4+ftAnzHBn8dti nfdYKyTR1r6q8BMMHqGW9ojloANAQz8LB2G0mOdsAlpydId/wEf/+/YH1h72RMAnb32J b8AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718902189; x=1719506989; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GqQopnvWVUJ77bCPyUL9r68U4uxLIHub62go1lzROFU=; b=WpEwDiu+s8l7SJK09JwLKibzf2CQZcZ+opDn5iQCsvP9NOMQo10IbGXX5nLurymbRQ AjuzD5pXRWFTOhHVV6pKPImr2nwmyOCmIlJdfxJ9ELDUuaZ/27rHR9VvHrqeORcmrLd4 Livn52vf6xzN7HluvAG2RlbAVTyHIikBbbIOnZtlkXBnAvW8xc8yBiI8kLvwiRrzecFP L/l3W7N68G6u5ItJ5dYUeNaMuAPB7DFpB8huo6+IF2wRYuuSrO+RIcHid+JJMkj/YWk3 Xa77r9Pml8y2OFV7kY9LX2B4I/dRyQ6G1TeTE/L9P0tuufD5c2pLrWvk/iEVzONJZ8PG QpAg== X-Forwarded-Encrypted: i=1; AJvYcCUmc0H5EepMX+mY1VM57xowiiGgKG1o6YSOSSnrzHvH0vt/HV2Z772RnTOFWp9d1KX9XuG8TVeUOsBKJjlY5hVJX8J/Pf/3dvj+ug== X-Gm-Message-State: AOJu0YxL6JmMCeLDFhpzo9saylRPRMLuBIZmyFWzFV4tbCJNl9UFBZ0w pdwssPuc5U2LpCzm22OUXzLADYMbcP7e0gl5UhAkMEr8W3wD3+kct5oSg9kWiZc= X-Google-Smtp-Source: AGHT+IGysnIrSKn5ZsCRoX6C8aN64NnfdvBmRtWtf5nKzRPFf3y/BPDA4dK2cGa7MsKDCazb1HAtkw== X-Received: by 2002:a17:907:7716:b0:a6f:5318:b8f7 with SMTP id a640c23a62f3a-a6fab645215mr361554666b.43.1718902188581; Thu, 20 Jun 2024 09:49:48 -0700 (PDT) Received: from ?IPV6:2a02:8109:aa0d:be00::ebdd? ([2a02:8109:aa0d:be00::ebdd]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56f42badsm782858666b.184.2024.06.20.09.49.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 09:49:48 -0700 (PDT) Message-ID: <35d9f16d-c009-4383-a616-9b21f0819b46@linaro.org> Date: Thu, 20 Jun 2024 18:49:46 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: qrb4210-rb2: set role-switch-default-mode To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexey Klimov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20240619-rb2-fixes-v1-0-1d2b1d711969@linaro.org> <20240619-rb2-fixes-v1-2-1d2b1d711969@linaro.org> Content-Language: en-US From: Caleb Connolly In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/06/2024 17:07, Dmitry Baryshkov wrote: > On Thu, Jun 20, 2024 at 03:30:29PM GMT, Caleb Connolly wrote: >> >> >> On 20/06/2024 15:15, Dmitry Baryshkov wrote: >>> On Wed, 19 Jun 2024 at 23:33, Caleb Connolly wrote: >>>> >>>> Give a hint to the OS which role we prefer. Host mode generally makes >>>> the most sense. >>> >>> Why? >> >> I guess this is subjective, but on these boards the more common usecase is >> host mode (before we had role switching we forced them to host mode...). >>> >>>> >>>> Signed-off-by: Caleb Connolly >>>> --- >>>> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>> >>> Would it make sense to set this for all the RB and HDK boards? >> >> The rb1/2 are the only boards which lack multiple USB controllers. For >> others it's fine to leave the default (peripheral mode). > > SM8450-HDK and SM8650-HDK also have just a single USB-C port. My logic > was slightly different. We consider these devices to be SBCs, so I'd > expect that they act as hosts _by_default_. If somebody plugs RB board > into a laptop, then it's logical that it should work as a device, but > between the phone and the RB board the RB is a host. Ahh I see, then yes perhaps it makes sense. I can send v2 with patches for other boards too. * qrb2210-rb1 * qrb4210-rb2 * sm8450-hdk * sm8650-hdk Any others? > -- // Caleb (they/them)