public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jie Luo <quic_luoj@quicinc.com>
To: George Moussalem <george.moussalem@outlook.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] arm64: dts: qcom: Update IPQ5018 xo_board_clk to use fixed factor clock
Date: Sun, 4 May 2025 10:17:21 +0800	[thread overview]
Message-ID: <35dbe18b-2c10-4af2-8ffc-05278158be68@quicinc.com> (raw)
In-Reply-To: <DS7PR19MB888312EBE14582523C3B95209D8D2@DS7PR19MB8883.namprd19.prod.outlook.com>



On 5/2/2025 11:53 PM, George Moussalem wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55- 
>>> v1.dts b/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dts
>>> index 
>>> 5bb021cb29cd39cb95035bfac1bdbc976439838b..7a25af57749c8e8c9a6a185437886b04b0d99e8e 100644
>>> --- a/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dts
>>> +++ b/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dts
>>> @@ -124,5 +124,6 @@ uart_pins: uart-pins-state {
>>>   };
>>>   &xo_board_clk {
>>> -    clock-frequency = <24000000>;
>>> +    clock-div = <4>;
>>> +    clock-mult = <1>;
>>>   };
>>
>> Is the divider a part of the SoC? If so, please move these values to 
>> the SoC dtsi file.
> 
> my 'best guess' is that the ref clk for ipq5018 is always 96MHZ and the 
> XO board clk is 24MHZ, so it should be safe to move it to the dtsi, but 
> this is purely based on the 5 different board types I have.
> 
> @Luo Jie: can you confirm the above?

The xo_board_clk is achieved by the bootstrap PINs, which should be
always 24 MHZ, we can move it to the RDP common DTSI if it is existed.


  reply	other threads:[~2025-05-04  2:17 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 10:15 [PATCH 0/6] Add CMN PLL clock controller support for IPQ5018 George Moussalem via B4 Relay
2025-05-02 10:15 ` [PATCH 1/6] dt-bindings: clock: qcom: Add CMN PLL support for IPQ5018 SoC George Moussalem via B4 Relay
2025-05-02 11:35   ` Rob Herring (Arm)
2025-05-02 14:17   ` Rob Herring
2025-05-02 16:14     ` George Moussalem
2025-05-04  1:49   ` Jie Luo
2025-05-04  7:03     ` George Moussalem
2025-05-05  2:55       ` Jie Luo
2025-05-02 10:15 ` [PATCH 2/6] clk: qcom: ipq5018: mark XO clock as critical George Moussalem via B4 Relay
2025-05-02 10:29   ` Konrad Dybcio
2025-05-02 12:45     ` George Moussalem
     [not found]     ` <b05d9351-cc79-4e60-a6e0-de2fe698098f@outlook.com>
2025-05-04  6:59       ` George Moussalem
2025-05-06  0:59         ` Konrad Dybcio
2025-05-02 10:15 ` [PATCH 3/6] clk: qcom: ipq-cmn-pll: Add IPQ5018 SoC support George Moussalem via B4 Relay
2025-05-02 10:38   ` Konrad Dybcio
2025-05-02 13:04     ` George Moussalem
2025-05-02 10:15 ` [PATCH 4/6] dt-bindings: mfd: qcom,tcsr: Add compatible for IPQ5018 George Moussalem via B4 Relay
2025-05-09 22:05   ` Rob Herring (Arm)
2025-05-02 10:15 ` [PATCH 5/6] arm64: dts: ipq5018: Add CMN PLL node George Moussalem via B4 Relay
2025-05-04  1:53   ` Jie Luo
2025-05-04  7:10     ` George Moussalem
2025-05-02 10:15 ` [PATCH 6/6] arm64: dts: qcom: Update IPQ5018 xo_board_clk to use fixed factor clock George Moussalem via B4 Relay
2025-05-02 10:39   ` Konrad Dybcio
2025-05-02 14:45   ` Dmitry Baryshkov
2025-05-02 15:53     ` George Moussalem
2025-05-04  2:17       ` Jie Luo [this message]
2025-05-04  7:14         ` George Moussalem
2025-05-02 19:31 ` [PATCH 0/6] Add CMN PLL clock controller support for IPQ5018 Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35dbe18b-2c10-4af2-8ffc-05278158be68@quicinc.com \
    --to=quic_luoj@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=george.moussalem@outlook.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox