From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDDB928640B for ; Wed, 23 Jul 2025 09:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753262983; cv=none; b=HtEs56NTcM52DdbKjnlTZk/ywB/wfiPWCkeL3UUqH3etVNsJ+Ah81uc+lA+zP6TPEQA03yeIXcHcgRE4/P4AujZQuwlxTnWR2aEvCmmn+gZZbpqfpEykOsP4P0NmHq9YXcLlsKGirtWOzHscOauWowgWxQLZ1Dr5qdDfdjzi70g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753262983; c=relaxed/simple; bh=MdmN0BHl9qK/x/8lXU5gTxriBjlVUKoKDGlmM00y1EI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XaDtAM/DZlaXAThsBOCdbPOP5KpEClmU7Kl4JDFtYqy7OI3nzuA302cJLHdKOWoHn5nLkreaH1F5kMMP05dsqTHXfoKLwCEKgCKxwxaQHbg/kGh9gMrpQZlKlj7B+jMMOdSyAFu/rlnuiFeSRKQf+dCzugfhqo19L1QJbc/T0Ug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ueVmy-0008Tw-Ui; Wed, 23 Jul 2025 11:29:29 +0200 Message-ID: <35debf21-bca7-480f-a61e-7b0494f10ca5@pengutronix.de> Date: Wed, 23 Jul 2025 11:29:27 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] parse horizontal/vertical flip properties To: Jacopo Mondi Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacopo Mondi , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, entwicklung@pengutronix.de References: <20250718-fpf-media-dt-flip-v1-0-75b3a938b4be@pengutronix.de> Content-Language: en-US, de-DE From: Fabian Pfitzner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: f.pfitzner@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org On 7/23/25 11:17, Jacopo Mondi wrote: > Hi Fabian > > On Wed, Jul 23, 2025 at 10:58:28AM +0200, Fabian Pfitzner wrote: >> There are cameras containing a mirror on their optical path e. g. when >> mounted upside down. > How is this different from 'rotation = 180' ? If you simply want to flip the output (e. g. horizontally), you cannot do this with a rotation. The camera I'm referring to is not only upside down, but also flipped horizontally. > >> Introduce two options to change the device's flip property via device tree. >> >> As there is already support for the panel-common driver [1], add it for cameras in the same way. >> >> [1] commit 3c0ecd83eee9 ("dt-bindings: display: panel: Move flip properties to panel-common") >> >> Signed-off-by: Fabian Pfitzner >> --- >> Fabian Pfitzner (2): >> media: dt-bindings: add flip properties >> media: v4l: fwnode: parse horizontal/vertical flip properties >> >> .../devicetree/bindings/media/video-interface-devices.yaml | 8 ++++++++ >> drivers/media/v4l2-core/v4l2-fwnode.c | 3 +++ >> include/media/v4l2-fwnode.h | 4 ++++ >> 3 files changed, 15 insertions(+) >> --- >> base-commit: 6832a9317eee280117cd695fa885b2b7a7a38daf >> change-id: 20250718-fpf-media-dt-flip-7fcad30bcfb7 >> >> Best regards, >> -- >> Fabian Pfitzner >> -- Pengutronix e.K. | Fabian Pfitzner | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |