From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ICDJsHfQ" Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461F4C1 for ; Thu, 30 Nov 2023 04:05:12 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-54b8a4d64b5so872117a12.0 for ; Thu, 30 Nov 2023 04:05:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701345911; x=1701950711; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BVVWmWantvDjX2mjd5YLmNX+K3BZwqjWdaBKpkdsAuI=; b=ICDJsHfQ0+4sNQmguyBBoomDl9ZRxTb2rC/koOTjbY46vp+Wg1/SkTNXHDg53+abkK ZFzQdgPaaD7IaMbMP6Z5AUsAEywGC4lcMo605txiWjl7pZTDC54PXeZpnDtClvd4Onei OEMnh03nrHZFWxZXdSeAxAdY9HyOuFpKkgbBc50guWTd0lI6ptXR3D4V4lC4pWqWC4do h5mpEUfTt4hZ6pPbsvXbLuqJf8zYRYGjmIxmsauzsGrDnuv1mGZOPiNJtEEtXP3Fn6Xv pvg7CSK2Kp7oszucHzLdGJD4+olgErymIaJj0S8v5TCkEyUn3NYtZ9tzz1s/QlVb98b9 dr1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701345911; x=1701950711; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BVVWmWantvDjX2mjd5YLmNX+K3BZwqjWdaBKpkdsAuI=; b=OM7jwyw6i58vVG2Glmao6Jo7bBetKpnW10OnSRBvOnDNdIeib2VGSoExu0XB1iLSTm EB+GE1AhUIyj+tLAD+cicTa88yGL36APOxsGmoJOV11p0/GIytSYR+le3LccKh3F/8Vd yKOyE6Ut+dnIOUn0zz8V6US8XNX8AHJJEJdxMI4rUJDc+pYxqDO/YCAQMnc7Gm0Bu+kP K3EBK4BxwDNerTT1bKZWiZ0JryShtXK4+j79XCJLMICWPpO+pUwtNNa99NADNqF1XvoN rQd5Zfd7POhZwXQkx2W0KAwyy5+YnVoMur+78CuKYbA3+Q2rJBuhYiVYaMU7jS/cyZH6 J9QQ== X-Gm-Message-State: AOJu0YxV+DN71GDSEiN/bWROl2ZKj8va59jE23dtqeVBOqG8woxOPIbh lSRgWscReDAu0G9cCjVcZYMdjQ== X-Google-Smtp-Source: AGHT+IFu3MWszFDtvdH7QCKIG+uVLRvGsOyg1FE+Ipx6VTJRcTOCbxIdlbc1w8Z5Qlcy/EavnoZd2g== X-Received: by 2002:a05:6402:704:b0:548:657c:9110 with SMTP id w4-20020a056402070400b00548657c9110mr15688921edx.38.1701345910655; Thu, 30 Nov 2023 04:05:10 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id v9-20020aa7d9c9000000b0054b1fca00c7sm486173eds.74.2023.11.30.04.05.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 04:05:10 -0800 (PST) Message-ID: <35dfd382-14ed-43cb-be0a-d042f765ecdc@linaro.org> Date: Thu, 30 Nov 2023 13:05:08 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: zynqmp: Add missing destination mailbox compatible Content-Language: en-US To: Michal Simek , linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com Cc: Conor Dooley , Krzysztof Kozlowski , Laurent Pinchart , Michael Grzeschik , Parth Gajjar , Radhey Shyam Pandey , Rob Herring , Sai Krishna Potthuri , Varalaxmi Bingi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <96460adbb99ea829a2a95c72a40118f81946a559.1701335951.git.michal.simek@amd.com> <79f65b96-9015-41c4-b4ee-a82526c9eefc@linaro.org> <656a0186-e06f-4518-adc2-68dfb2970157@amd.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <656a0186-e06f-4518-adc2-68dfb2970157@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/11/2023 11:02, Michal Simek wrote: > > > On 11/30/23 10:29, Krzysztof Kozlowski wrote: >> On 30/11/2023 10:19, Michal Simek wrote: >>> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox >>> compatible") make compatible string for child nodes mandatory that's why >>> add it. >>> >>> Signed-off-by: Michal Simek >>> --- >>> >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> index f5e1eb8cb3b7..eaba466804bc 100644 >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi { >>> >>> ipi_mailbox_pmu1: mailbox@ff9905c0 { >>> bootph-all; >>> + compatible = "xlnx,zynqmp-ipi-dest-mailbox"; >> >> Probably you want it as first property. Although then reg is also placed >> odd, but it's all because bootph-all was put at the beginning. > > When DTS conding style is approved I will need to resort all that nodes based on > it. I did this change to be aligned with current style which this file has. > What do you think? Hm, indeed. So it is entirely up to you :) Best regards, Krzysztof